You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Room - User mention in the system message after inviting member to the room cannot be copied #29978
Version Number: 1.3.87-1 Reproducible in staging?: Yes Reproducible in production?: No, new feature If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Go to staging.new.expensify.com
Create a room
Click on the room header > Members > Invite > Invite anyone to the room
Right click on the system invitation message > Copy to clipboard
Paste the message in the composer
Expected Result:
The system message along with the user mention will be copied
Actual Result:
User mention in the system message is not copied. This is because the logic that's called when we click the "Copy" button hasn't been updated to handle accountID based mentions. It only handles login-based mentions.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Looks like the report INVITETOROOM report action's html message is in the format <muted-text>invited <mention-user accountID=XXX></mention-user></muted-text> and it might need to be <muted-text>invited <mention-user accountID=XXX>person@domain.com</mention-user></muted-text>. Going to check when/where we added this.
Anyway you can still triple-click + Command+C on the message, and it will copy everything including the invitee's email address, so I don't know if this is worth being a blocker.
Reapplying the Bug label to get another BZ member on this while I am OOO til Nov 13. Thanks @MitchExpensify I'll grab this back from you when I return!
@cead22@ArekChr@stephanieelliott@MitchExpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!
📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
Activity
melvin-bot commentedon Oct 19, 2023
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 19, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Oct 19, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Oct 19, 2023
Triggered auto assignment to @cead22 (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.francoisl commentedon Oct 19, 2023
Looks like the report
INVITETOROOMreport action'shtmlmessage is in the format<muted-text>invited <mention-user accountID=XXX></mention-user></muted-text>and it might need to be<muted-text>invited <mention-user accountID=XXX>person@domain.com</mention-user></muted-text>. Going to check when/where we added this.francoisl commentedon Oct 19, 2023
cc @jasperhuangg I see recent changes to InviteToRoom in https://github.com/Expensify/Auth/pull/8776/, do you have an idea if it's related?
Anyway you can still triple-click + Command+C on the message, and it will copy everything including the invitee's email address, so I don't know if this is worth being a blocker.
cead22 commentedon Oct 19, 2023
If it's on staging and not production, it can't be due to an Auth change right?
46 remaining items
melvin-bot commentedon Nov 8, 2023
Triggered auto assignment to @MitchExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Nov 8, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)stephanieelliott commentedon Nov 8, 2023
Reapplying the
Buglabel to get another BZ member on this while I am OOO til Nov 13. Thanks @MitchExpensify I'll grab this back from you when I return!melvin-bot commentedon Nov 9, 2023
@cead22 @ArekChr @stephanieelliott @MitchExpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!
melvin-bot commentedon Nov 9, 2023
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
melvin-bot commentedon Nov 9, 2023
📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
tienifr commentedon Nov 10, 2023
Expensify/expensify-common#600 The PR fix expensify-common is up @ArekChr
tienifr commentedon Nov 20, 2023
@cead22 @stephanieelliott The PR already fixed this issue. I just closed my PR.
stephanieelliott commentedon Nov 21, 2023
Thanks @tienifr! Per this internal SO, we'll pay out as normal for this PR and review.
Summarizing payment on this issue:
Upwork job is here, no bonus is included on payout