Skip to content

[$500] Room - User mention in the system message after inviting member to the room cannot be copied #29978

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.87-1
Reproducible in staging?: Yes
Reproducible in production?: No, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a room
  3. Click on the room header > Members > Invite > Invite anyone to the room
  4. Right click on the system invitation message > Copy to clipboard
  5. Paste the message in the composer

Expected Result:

The system message along with the user mention will be copied

Actual Result:

User mention in the system message is not copied. This is because the logic that's called when we click the "Copy" button hasn't been updated to handle accountID based mentions. It only handles login-based mentions.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Bug6242996_1697722627942.20231019_201734.mp4
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018b64b832924292d8
  • Upwork Job ID: 1715082222817452032
  • Last Price Increase: 2023-11-09
  • Automatic offers:
    • tienifr | Contributor | 27598151

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 19, 2023
  2. melvin-bot commented on Oct 19, 2023

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Oct 19, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Oct 19, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Oct 19, 2023

    @melvin-bot

    Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. francoisl commented on Oct 19, 2023

    @francoisl
    Contributor

    Looks like the report INVITETOROOM report action's html message is in the format <muted-text>invited <mention-user accountID=XXX></mention-user></muted-text> and it might need to be <muted-text>invited <mention-user accountID=XXX>person@domain.com</mention-user></muted-text>. Going to check when/where we added this.

    image
  7. francoisl commented on Oct 19, 2023

    @francoisl
    Contributor

    cc @jasperhuangg I see recent changes to InviteToRoom in https://github.com/Expensify/Auth/pull/8776/, do you have an idea if it's related?

    Anyway you can still triple-click + Command+C on the message, and it will copy everything including the invitee's email address, so I don't know if this is worth being a blocker.

  8. cead22 commented on Oct 19, 2023

    @cead22
    Contributor

    If it's on staging and not production, it can't be due to an Auth change right?

  9. 46 remaining items

  10. melvin-bot commented on Nov 8, 2023

    @melvin-bot

    Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  11. melvin-bot commented on Nov 8, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  12. stephanieelliott commented on Nov 8, 2023

    @stephanieelliott
    Contributor

    Reapplying the Bug label to get another BZ member on this while I am OOO til Nov 13. Thanks @MitchExpensify I'll grab this back from you when I return!

  13. melvin-bot commented on Nov 9, 2023

    @melvin-bot

    @cead22 @ArekChr @stephanieelliott @MitchExpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

  14. melvin-bot commented on Nov 9, 2023

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  15. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 9, 2023
  16. melvin-bot commented on Nov 9, 2023

    @melvin-bot

    📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  17. tienifr commented on Nov 10, 2023

    @tienifr
    Contributor

    Expensify/expensify-common#600 The PR fix expensify-common is up @ArekChr

  18. tienifr commented on Nov 20, 2023

    @tienifr
    Contributor

    @cead22 @stephanieelliott The PR already fixed this issue. I just closed my PR.

  19. stephanieelliott commented on Nov 21, 2023

    @stephanieelliott
    Contributor

    Thanks @tienifr! Per this internal SO, we'll pay out as normal for this PR and review.

    Summarizing payment on this issue:

    • Issue reporter: N/A, Applause internal
    • Contributor: @tienifr, $500 paid via Upwork
    • Contributor+: @ArekChr, no payment due (expert contrib)

    Upwork job is here, no bonus is included on payout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions