You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-31] [HOLD for payment 2023-10-30] [CRITICAL] [P2P Activation] Improve KYC delay handling #30088
When KYC is delayed during the wallet upgrade flow, a user lands on a loading page without any guidance. This can take a very long time, or potentially forever, if they hit certain errors.
Solution
To start, let's provide better guidance when KYC is delayed. If the wallet is still pending when the user completes KYC:
Land them back on the Wallet page
Hide the Enable wallet button while KYC is delayed and
Show the following message in the wallet tile: We're reviewing your information and will be in touch shortly
changed the title [-]Improve KYC error handling for waller enablement flow[/-][+][CRITICAL] [P2P Activation] Improve KYC error handling for waller enablement flow[/+]on Oct 20, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.89-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-31. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@allroundexpertsdoes not require payment (Eligible for Manual Requests)
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
[@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@allroundexperts] Determine if we should create a regression test for this bug.
[@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Oct 20, 2023
Triggered auto assignment to @puneetlath (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 20, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)[-]Improve KYC error handling for waller enablement flow[/-][+][CRITICAL] [P2P Activation] Improve KYC error handling for waller enablement flow[/+]puneetlath commentedon Oct 20, 2023
@kevinksullivan gonna reassign you as BZ since this is for wave8. Feel free to re-assign to whoever you think is best.
MariaHCD commentedon Oct 20, 2023
BE PR that adds a new prop
isPendingOnfidoResultto the wallet information is here: https://github.com/Expensify/Auth/pull/8991The App will use this new prop to determine if we need to show the
We're reviewing your information and will be in touch shortlymessage19 remaining items
melvin-bot commentedon Oct 24, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.89-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-31. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 24, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
marcaaron commentedon Oct 24, 2023
Either work for me. And yeah not really sure how to properly QA this on prod since we need Onfido to fail in two different ways 🙃
kevinksullivan commentedon Oct 31, 2023
Payment summary:
JmillsExpensify commentedon Nov 3, 2023
$500 payment for @allroundexperts based on comment above.