Skip to content

[HOLD for payment 2023-10-31] Staging is crashing when opening a chat #30109

Closed

Description

@mallenexpensify

Coming from this Slack post

I'm getting a crash on login on staging and the PR for/from here already hit staging.

It's mostly happening after logging in with mallen@expensifail.com account and trying to open my existing chat with mallen@expensify.com
ReportID: https://new.expensify.com/r/2545867663703719

Happening on Mac - Chrome and Windows - Chrome (via browserstack) and iOS - chrome.

@situchan thinks it's likely a regression from
#28798

Gonna hold off on the bottom stuff for a min....

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

Break down in numbered steps

Expected Result:

Describe what you think should've happened

Actual Result:

Describe what actually happened

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 20, 2023
  2. melvin-bot commented on Oct 20, 2023

    @melvin-bot

    Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Oct 20, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. mallenexpensify commented on Oct 20, 2023

    @mallenexpensify
    ContributorAuthor

    @situchan , wanna propose a solution?

  5. OSBotify commented on Oct 20, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot commented on Oct 20, 2023

    @melvin-bot

    Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  7. 20 remaining items

  8. changed the title [-][HOLD for payment 2023-10-30] Staging is crashing when opening a chat[/-] [+][HOLD for payment 2023-10-31] [HOLD for payment 2023-10-30] Staging is crashing when opening a chat[/+] on Oct 24, 2023
  9. melvin-bot commented on Oct 24, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.89-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-31. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  10. melvin-bot commented on Oct 24, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@situchan] The PR that introduced the bug has been identified. Link to the PR:
    • [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@situchan] Determine if we should create a regression test for this bug.
    • [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  11. changed the title [-][HOLD for payment 2023-10-31] [HOLD for payment 2023-10-30] Staging is crashing when opening a chat[/-] [+][HOLD for payment 2023-10-31] Staging is crashing when opening a chat[/+] on Oct 24, 2023
  12. mallenexpensify commented on Oct 31, 2023

    @mallenexpensify
    ContributorAuthor

    Compensating @situchan for discovering and reporting this deploy blocker, I chose $100 because it's 2x the bug report amount which seems fair for quick work finding a deploy blocker.

    Issue reporter: @situchan paid $100 via Upwork.

    @situchan can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~01ef31182c5942b1de

  13. mallenexpensify commented on Nov 3, 2023

    @mallenexpensify
    ContributorAuthor

    Updated the above to reflect

    Issue reporter: @situchan paid $100 via Upwork.

    Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions