Skip to content

[$500] The main composer in the request report page is focused when closing the three dot menu #30178

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.88.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697902847726839

Action Performed:

  1. Go to a request report page
  2. Blur the main composer.
  3. Tap the three dots icon.
  4. Tap outside the menu to exit. Notice that the main composer is focused.

Expected Result:

The main composer in the request report page is unfocused

Actual Result:

The main composer in the request report page is focused

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
XRecorder_20102023_185845.mp4
iOS: Native
iOS: mWeb Safari
T164iossafari.Focus-1.mp4
MacOS: Chrome / Safari
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016b32eafb37ff001e
  • Upwork Job ID: 1716452642189750272
  • Last Price Increase: 2023-10-30

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 23, 2023
  2. changed the title [-]The main composer in the request report page is focused when closing the three dot menu[/-] [+][$500] The main composer in the request report page is focused when closing the three dot menu[/+] on Oct 23, 2023
  3. melvin-bot commented on Oct 23, 2023

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Oct 23, 2023

    @melvin-bot
  5. melvin-bot commented on Oct 23, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 23, 2023
  7. melvin-bot commented on Oct 23, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

  8. ishpaul777 commented on Oct 23, 2023

    @ishpaul777
    Contributor

    Problem

    The main composer in the request report page is focused when closing the three dot menu in request details while not in report details

    Root Cause

    Based on Modal(popover visibility) we refocus the composer but in MoneyReport Header we are setting the modal visibility key. (default true unless marked false explictly https://github.com/Expensify/App/blob/1a7a5dc80c84c5ef9ad3c0dd003369d7b011eaed/src/components/ThreeDotsMenu/index.js)

    ref - https://github.com/Expensify/App/blob/main/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js#L480-L497

    But in HeaderView we are not setting the modal visibility so the composer do not refocus.

    Changes

    We should introduce a new prop for HeaderWithBackButton, like shouldSetModalVisibilityForThreeDotsMenu (true by default) and pass false in MoneyReportHeader

    // src/components/MoneyReportHeader.js
    
               <HeaderWithBackButton
                   // rest of props
                    shouldSetModalVisibilityForThreeDotMenu={false}
                >
    // src/components/HeaderWithBackButton/index.js
                          <ThreeDotsMenu
                                menuItems={threeDotsMenuItems}
                                onIconPress={onThreeDotsButtonPress}
                                anchorPosition={threeDotsAnchorPosition}
                                shouldOverlay={shouldOverlay}
                                shouldSetModalVisibility={shouldSetModalVisibilityForThreeDotMenu}
                            />
  9. ntdiary commented on Oct 25, 2023

    @ntdiary
    Contributor

    To be honest, I don't think continuing to patch the existing refocus logic is a promising approach.

    We are doing the upgrade to RNW 0.19, after which I will try to improve the POC in issue #24452 and clean up these related codes. So I think we just need to track this case under issue #15992 for now.

    cc @kbecciv, @abekkala

  10. melvin-bot commented on Oct 30, 2023

    @melvin-bot

    @ntdiary, @abekkala Eep! 4 days overdue now. Issues have feelings too...

  11. 25 remaining items

  12. added and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 1, 2023
  13. abekkala commented on Dec 1, 2023

    @abekkala
    Contributor

    still on hold

  14. abekkala commented on Jan 3, 2024

    @abekkala
    Contributor

    still on hold

  15. abekkala commented on Feb 6, 2024

    @abekkala
    Contributor

    @kbecciv can you recreate this and provide an updated video?

  16. changed the title [-][HOLD 15992] [$500] The main composer in the request report page is focused when closing the three dot menu[/-] [+][$500] The main composer in the request report page is focused when closing the three dot menu[/+] on Feb 6, 2024
  17. kbecciv commented on Feb 7, 2024

    @kbecciv
    Author

    Not reproduced on build 1.4.38.0

    Screen_Recording_20240207_144059_Chrome.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.MonthlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions