You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] The main composer in the request report page is focused when closing the three dot menu #30178
changed the title [-]The main composer in the request report page is focused when closing the three dot menu[/-][+][$500] The main composer in the request report page is focused when closing the three dot menu[/+]on Oct 23, 2023
But in HeaderView we are not setting the modal visibility so the composer do not refocus.
Changes
We should introduce a new prop for HeaderWithBackButton, like shouldSetModalVisibilityForThreeDotsMenu (true by default) and pass false in MoneyReportHeader
// src/components/MoneyReportHeader.js<HeaderWithBackButton// rest of propsshouldSetModalVisibilityForThreeDotMenu={false}>
To be honest, I don't think continuing to patch the existing refocus logic is a promising approach.
We are doing the upgrade to RNW 0.19, after which I will try to improve the POC in issue #24452 and clean up these related codes. So I think we just need to track this case under issue #15992 for now.
changed the title [-][HOLD 15992] [$500] The main composer in the request report page is focused when closing the three dot menu[/-][+][$500] The main composer in the request report page is focused when closing the three dot menu[/+]on Feb 6, 2024
Activity
[-]The main composer in the request report page is focused when closing the three dot menu[/-][+][$500] The main composer in the request report page is focused when closing the three dot menu[/+]melvin-bot commentedon Oct 23, 2023
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 23, 2023
Job added to Upwork: https://www.upwork.com/jobs/~016b32eafb37ff001e
melvin-bot commentedon Oct 23, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Oct 23, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (
External)ishpaul777 commentedon Oct 23, 2023
Problem
The main composer in the request report page is focused when closing the three dot menu in request details while not in report details
Root Cause
Based on Modal(popover visibility) we refocus the composer but in MoneyReport Header we are setting the modal visibility key. (default true unless marked false explictly https://github.com/Expensify/App/blob/1a7a5dc80c84c5ef9ad3c0dd003369d7b011eaed/src/components/ThreeDotsMenu/index.js)
ref - https://github.com/Expensify/App/blob/main/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js#L480-L497
But in HeaderView we are not setting the modal visibility so the composer do not refocus.
Changes
We should introduce a new prop for
HeaderWithBackButton, likeshouldSetModalVisibilityForThreeDotsMenu(true by default) and pass false in MoneyReportHeaderntdiary commentedon Oct 25, 2023
To be honest, I don't think continuing to patch the existing refocus logic is a promising approach.
We are doing the upgrade to RNW 0.19, after which I will try to improve the POC in issue #24452 and clean up these related codes. So I think we just need to track this case under issue #15992 for now.
cc @kbecciv, @abekkala
melvin-bot commentedon Oct 30, 2023
@ntdiary, @abekkala Eep! 4 days overdue now. Issues have feelings too...
25 remaining items
abekkala commentedon Dec 1, 2023
still on hold
abekkala commentedon Jan 3, 2024
still on hold
abekkala commentedon Feb 6, 2024
@kbecciv can you recreate this and provide an updated video?
[-][HOLD 15992] [$500] The main composer in the request report page is focused when closing the three dot menu[/-][+][$500] The main composer in the request report page is focused when closing the three dot menu[/+]kbecciv commentedon Feb 7, 2024
Not reproduced on build 1.4.38.0
Screen_Recording_20240207_144059_Chrome.mp4