You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Distance-App crashes tapping on download receipt in android& on tapping receipt in mweb&web #30489
changed the title [-]Distance-App crashes tapping on download receipt in android& on tapping receipt in mweb&web[/-][+][$500] Distance-App crashes tapping on download receipt in android& on tapping receipt in mweb&web[/+]on Oct 27, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
updatePage is an useCallback it will re-create when its dependencies changed and it's not supported with onViewableItemsChanged. We should revert it to useRef.
Activity
[-]Distance-App crashes tapping on download receipt in android& on tapping receipt in mweb&web[/-][+][$500] Distance-App crashes tapping on download receipt in android& on tapping receipt in mweb&web[/+]melvin-bot commentedon Oct 27, 2023
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 27, 2023
Job added to Upwork: https://www.upwork.com/jobs/~013fac84786d952629
melvin-bot commentedon Oct 27, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Oct 27, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (
External)OSBotify commentedon Oct 27, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Oct 27, 2023
Triggered auto assignment to @MariaHCD (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.izarutskaya commentedon Oct 27, 2023
Not reproduced in production
Rpreplay.Final1698402342.mp4
hungvu193 commentedon Oct 27, 2023
Seem regression from this PR:
#29643
App/src/components/Attachments/AttachmentCarousel/index.js
Line 210 in eef8347
updatePageis an useCallback it will re-create when its dependencies changed and it's not supported withonViewableItemsChanged. We should revert it to useRef.situchan commentedon Oct 27, 2023
being fixed in #30481
melvin-bot commentedon Oct 27, 2023
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
MariaHCD commentedon Oct 27, 2023
Thanks, @situchan! Going to close this one in favor of #30490 since this is happening for all attachments not just for distance requests.