You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[ECard Settings] 🐛 Fraud is missing RBR on Settings Page + Update Banner UI #30677
Activity
tienifr commentedon Nov 1, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Fraud is missing RBR leading to card page
What is the root cause of that problem?
We always show the brickRoadIndicator = "error" in
App/src/pages/settings/Wallet/ExpensifyCardPage.js
Line 147 in 4f1fd91
What changes do you think we should make in order to solve the problem?
We should use hasDetectedDomainFraud (or hasDetectedIndividualFraud) to set the brickRoadIndicator =
errorResult
grgia commentedon Nov 1, 2023
@pasyukevich could you please take a look into this one as a follow up to your PR?
pasyukevich commentedon Nov 2, 2023
@grgia Could you share test data with which I can reproduce this?
melvin-bot commentedon Nov 6, 2023
@grgia Eep! 4 days overdue now. Issues have feelings too...
grgia commentedon Nov 6, 2023
@pasyukevich yep, here's example data - could you test with this cardList?
pasyukevich commentedon Nov 7, 2023
I'm looking at it. Tomorrow I will post an update
pasyukevich commentedon Nov 8, 2023
@grgia Could you describe expected behavior?
According to the doc:
From the point that I understand, we need to show a banner in this case, since one of the cards has individual fraud
melvin-bot commentedon Nov 13, 2023
@pasyukevich, @grgia Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Nov 13, 2023
@pasyukevich, @grgia Huh... This is 4 days overdue. Who can take care of this?
22 remaining items
eVoloshchak commentedon Jan 14, 2024
eVoloshchak commentedon Jan 26, 2024
@grgia, could you post a payment summary please?
melvin-bot commentedon Jan 26, 2024
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.grgia commentedon Jan 26, 2024
@CortneyOfstad would you mind helping out with $500 C+ review payment to @eVoloshchak for the review of #32106
CortneyOfstad commentedon Jan 31, 2024
Sorry for the delay here! So it shows that @eVoloshchak gets paid via NewDot, so sharing the payment summary below!
CortneyOfstad commentedon Jan 31, 2024
Payment Summary
@eVoloshchak (reviewer) — to be paid $500 via NewDot
JmillsExpensify commentedon Feb 3, 2024
$500 approved for @eVoloshchak based on summary above.
melvin-bot commentedon Feb 8, 2024
@CortneyOfstad, @pasyukevich, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
grgia commentedon Feb 8, 2024
Closing as completed