Skip to content

[ECard Settings] 🐛 Fraud is missing RBR on Settings Page + Update Banner UI #30677

Closed

Description

@grgia

Goals

1) Update Fraud UI

Before / After

Larger Version of Individual/Domain Fraud UI

figma

2) Add Red Brick Road Indicator to Settings Page as Well

image

Original Report

Coming from https://expensify.slack.com/archives/C03U7DCU4/p1698775268026679

Image

  • There's no RBR leading to it, just that red dot there

Activity

  1. self-assigned this
    on Nov 1, 2023
  2. tienifr commented on Nov 1, 2023

    @tienifr
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Fraud is missing RBR leading to card page

    What is the root cause of that problem?

    We always show the brickRoadIndicator = "error" in

    brickRoadIndicator="error"

    What changes do you think we should make in order to solve the problem?

    We should use hasDetectedDomainFraud (or hasDetectedIndividualFraud) to set the brickRoadIndicator = error

    brickRoadIndicator={hasDetectedDomainFraud && "error"}
    

    Result

  3. grgia commented on Nov 1, 2023

    @grgia
    ContributorAuthor

    @pasyukevich could you please take a look into this one as a follow up to your PR?

  4. pasyukevich commented on Nov 2, 2023

    @pasyukevich
    Contributor

    @grgia Could you share test data with which I can reproduce this?

  5. melvin-bot commented on Nov 6, 2023

    @melvin-bot

    @grgia Eep! 4 days overdue now. Issues have feelings too...

  6. grgia commented on Nov 6, 2023

    @grgia
    ContributorAuthor

    @pasyukevich yep, here's example data - could you test with this cardList?

    {
      "1": {
        "availableSpend": 1000000,
        "bank": "Expensify Card",
        "cardID": 1,
        "cardholderFirstName": "FirstName",
        "cardholderLastName": "LastName",
        "domainName": "expensify.com",
        "fraud": "individual",
        "isVirtual": false,
        "lastFourPAN": "1234",
        "state": 3
      },
      "2": {
        "availableSpend": 1000000,
        "bank": "Expensify Card",
        "cardID": 2,
        "cardholderFirstName": "FirstName",
        "cardholderLastName": "LastName",
        "domainName": "expensify.com",
        "fraud": "none",
        "isVirtual": true,
        "lastFourPAN": "9876",
        "state": 3
      }
    }
    
  7. pasyukevich commented on Nov 7, 2023

    @pasyukevich
    Contributor

    I'm looking at it. Tomorrow I will post an update

  8. pasyukevich commented on Nov 8, 2023

    @pasyukevich
    Contributor

    @grgia Could you describe expected behavior?

    According to the doc:

    For each card with detectedIndividualFraud, we will display a suspicious transaction banner and “Review transaction”

    From the point that I understand, we need to show a banner in this case, since one of the cards has individual fraud

  9. melvin-bot commented on Nov 13, 2023

    @melvin-bot

    @pasyukevich, @grgia Eep! 4 days overdue now. Issues have feelings too...

  10. melvin-bot commented on Nov 13, 2023

    @melvin-bot

    @pasyukevich, @grgia Huh... This is 4 days overdue. Who can take care of this?

  11. 22 remaining items

  12. eVoloshchak commented on Jan 14, 2024

    @eVoloshchak
  13. eVoloshchak commented on Jan 26, 2024

    @eVoloshchak
    Contributor

    @grgia, could you post a payment summary please?

  14. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 26, 2024
  15. melvin-bot commented on Jan 26, 2024

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  16. grgia commented on Jan 26, 2024

    @grgia
    ContributorAuthor

    @CortneyOfstad would you mind helping out with $500 C+ review payment to @eVoloshchak for the review of #32106

  17. CortneyOfstad commented on Jan 31, 2024

    @CortneyOfstad
    Contributor

    Sorry for the delay here! So it shows that @eVoloshchak gets paid via NewDot, so sharing the payment summary below!

  18. CortneyOfstad commented on Jan 31, 2024

    @CortneyOfstad
    Contributor

    Payment Summary

    @eVoloshchak (reviewer) — to be paid $500 via NewDot

  19. JmillsExpensify commented on Feb 3, 2024

    @JmillsExpensify
    Contributor

    $500 approved for @eVoloshchak based on summary above.

  20. melvin-bot commented on Feb 8, 2024

    @melvin-bot

    @CortneyOfstad, @pasyukevich, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  21. grgia commented on Feb 8, 2024

    @grgia
    ContributorAuthor

    Closing as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions