You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-11-17] [$500] [Wave 6: Tags] Billable and Tag category are not spaced enough like other sections #30821
Version Number: 1.3.95-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause-Internal Team Slack conversation: @
Action Performed:
Pre-condition: In employee account, must have enabled category, tag and billable option
Tap on scan request created to open scan request details page
Tap on amount, description, merchant, date, category, tag (while tapping on each section, note the gap between the selected and next section)
Expected Result:
There should be enough spacing between Tags (custom name-shahrukh khan) and Billable section.
Actual Result:
While tapping on tag(custom name-shahrukh khan) section, there is no enough spacing between selected Tag(shahrukh khan) and Billable section. The selected tag section and Billable toggle box appears too close. There is no enough spacing like other sections.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]IOU-Billable and Tag category are not spaced enough like other sections[/-][+][$500] IOU-Billable and Tag category are not spaced enough like other sections[/+]on Nov 3, 2023
changed the title [-][$500] [Wave 6: Tags] Billable and Tag category are not spaced enough like other sections[/-][+][HOLD for payment 2023-11-17] [$500] [Wave 6: Tags] Billable and Tag category are not spaced enough like other sections[/+]on Nov 10, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.97-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-17. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@parasharrajatdoes not require payment (Eligible for Manual Requests)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@parasharrajat] Determine if we should create a regression test for this bug.
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required
[@parasharrajat] Determine if we should create a regression test for this bug. No. This is just a style change.
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
[-]IOU-Billable and Tag category are not spaced enough like other sections[/-][+][$500] IOU-Billable and Tag category are not spaced enough like other sections[/+]melvin-bot commentedon Nov 3, 2023
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Nov 3, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01ed40e13d720ed9c6
melvin-bot commentedon Nov 3, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Nov 3, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (
External)DrLoopFall commentedon Nov 3, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
IOU-Billable and Tag category are not spaced enough like other sections
What is the root cause of that problem?
Currently there is no padding/margin on top
App/src/components/ReportActionItem/MoneyRequestView.js
Line 277 in 4322ad9
What changes do you think we should make in order to solve the problem?
Adding
styles.mt4or replacestyles.mb4withstyles.mv4to the styles here would fix the issue.tienifr commentedon Nov 3, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
IOU-Billable and Tag category are not spaced enough like other sections
What is the root cause of that problem?
We did not add paddingTop/ marginTop for this component
App/src/components/ReportActionItem/MoneyRequestView.js
Line 277 in 4322ad9
What changes do you think we should make in order to solve the problem?
Solution 1: In order to be consistency with
MoneyRequestConfirmationList, we should removestyles.mb4and addstyles.optionRowhereSolution2: Remove
styles.mb4and addstyles.pv4in hereWhat alternative solutions did you explore? (Optional)
We can create the common component for billable switch and use it in
MoneyRequestConfirmationListandMoneyRequestViewparasharrajat commentedon Nov 3, 2023
@tienifr's solution 1 looks more aligned with what we have currently.
But I am not rejecting the first proposal from @DrLoopFall as the difference is only an implementation detail so they are equally eligible.
I leave the final decision to the Engineer.
🎀 👀 🎀 C+ reviewed
21 remaining items
[-][$500] [Wave 6: Tags] Billable and Tag category are not spaced enough like other sections[/-][+][HOLD for payment 2023-11-17] [$500] [Wave 6: Tags] Billable and Tag category are not spaced enough like other sections[/+]melvin-bot commentedon Nov 10, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 10, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.97-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Billableswitch does not have top padding #30970If no regressions arise, payment will be issued on 2023-11-17. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 10, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
parasharrajat commentedon Nov 10, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
bfitzexpensify commentedon Nov 22, 2023
Payment summary:
Contributor: @tienifr to be paid $500 via Upwork - ✅
C+: @parasharrajat to be paid $500 via manual request
BZ checklist complete, so we're all done here. Closing this one out.
parasharrajat commentedon Dec 5, 2023
Payment requested as per #30821 (comment)
JmillsExpensify commentedon Dec 11, 2023
$500 payment approved for @parasharrajat based on comment above.