Skip to content

[HOLD for payment 2023-11-17] [$500] [Wave 6: Tags] Billable and Tag category are not spaced enough like other sections #30821

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.95-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

Pre-condition: In employee account, must have enabled category, tag and billable option

  1. Go to https://staging.new.expensify.com/
  2. Tap on Employee Workspace
  3. Tap plus icon and select request money
  4. Tap Scan
  5. Upload an image
  6. Tap request
  7. Tap on scan request created to open scan request details page
  8. Tap on amount, description, merchant, date, category, tag (while tapping on each section, note the gap between the selected and next section)

Expected Result:

There should be enough spacing between Tags (custom name-shahrukh khan) and Billable section.

Actual Result:

While tapping on tag(custom name-shahrukh khan) section, there is no enough spacing between selected Tag(shahrukh khan) and Billable section. The selected tag section and Billable toggle box appears too close. There is no enough spacing like other sections.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6261802_1698991304382.raisespace.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ed40e13d720ed9c6
  • Upwork Job ID: 1720351887160328192
  • Last Price Increase: 2023-11-03
  • Automatic offers:
    • tienifr | Contributor | 27544000

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 3, 2023
  2. changed the title [-]IOU-Billable and Tag category are not spaced enough like other sections[/-] [+][$500] IOU-Billable and Tag category are not spaced enough like other sections[/+] on Nov 3, 2023
  3. melvin-bot commented on Nov 3, 2023

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Nov 3, 2023

    @melvin-bot
  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 3, 2023
  6. melvin-bot commented on Nov 3, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot commented on Nov 3, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

  8. DrLoopFall commented on Nov 3, 2023

    @DrLoopFall
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    IOU-Billable and Tag category are not spaced enough like other sections

    What is the root cause of that problem?

    Currently there is no padding/margin on top

    <View style={[styles.flexRow, styles.mb4, styles.justifyContentBetween, styles.alignItemsCenter, styles.ml5, styles.mr8]}>

    What changes do you think we should make in order to solve the problem?

    Adding styles.mt4 or replace styles.mb4 with styles.mv4 to the styles here would fix the issue.

    <View style={[styles.flexRow, styles.mv4, styles.justifyContentBetween, styles.alignItemsCenter, styles.ml5, styles.mr8]}>
  9. tienifr commented on Nov 3, 2023

    @tienifr
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    IOU-Billable and Tag category are not spaced enough like other sections

    What is the root cause of that problem?

    We did not add paddingTop/ marginTop for this component

    <View style={[styles.flexRow, styles.mb4, styles.justifyContentBetween, styles.alignItemsCenter, styles.ml5, styles.mr8]}>

    What changes do you think we should make in order to solve the problem?

    Solution 1: In order to be consistency with MoneyRequestConfirmationList, we should remove styles.mb4 and add styles.optionRow here

    Solution2: Remove styles.mb4 and add styles.pv4 in here

    What alternative solutions did you explore? (Optional)

    We can create the common component for billable switch and use it in MoneyRequestConfirmationList and MoneyRequestView

  10. parasharrajat commented on Nov 3, 2023

    @parasharrajat
    Member

    @tienifr's solution 1 looks more aligned with what we have currently.

    But I am not rejecting the first proposal from @DrLoopFall as the difference is only an implementation detail so they are equally eligible.

    I leave the final decision to the Engineer.

    🎀 👀 🎀 C+ reviewed

  11. 21 remaining items

  12. changed the title [-][$500] [Wave 6: Tags] Billable and Tag category are not spaced enough like other sections[/-] [+][HOLD for payment 2023-11-17] [$500] [Wave 6: Tags] Billable and Tag category are not spaced enough like other sections[/+] on Nov 10, 2023
  13. melvin-bot commented on Nov 10, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Nov 10, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.97-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-11-17. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Nov 10, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
    • [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@parasharrajat] Determine if we should create a regression test for this bug.
    • [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. parasharrajat commented on Nov 10, 2023

    @parasharrajat
    Member

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  17. bfitzexpensify commented on Nov 22, 2023

    @bfitzexpensify
    Contributor

    Payment summary:

    Contributor: @tienifr to be paid $500 via Upwork - ✅
    C+: @parasharrajat to be paid $500 via manual request

    BZ checklist complete, so we're all done here. Closing this one out.

  18. parasharrajat commented on Dec 5, 2023

    @parasharrajat
    Member

    Payment requested as per #30821 (comment)

  19. JmillsExpensify commented on Dec 11, 2023

    @JmillsExpensify
    Contributor

    $500 payment approved for @parasharrajat based on comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions