You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-11-29] [$500] Personal details - App crashed when tap on Home address page #30949
Version Number: 1.3.96.0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Launch App
Tap on Settings > Profile > Personal details
Tap on address
Expected Result:
Address page should be open.
Actual Result:
App crashed when tapping on Home address page.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$500] Personal details - App crashed when tap on Home address page[/-][+][HOLD for payment 2023-11-29] [$500] Personal details - App crashed when tap on Home address page[/+]on Nov 29, 2023
Activity
OSBotify commentedon Nov 7, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Nov 7, 2023
Triggered auto assignment to @thienlnam (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.thienlnam commentedon Nov 7, 2023
Found the PR that caused the regression: #29742
#29742 (comment)
GItGudRatio commentedon Nov 7, 2023
I'm available to fix this issue immediately
cc @thienlnam
Proposal
Please re-state the problem that we are trying to solve in this issue.
App crashes when tapping on Home address page
What is the root cause of that problem?
The root cause lies in this line:
App/src/pages/settings/Profile/PersonalDetails/AddressPage.js
Line 215 in 040c8a7
Since this does not have the parameters,
undefinedis used when trying to destructure parameters, causing the fatal crash.What changes do you think we should make in order to solve the problem?
TO fix this, we can change the line to
accessibilityLabel={translate('common.addressLine', {lineNumber: 2})}What alternative solutions did you explore? (Optional)
remove
accessibilityLabelthienlnam commentedon Nov 7, 2023
Sounds great - looks like that fixes it. Will assign ya
GItGudRatio commentedon Nov 7, 2023
PR is up, please help review @thienlnam! Could you also please add the
Externaltag so Melv can assign a C+?situchan commentedon Nov 7, 2023
Maybe @getusha can take this as C+ as it came from PR he reviewed.
22 remaining items
dylanexpensify commentedon Nov 22, 2023
Nice! Paying today! @GItGudRatio did you apply in Upwork?
GItGudRatio commentedon Nov 22, 2023
@dylanexpensify Hi, yes, have already accepted the offer.
melvin-bot commentedon Nov 29, 2023
@thienlnam, @GItGudRatio, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Nov 29, 2023
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Nov 29, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)[-][$500] Personal details - App crashed when tap on Home address page[/-][+][HOLD for payment 2023-11-29] [$500] Personal details - App crashed when tap on Home address page[/+]alexpensify commentedon Nov 29, 2023
Here is the payment summary:
Upwork Job: https://www.upwork.com/jobs/~010ad9a28a992c9851
*If applicable, the bonuses will be applied on the final payment
Extra Notes regarding payment: I'm going off the summary shared here #30949 (comment)
alexpensify commentedon Nov 29, 2023
Done @GItGudRatio has been paid via Upwork and I closed the job. I'm going to close this GH now.