Skip to content

[HOLD for payment 2023-11-29] [$500] Personal details - App crashed when tap on Home address page #30949

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.96.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Launch App
  2. Tap on Settings > Profile > Personal details
  3. Tap on address

Expected Result:

Address page should be open.

Actual Result:

App crashed when tapping on Home address page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6266745_1699322553840.RPReplay_Final1699320482.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010ad9a28a992c9851
  • Upwork Job ID: 1721813829199605760
  • Last Price Increase: 2023-11-07
  • Automatic offers:
    • GItGudRatio | Contributor | 27554474
Issue OwnerCurrent Issue Owner: @alexpensify

Activity

  1. OSBotify commented on Nov 7, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Nov 7, 2023

    @melvin-bot

    Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. thienlnam commented on Nov 7, 2023

    @thienlnam
    Contributor

    Found the PR that caused the regression: #29742

    #29742 (comment)

  4. GItGudRatio commented on Nov 7, 2023

    @GItGudRatio
    Contributor

    I'm available to fix this issue immediately
    cc @thienlnam

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    App crashes when tapping on Home address page

    What is the root cause of that problem?

    The root cause lies in this line:

    accessibilityLabel={translate('common.addressLine')}

    Since this does not have the parameters, undefined is used when trying to destructure parameters, causing the fatal crash.

    What changes do you think we should make in order to solve the problem?

    TO fix this, we can change the line to accessibilityLabel={translate('common.addressLine', {lineNumber: 2})}

    What alternative solutions did you explore? (Optional)

    remove accessibilityLabel

  5. thienlnam commented on Nov 7, 2023

    @thienlnam
    Contributor

    Sounds great - looks like that fixes it. Will assign ya

  6. GItGudRatio commented on Nov 7, 2023

    @GItGudRatio
    Contributor

    PR is up, please help review @thienlnam! Could you also please add the External tag so Melv can assign a C+?

  7. situchan commented on Nov 7, 2023

    @situchan
    Contributor

    Maybe @getusha can take this as C+ as it came from PR he reviewed.

  8. 22 remaining items

  9. dylanexpensify commented on Nov 22, 2023

    @dylanexpensify
    Contributor

    Nice! Paying today! @GItGudRatio did you apply in Upwork?

  10. GItGudRatio commented on Nov 22, 2023

    @GItGudRatio
    Contributor

    @dylanexpensify Hi, yes, have already accepted the offer.

  11. melvin-bot commented on Nov 29, 2023

    @melvin-bot

    @thienlnam, @GItGudRatio, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  12. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 29, 2023
  13. melvin-bot commented on Nov 29, 2023

    @melvin-bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  14. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on Nov 29, 2023
  15. melvin-bot commented on Nov 29, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  16. changed the title [-][$500] Personal details - App crashed when tap on Home address page[/-] [+][HOLD for payment 2023-11-29] [$500] Personal details - App crashed when tap on Home address page[/+] on Nov 29, 2023
  17. alexpensify commented on Nov 29, 2023

    @alexpensify
    Contributor

    Here is the payment summary:

    • External issue reporter - N/A
    • Contributor that fixed the issue - @GItGudRatio $500
    • Contributor+ that helped on the issue and/or PR - N/A

    Upwork Job: https://www.upwork.com/jobs/~010ad9a28a992c9851

    *If applicable, the bonuses will be applied on the final payment

    Extra Notes regarding payment: I'm going off the summary shared here #30949 (comment)

  18. alexpensify commented on Nov 29, 2023

    @alexpensify
    Contributor

    Done @GItGudRatio has been paid via Upwork and I closed the job. I'm going to close this GH now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions