Skip to content

[$500] Android - Chat - Keyboard does not pull up when editing the message #30991

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Found when executing PR : #30669

Version Number: v1.3.96-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

  1. Go to staging.new.expensify.com
  2. Open any chat.
  3. Send a message.
  4. Long press on the message.
  5. Tap Edit message.

Expected Result:

The keyboard will pull up.

Actual Result:

The edit composer is focused but the keyboard does not pull up.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6267190_1699355804164.Screen_Recording_20231107_121932_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011928df9e6f1e55ee
  • Upwork Job ID: 1721869358457446400
  • Last Price Increase: 2023-11-07
Issue OwnerCurrent Issue Owner: @mananjadhav

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 7, 2023
  2. changed the title [-]Android - Chat - Keyboard does not pull up when editing the message[/-] [+][$500] Android - Chat - Keyboard does not pull up when editing the message[/+] on Nov 7, 2023
  3. melvin-bot commented on Nov 7, 2023

    @melvin-bot
  4. melvin-bot commented on Nov 7, 2023

    @melvin-bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. melvin-bot commented on Nov 7, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 7, 2023
  7. melvin-bot commented on Nov 7, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

  8. izarutskaya commented on Nov 7, 2023

    @izarutskaya
    Author

    Not reproducible in production

    Screen_Recording_20231107_112754_New.Expensify.mp4
  9. 7 remaining items

  10. cristipaval commented on Nov 7, 2023

    @cristipaval
    Contributor

    Alright, thanks @dukenv0307!

    Given that the keyboard shows up if the user explicitly taps on the input field, I'll consider this a minor issue that shouldn't block the deployment. I just removed DeployBlockerCash label.

  11. cristipaval commented on Nov 7, 2023

    @cristipaval
    Contributor

    @mananjadhav could you please check if the proposed solution works?

  12. melvin-bot commented on Nov 10, 2023

    @melvin-bot

    @mananjadhav, @alexpensify, @cristipaval Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  13. mananjadhav commented on Nov 10, 2023

    @mananjadhav
    Collaborator

    I think @dukenv0307's proposal will work. Will have to make sure scrollTop shouldn't impact the composer.

    🎀 👀 🎀 C+ reviewed.

  14. melvin-bot commented on Nov 10, 2023

    @melvin-bot

    Current assignee @cristipaval is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

  15. aimane-chnaif commented on Nov 10, 2023

    @aimane-chnaif
    Contributor

    This was deploy blocker. What's offending PR?

  16. tsa321 commented on Nov 12, 2023

    @tsa321
    Contributor

    The follow up PR #31041 is already merged to fix the keyboard issue in android...

  17. cristipaval commented on Nov 13, 2023

    @cristipaval
    Contributor

    The follow up PR #31041 is already merged to fix the keyboard issue in android...

    Thanks @tsa321 , I'll close the issue then.

  18. alexpensify commented on Nov 15, 2023

    @alexpensify
    Contributor

    Thanks for your help @cristipaval!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions