You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-11-17] [$500] Chat - Pressing Tab closes emoji picker on Desktop or moves focus to the composer on Web #31098
Version Number: 1.3.97-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause-Internal Team Slack conversation: @
Action Performed:
Go to staging.new.expensify.com or open Desktop App
Login with any account
Go to any chat
Open emoji picker
Press 'Tab' key
Expected Result:
Focus moves to the next item -> from 'Search' field to ‘Frequently Used’ icon
Actual Result:
Pressing Tab closes emoji picker on Desktop or moves focus to the composer on Web (Safari)
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Chat - Pressing Tab closes emoji picker on Desktop or moves focus to the composer on Web[/-][+][$500] Chat - Pressing Tab closes emoji picker on Desktop or moves focus to the composer on Web[/+]on Nov 9, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mountiny] The PR that introduced the bug has been identified. Link to the PR:
[@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@tienifr] Determine if we should create a regression test for this bug.
[@tienifr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2023-11-17] [$500] Chat - Pressing Tab closes emoji picker on Desktop or moves focus to the composer on Web[/-][+][HOLD for payment 2023-11-21] [HOLD for payment 2023-11-17] [$500] Chat - Pressing Tab closes emoji picker on Desktop or moves focus to the composer on Web[/+]on Nov 14, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.98-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-21. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mountiny] The PR that introduced the bug has been identified. Link to the PR:
[@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@tienifr] Determine if we should create a regression test for this bug.
[@tienifr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2023-11-21] [HOLD for payment 2023-11-17] [$500] Chat - Pressing Tab closes emoji picker on Desktop or moves focus to the composer on Web[/-][+][HOLD for payment 2023-11-17] [$500] Chat - Pressing Tab closes emoji picker on Desktop or moves focus to the composer on Web[/+]on Nov 15, 2023
The offending PR was identified as the RNW upgrade f4f44ae, it changed someexpected behavioru, it was auge lift and big upgrade which had lots of small regressions we are aware of. No need to start discussion.
No regression test required imho, its an edge case.
Activity
[-]Chat - Pressing Tab closes emoji picker on Desktop or moves focus to the composer on Web[/-][+][$500] Chat - Pressing Tab closes emoji picker on Desktop or moves focus to the composer on Web[/+]melvin-bot commentedon Nov 9, 2023
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Nov 9, 2023
Job added to Upwork: https://www.upwork.com/jobs/~016146f3b3888a9471
melvin-bot commentedon Nov 9, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Nov 9, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (
External)30 remaining items
melvin-bot commentedon Nov 10, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2023-11-17] [$500] Chat - Pressing Tab closes emoji picker on Desktop or moves focus to the composer on Web[/-][+][HOLD for payment 2023-11-21] [HOLD for payment 2023-11-17] [$500] Chat - Pressing Tab closes emoji picker on Desktop or moves focus to the composer on Web[/+]melvin-bot commentedon Nov 14, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.98-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Tabkey #31118If no regressions arise, payment will be issued on 2023-11-21. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 14, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mountiny commentedon Nov 15, 2023
@tienifr Can you please handle the checklist?
[-][HOLD for payment 2023-11-21] [HOLD for payment 2023-11-17] [$500] Chat - Pressing Tab closes emoji picker on Desktop or moves focus to the composer on Web[/-][+][HOLD for payment 2023-11-17] [$500] Chat - Pressing Tab closes emoji picker on Desktop or moves focus to the composer on Web[/+]tienifr commentedon Nov 15, 2023
@mountiny I'm not a C+, the PR was reviewed and approved by you.
mountiny commentedon Nov 15, 2023
The offending PR was identified as the RNW upgrade f4f44ae, it changed someexpected behavioru, it was auge lift and big upgrade which had lots of small regressions we are aware of. No need to start discussion.
No regression test required imho, its an edge case.
@isabelastisser should bre ready to be paid
situchan commentedon Nov 17, 2023
There are some flags that the PR caused these regressions: #31203, #31488
isabelastisser commentedon Nov 27, 2023
@tienifr, I just made the payment in Upwork. All set!