You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-11-30] [$500] Room - Inconsistency in room member list when it is created offline and after returning online #31375
Version Number: 1.3.99-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Precondition: Have a workspace with a few members
Go offline
Click + > New chat > Room
Create a room under the workspace in the precondition and set the visibility to Workspace
Click on the room header > Members
Go online
Expected Result:
Member list in the room when created offline should only show the admin themselves
Actual Result:
Member list in the room when created offline shows all the workspace members. It shows only the admin after returning online
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-] Room - Inconsistency in room member list when it is created offline and after returning online[/-][+][$500] Room - Inconsistency in room member list when it is created offline and after returning online[/+]on Nov 15, 2023
Please re-state the problem that we are trying to solve in this issue.
Inconsistency in the room member list when it is created offline and after returning online
What is the root cause of that problem?
When we create a room with visibility as restricted, we add participants in optimistic data is the member list of the workspace. After going online, BE returns the data with participants of this room as only current user.
What changes do you think we should make in order to solve the problem?
If the expected is only the current user is participant when we create a new room, we can fix in FE to update the participant of optimistic data as the current user.
So there are more updates on Slack and it seems that only user who created should be the member of the room when created. Other users will have to join it.
Activity
[-] Room - Inconsistency in room member list when it is created offline and after returning online[/-][+][$500] Room - Inconsistency in room member list when it is created offline and after returning online[/+]melvin-bot commentedon Nov 15, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0124f1a665a95a6c6e
melvin-bot commentedon Nov 15, 2023
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Nov 15, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Nov 15, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (
External)dukenv0307 commentedon Nov 15, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Inconsistency in the room member list when it is created offline and after returning online
What is the root cause of that problem?
When we create a room with visibility as restricted, we add participants in optimistic data is the member list of the workspace. After going online, BE returns the data with participants of this room as only current user.
App/src/libs/actions/Report.js
Line 1550 in 0151ae3
What changes do you think we should make in order to solve the problem?
App/src/libs/actions/Report.js
Line 1550 in 0151ae3
What alternative solutions did you explore? (Optional)
parasharrajat commentedon Nov 15, 2023
I am not also not sure here about who should be participants. Going to ask on Slack https://expensify.slack.com/archives/C01GTK53T8Q/p1700077413329419
parasharrajat commentedon Nov 16, 2023
parasharrajat commentedon Nov 16, 2023
So there are more updates on Slack and it seems that only user who created should be the member of the room when created. Other users will have to join it.
In that case, @dukenv0307's proposal to update the FE makes sense.
🎀 👀 🎀 C+ reviewed
27 remaining items
melvin-bot commentedon Nov 29, 2023
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.kadiealexander commentedon Nov 29, 2023
Thanks for sorting payment @bfitzexpensify, the BugZero Checklist is complete here.
bfitzexpensify commentedon Nov 30, 2023
Payout complete, BZ checklist is done so we're all wrapped up here. Thanks everyone!
parasharrajat commentedon Dec 5, 2023
Payment requested as per #31375 (comment)
JmillsExpensify commentedon Dec 11, 2023
$500 payment approved for @parasharrajat based on this comment.