Skip to content

[HOLD for payment 2023-11-30] [$500] Room - Inconsistency in room member list when it is created offline and after returning online #31375

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.99-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: Have a workspace with a few members

  1. Go offline
  2. Click + > New chat > Room
  3. Create a room under the workspace in the precondition and set the visibility to Workspace
  4. Click on the room header > Members
  5. Go online

Expected Result:

Member list in the room when created offline should only show the admin themselves

Actual Result:

Member list in the room when created offline shows all the workspace members. It shows only the admin after returning online

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6277612_1700057722582.20231115_135040.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0124f1a665a95a6c6e
  • Upwork Job ID: 1724807139956674560
  • Last Price Increase: 2023-11-15
  • Automatic offers:
    • dukenv0307 | Contributor | 27723102

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 15, 2023
  2. changed the title [-] Room - Inconsistency in room member list when it is created offline and after returning online[/-] [+][$500] Room - Inconsistency in room member list when it is created offline and after returning online[/+] on Nov 15, 2023
  3. melvin-bot commented on Nov 15, 2023

    @melvin-bot
  4. melvin-bot commented on Nov 15, 2023

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 15, 2023
  6. melvin-bot commented on Nov 15, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot commented on Nov 15, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

  8. dukenv0307 commented on Nov 15, 2023

    @dukenv0307
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Inconsistency in the room member list when it is created offline and after returning online

    What is the root cause of that problem?

    When we create a room with visibility as restricted, we add participants in optimistic data is the member list of the workspace. After going online, BE returns the data with participants of this room as only current user.

    const members = visibility === CONST.REPORT.VISIBILITY.RESTRICTED ? policyMembersAccountIDs : [];

    What changes do you think we should make in order to solve the problem?

    1. If the expected is only the current user is participant when we create a new room, we can fix in FE to update the participant of optimistic data as the current user.

    const members = visibility === CONST.REPORT.VISIBILITY.RESTRICTED ? policyMembersAccountIDs : [];

    1. If not we should fix in BE to return the correct participant.

    What alternative solutions did you explore? (Optional)

  9. parasharrajat commented on Nov 15, 2023

    @parasharrajat
    Member

    I am not also not sure here about who should be participants. Going to ask on Slack https://expensify.slack.com/archives/C01GTK53T8Q/p1700077413329419

  10. parasharrajat commented on Nov 16, 2023

    @parasharrajat
  11. parasharrajat commented on Nov 16, 2023

    @parasharrajat
    Member

    So there are more updates on Slack and it seems that only user who created should be the member of the room when created. Other users will have to join it.

    In that case, @dukenv0307's proposal to update the FE makes sense.

    🎀 👀 🎀 C+ reviewed

  12. 27 remaining items

  13. deleted a comment from melvin-bot on Nov 29, 2023
  14. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    Help WantedApply this label when an issue is open to proposals by contributors
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 29, 2023
  15. melvin-bot commented on Nov 29, 2023

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  16. deleted a comment from melvin-bot on Nov 29, 2023
  17. kadiealexander commented on Nov 29, 2023

    @kadiealexander
    Contributor

    Thanks for sorting payment @bfitzexpensify, the BugZero Checklist is complete here.

  18. bfitzexpensify commented on Nov 30, 2023

    @bfitzexpensify
    Contributor

    Payout complete, BZ checklist is done so we're all wrapped up here. Thanks everyone!

  19. parasharrajat commented on Dec 5, 2023

    @parasharrajat
    Member

    Payment requested as per #31375 (comment)

  20. JmillsExpensify commented on Dec 11, 2023

    @JmillsExpensify
    Contributor

    $500 payment approved for @parasharrajat based on this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions