Skip to content

[HOLD for payment 2023-12-04] Login - Background color of chat list is different from the header in LHN when it is loading #31581

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.1-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Launch New Expensify app
  2. Log in

Expected Result:

The background color of the chat list matches the background color of the header in LHN when it is loading

Actual Result:

The background color of the chat list is different from the header in LHN when it is loading

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6284412_1700510021128!Screenshot_2023-11-21_at_03 47 25
Bug6284412_1700510021129.Screen_Recording_20231121_030149_New_Expensify.mp4

View all open jobs on GitHub

Activity

  1. github-actions commented on Nov 20, 2023

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Nov 20, 2023

    @melvin-bot

    📣 @github-actions[bot]! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  3. melvin-bot commented on Nov 20, 2023

    @melvin-bot

    Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  4. luacmartins commented on Nov 20, 2023

    @luacmartins
    Contributor

    I can work on this

  5. luacmartins commented on Nov 21, 2023

    @luacmartins
    Contributor

    I'm gonna demote this to NAB since it's a very minor UI issue. We already have a fix up for it but I don't think it's worth CPing it.

  6. 7 remaining items

  7. melvin-bot commented on Nov 23, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  8. melvin-bot commented on Nov 23, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-11-30. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR
  9. melvin-bot commented on Nov 23, 2023

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  10. changed the title [-][HOLD for payment 2023-11-30] Login - Background color of chat list is different from the header in LHN when it is loading[/-] [+][HOLD for payment 2023-12-04] [HOLD for payment 2023-11-30] Login - Background color of chat list is different from the header in LHN when it is loading[/+] on Nov 27, 2023
  11. melvin-bot commented on Nov 27, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.3-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-12-04. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR
  12. changed the title [-][HOLD for payment 2023-12-04] [HOLD for payment 2023-11-30] Login - Background color of chat list is different from the header in LHN when it is loading[/-] [+][HOLD for payment 2023-12-04] Login - Background color of chat list is different from the header in LHN when it is loading[/+] on Dec 4, 2023
  13. luacmartins commented on Dec 4, 2023

    @luacmartins
    Contributor

    We reverted the offending PR so this is fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions