Skip to content

[HOLD for task cleanup] LOW: Update childVisibleActionCount of parent report action when canceling child thread #31630

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.1.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal team
Slack conversation:

Action Performed:

  1. Go to any Chat
  2. Send a Message
  3. Right-click on the Message you sent and click on the reply in thread
  4. Click on the plus button on the composer > Assign task
  5. Write a title and Click on Next
  6. Confirm task
  7. Go to the main chat and notice that the Reply number is shown.
  8. Go back to the tread
  9. Click on the task to go to the task report page
  10. Cancel the task
  11. Return to the thread and notice that the task is not shown. No reply is shown in the tread
  12. Go to the main chat and notice that the Reply number is still shown.

Expected Result:

The reply number is not shown when there is no reply in the thread

Actual Result:

Reply number is shown with no reply in the thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6285235_1700558198261.test2_ReplyNO.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013a799300c7807dc5
  • Upwork Job ID: 1726979634179018752
  • Last Price Increase: 2023-12-12

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 21, 2023
  2. changed the title [-]Chat - Reply number is shown for no replies on the thread[/-] [+][$500] Chat - Reply number is shown for no replies on the thread[/+] on Nov 21, 2023
  3. melvin-bot commented on Nov 21, 2023

    @melvin-bot
  4. melvin-bot commented on Nov 21, 2023

    @melvin-bot

    Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 21, 2023
  6. melvin-bot commented on Nov 21, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot commented on Nov 21, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

  8. DylanDylann commented on Nov 21, 2023

    @DylanDylann
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Chat - Reply number is shown for no replies on the thread

    What is the root cause of that problem?

    When canceling task in the child thread, we don't update childVisibleActionCount of parent report action

    What changes do you think we should make in order to solve the problem?

    BE FIx: We need to update childVisibleActionCount of parent report action in the reponse of OpenReport API

    What alternative solutions did you explore? (Optional)

  9. added
    InternalRequires API changes or must be handled by Expensify staff
    on Nov 21, 2023
  10. melvin-bot commented on Nov 21, 2023

    @melvin-bot

    Current assignee @c3024 is eligible for the Internal assigner, not assigning anyone new.

  11. 43 remaining items

  12. changed the title [-]LOW: Update `childVisibleActionCount` of parent report action when canceling child thread[/-] [+][HOLD for task cleanup] LOW: Update `childVisibleActionCount` of parent report action when canceling child thread[/+] on Jan 22, 2024
  13. moved this from LOW to FUTURE in [#whatsnext] #vip-vsbon Jan 22, 2024
  14. mvtglobally commented on Jan 30, 2024

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  15. strepanier03 commented on Feb 1, 2024

    @strepanier03
    Contributor

    We should have a BZ assigned to every bug issue in E/App so that we have some ownership. I'm going to reassign the BZ label.

  16. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 1, 2024
  17. melvin-bot commented on Feb 1, 2024

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  18. joekaufmanexpensify commented on Feb 1, 2024

    @joekaufmanexpensify
    Contributor

    I too cannot reproduce this anymore. Closing as this is now fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringHot PickReady for an engineer to pick up and run withInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions