Skip to content

[Wave 6: Tags] Support Tag in Bill Split #31631

Closed

Description

@puneetlath

Just like we did in #27936 we should add Tag support for the bill split flow. Meaning:

  • tag can be selected
  • tag is optimistically set for the bill split and resulting expense
  • tag is sent to the API as part of the splitBill API call

Activity

  1. self-assigned this
    on Nov 21, 2023
  2. melvin-bot commented on Nov 21, 2023

    @melvin-bot

    Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

  3. rezkiy37 commented on Nov 21, 2023

    @rezkiy37
    Contributor

    Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

  4. rezkiy37 commented on Nov 21, 2023

    @rezkiy37
    Contributor

    @puneetlath, can I implement viewing/editing a tag in the scope of this issue? Like it was for categories here - #28628.

  5. puneetlath commented on Nov 21, 2023

    @puneetlath
    ContributorAuthor

    Yes please. Let's use this issue to bring feature parity for tags on bill split to whatever we do for categories.

  6. changed the title [-]Support Tag in Bill Splilt[/-] [+]Support Tag in Bill Split[/+] on Nov 21, 2023
  7. rezkiy37 commented on Nov 22, 2023

    @rezkiy37
    Contributor

    The PR - #31647 - is being reviewed internally now. Opening soon 🙂

  8. changed the title [-]Support Tag in Bill Split[/-] [+][Wave 6: Tags] Support Tag in Bill Split[/+] on Nov 27, 2023
  9. melvin-bot commented on Dec 6, 2023

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  10. yuwenmemon commented on Dec 6, 2023

    @yuwenmemon
    Contributor

    I believe I have a fix for the aforementioned deploy blocker, please see: #32541

  11. puneetlath commented on Dec 19, 2023

    @puneetlath
    ContributorAuthor

    Looks like we need to pay out @cubuspl42 for C+ on this. Is that right?

  12. jakub-trzebiatowski commented on Dec 20, 2023

    @jakub-trzebiatowski
    Contributor

    @puneetlath Yes, sounds right

  13. puneetlath commented on Dec 21, 2023

    @puneetlath
    ContributorAuthor

    @cubuspl42 offer here: https://www.upwork.com/nx/wm/offer/100143026

    Please ping me on this issue once you've accepted.

  14. jakub-trzebiatowski commented on Dec 22, 2023

    @jakub-trzebiatowski
    Contributor

    @puneetlath Thank you, done

  15. puneetlath commented on Dec 22, 2023

    @puneetlath
    ContributorAuthor

    Paid. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

NewFeatureSomething to build that is a new item.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions