Skip to content

[HOLD for payment 2023-11-30] Web - Chat creation - App crashes when creating group with new user and clicking on members #31654

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.1.7
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Click on Global FAB menu > start chat
  2. Input a new user you didn't have a chat before
  3. Click on add to group on the user
  4. Input another user you have a previous chat with
  5. Click on add to group on the user
  6. Click on create group
  7. Click on the group header
  8. Click on members

Expected Result:

App should show the list of the members

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6286021_1700594765327.Screencast_from_11-21-2023_10_12_25_PM.mp4

View all open jobs on GitHub

Activity

  1. github-actions commented on Nov 21, 2023

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Nov 21, 2023

    @melvin-bot

    Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. melvin-bot commented on Nov 21, 2023

    @melvin-bot

    📣 @github-actions[bot]! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  4. kbecciv commented on Nov 21, 2023

    @kbecciv
    Author

    Issue is not reproduced on production

    Recording.5492.mp4
  5. pecanoro commented on Nov 21, 2023

    @pecanoro
    Contributor

    This happens when people are not known between each other and show as hidden:

    image

  6. pecanoro commented on Nov 21, 2023

    @pecanoro
    Contributor

    I will try to look for the PR that broke it

  7. pecanoro commented on Nov 21, 2023

    @pecanoro
    Contributor

    If not reproducible on main, we still need to look for the PR that fixed it and CP it 😄

  8. pecanoro commented on Nov 21, 2023

    @pecanoro
    Contributor

    I think this could be something related to the back-end since it's not returning the display name.

  9. pecanoro commented on Nov 21, 2023

    @pecanoro
    Contributor

    @puneetlath I think the changes here caused the deploy blocker since the front-end is expecting a display name.

  10. luacmartins commented on Nov 21, 2023

    @luacmartins
    Contributor

    We CPed a fix for this, so I'm gonna remove the blocker label

  11. puneetlath commented on Nov 22, 2023

    @puneetlath
    Contributor

    This is fixed and CP'd. No payment needed. Going to go ahead and close.

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Nov 23, 2023
  13. changed the title [-]Web - Chat creation - App crashes when creating group with new user and clicking on members[/-] [+][HOLD for payment 2023-11-30] Web - Chat creation - App crashes when creating group with new user and clicking on members[/+] on Nov 23, 2023
  14. melvin-bot commented on Nov 23, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Nov 23, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-11-30. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions