You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-24] [$500] Share code/Get $250 - Copy referral link is not activated using the Tab button #32080
Version Number: 1.4.4-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$500] Share code/Get $250 - Copy referral link is not activated using the Tab button[/-][+][HOLD for payment 2024-01-24] [$500] Share code/Get $250 - Copy referral link is not activated using the Tab button[/+]on Jan 24, 2024
Activity
github-actions commentedon Nov 28, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Nov 28, 2023
Triggered auto assignment to @robertjchen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.DylanDylann commentedon Nov 28, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
App/src/components/Pressable/PressableWithDelayToggle.tsx
Line 82 in 61ed900
What changes do you think we should make in order to solve the problem?
App/src/components/Pressable/PressableWithDelayToggle.tsx
Line 95 in 61ed900
to:
pressOnEnter: trueApp/src/pages/ReferralDetailsPage.js
Lines 106 to 113 in 61ed900
dataSet={{tag: 'pressable'}}to:App/src/components/Pressable/PressableWithDelayToggle.tsx
Line 95 in 61ed900
It will become:
App/src/components/Button/validateSubmitShortcut/index.ts
Lines 13 to 21 in 1682be4
to:
const validateSubmitShortcut: ValidateSubmitShortcut = (isFocused, isDisabled, isLoading, event, shouldSkipWhenFocusingOnPressable) => { const eventTarget = event?.target as HTMLElement; + const focusedDataTag = lodashGet(event, ['target', 'attributes', 'data-tag', 'value']); + if (focusedDataTag === 'pressable' && shouldSkipWhenFocusingOnPressable) { + return; + } if (!isFocused || isDisabled || isLoading || eventTarget.nodeName === 'TEXTAREA') { return false; } event?.preventDefault(); return true; };shouldSkipWhenFocusingOnPressableis added to keep the backward compatibilitymountiny commentedon Nov 28, 2023
Not a blocker, same happens in production
https://github.com/Expensify/App/assets/36083550/ada6e6b7-c30e-4abf-a4e5-d410139cd20d
melvin-bot commentedon Dec 1, 2023
@robertjchen Whoops! This issue is 2 days overdue. Let's get this updated quick!
DylanDylann commentedon Dec 3, 2023
@robertjchen I just pdated my proposal
36 remaining items
melvin-bot commentedon Jan 4, 2024
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)robertjchen commentedon Jan 4, 2024
@greg-schroeder Could you please assist with the next steps here now that the PR has been merged and deployed? Thanks!
melvin-bot commentedon Jan 16, 2024
@robertjchen, @narefyev91, @greg-schroeder, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Jan 18, 2024
@robertjchen, @narefyev91, @greg-schroeder, @DylanDylann Huh... This is 4 days overdue. Who can take care of this?
robertjchen commentedon Jan 19, 2024
bump @greg-schroeder 🙏
[-][$500] Share code/Get $250 - Copy referral link is not activated using the Tab button[/-][+][HOLD for payment 2024-01-24] [$500] Share code/Get $250 - Copy referral link is not activated using the Tab button[/+]greg-schroeder commentedon Jan 24, 2024
Okay looks like this is ready to pay
greg-schroeder commentedon Jan 24, 2024
C: @DylanDylann
C+: @narefyev91
both $500
greg-schroeder commentedon Jan 24, 2024
The upwork job closed for inactivity so I have to create a new one
greg-schroeder commentedon Jan 24, 2024
offer sent @DylanDylann - also I forgot @narefyev91 you're CS, right?