Skip to content

[Awaiting checklist completion] [Wave 6: Workspace Chats] Expense - 'Marked as reimbursed' message in expense report is not wrapped #32286

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.6.2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #32157

Action Performed:

Precondition:

  • User is an employee of a Collect workspace
  1. Log in to ND as the employee
  2. Go to the workspace chat > + > Request money
  3. Create a manual request
  4. As admin, pay the request
  5. As employee, tap on the expense preview to open the paid expense report

Expected Result:

The reimbursement message at the top is wrapped

Actual Result:

The reimbursement message at the top is not wrapped

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6296257_1701363889492.Screen_Recording_20231130_233045_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010ff3867dd75517b9
  • Upwork Job ID: 1734928173565202432
  • Last Price Increase: 2023-12-13

Activity

  1. github-actions commented on Nov 30, 2023

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 30, 2023
  3. self-assigned this
    on Nov 30, 2023
  4. mountiny commented on Nov 30, 2023

    @mountiny
    Contributor

    Not a blocker, this is a feature behind beta and normal customers cant see this now.

    Callstack can help us with this

  5. rezkiy37 commented on Dec 1, 2023

    @rezkiy37
    Contributor

    Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

  6. 68 remaining items

  7. bfitzexpensify commented on Jan 11, 2024

    @bfitzexpensify
    Contributor

    I'm going to be mostly ooo until Jan 29, assigning a second BZ team member to keep an eye on this.

    • final step here is the completion of the BZ checklist by @Ollyws
  8. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 11, 2024
  9. melvin-bot commented on Jan 11, 2024

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  10. changed the title [-][HOLD for payment 2024-01-03] [Wave 6: Workspace Chats] Expense - 'Marked as reimbursed' message in expense report is not wrapped[/-] [+][Awaiting checklist completion] [Wave 6: Workspace Chats] Expense - 'Marked as reimbursed' message in expense report is not wrapped[/+] on Jan 11, 2024
  11. Ollyws commented on Jan 15, 2024

    @Ollyws
    Contributor

    BugZero Checklist:

    • The PR that introduced the bug has been identified. Link to the PR:

    #29309

    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    #29309 (comment)

    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    N/A

    • Determine if we should create a regression test for this bug.

    Yes but I think it's only worth it on the monthly tests.

    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:
    
    User is an employee of a Collect workspace.
    Admin that approves your expense requests, must have a really long email.
    
    1. Log in to ND as the employee.
    2. Go to the workspace chat > + > Request money.
    3. Create a manual request.
    4. Submit the request.
    5. Tap on the expense preview to open the paid expense report.
    6. Verify that an admin's email is wrapped.
    

    Do we agree 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions