You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Awaiting checklist completion] [Wave 6: Workspace Chats] Expense - 'Marked as reimbursed' message in expense report is not wrapped #32286
Version Number: 1.4.6.2 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][HOLD for payment 2024-01-03] [Wave 6: Workspace Chats] Expense - 'Marked as reimbursed' message in expense report is not wrapped[/-][+][Awaiting checklist completion] [Wave 6: Workspace Chats] Expense - 'Marked as reimbursed' message in expense report is not wrapped[/+]on Jan 11, 2024
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
N/A
Determine if we should create a regression test for this bug.
Yes but I think it's only worth it on the monthly tests.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
User is an employee of a Collect workspace.
Admin that approves your expense requests, must have a really long email.
1. Log in to ND as the employee.
2. Go to the workspace chat > + > Request money.
3. Create a manual request.
4. Submit the request.
5. Tap on the expense preview to open the paid expense report.
6. Verify that an admin's email is wrapped.
Activity
github-actions commentedon Nov 30, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
mountiny commentedon Nov 30, 2023
Not a blocker, this is a feature behind beta and normal customers cant see this now.
Callstack can help us with this
rezkiy37 commentedon Dec 1, 2023
Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.
68 remaining items
bfitzexpensify commentedon Jan 11, 2024
I'm going to be mostly ooo until Jan 29, assigning a second BZ team member to keep an eye on this.
melvin-bot commentedon Jan 11, 2024
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.[-][HOLD for payment 2024-01-03] [Wave 6: Workspace Chats] Expense - 'Marked as reimbursed' message in expense report is not wrapped[/-][+][Awaiting checklist completion] [Wave 6: Workspace Chats] Expense - 'Marked as reimbursed' message in expense report is not wrapped[/+]Ollyws commentedon Jan 15, 2024
BugZero Checklist:
#29309
#29309 (comment)
N/A
Yes but I think it's only worth it on the monthly tests.
Regression Test Proposal
Do we agree 👍 or 👎