Skip to content

[HOLD for payment 2023-12-12] Android - Room - Hard to focus the name input field after the error message appears #32402

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.7-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Open the App
  2. Log in with any Expensifail account
  3. Press + button > Press Start chat > Switch to # Room
  4. Enter incorrect data for receiving an error
  5. Focus on another input field
  6. Try to focus again on the name input field

Expected Result:

No any problems with focusing the name input field after the error message appears

Actual Result:

Hard to focus the name input field after the error message appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6298606_1701520803574.Record_2023-12-01-20-39-05_4f9154176b47c00da84e32064abf1c48.mp4

View all open jobs on GitHub

Activity

  1. github-actions commented on Dec 2, 2023

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Dec 2, 2023

    @melvin-bot

    Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. kbecciv commented on Dec 2, 2023

    @kbecciv
    Author

    Not reproduced on production

    Screen_Recording_20231202_200933_New.Expensify.mp4
  4. luacmartins commented on Dec 4, 2023

    @luacmartins
    Contributor

    Potentially caused by #30996

  5. luacmartins commented on Dec 4, 2023

    @luacmartins
    Contributor

    Gonna see if the revert fixes this issue

  6. self-assigned this
    on Dec 4, 2023
  7. luacmartins commented on Dec 4, 2023

    @luacmartins
    Contributor

    Fixed on this revert #32440

  8. dangrous commented on Dec 5, 2023

    @dangrous
    Contributor

    Thank you for handling! We should figure out why I was assigned an hourly on a weekend though - or was it just that everyone was off so it picked randomly?

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Dec 5, 2023
  10. changed the title [-]Android - Room - Hard to focus the name input field after the error message appears[/-] [+][HOLD for payment 2023-12-12] Android - Room - Hard to focus the name input field after the error message appears[/+] on Dec 5, 2023
  11. melvin-bot commented on Dec 5, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.7-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-12-12. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR
  12. kowczarz commented on Dec 5, 2023

    @kowczarz
    Contributor

    I've tried to reproduce this issue on here #32432 (the #32440 is reverted, so the bug should occur) and I couldn't do it

    Screen.Recording.2023-12-05.at.09.52.15.mov
  13. luacmartins commented on Dec 5, 2023

    @luacmartins
    Contributor

    hmm that issue was resolved when I reverted #30996. Not sure why it's not reproducible. In that case, I'd just add a test step covering the issue so we make sure to test it and that's indeed fixed.

  14. kowczarz commented on Dec 7, 2023

    @kowczarz
    Contributor

    I know, but I tested it on a branch where I reverted that revert. I just added this flow to test scenarios in #32432

  15. luacmartins commented on Dec 7, 2023

    @luacmartins
    Contributor

    Sounds good! Thanks for adding that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions