Skip to content

[HOLD for payment 2023-12-28] [$500] Expense report header is missing the three dots icon #32414

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1701391916879549

Action Performed:

Go to an expense report, look at the top header area

Expected Result:

The header area should have a three dots (ellipsis overflow) menu in the top right. In this menu, there should at least be a pin and call option)

Actual Result:

There is no overflow ellipsis menu here

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

CleanShot 2023-11-30 at 19 51 08@2x

Snip - (59) New Expensify - Google Chrome (2)

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01896b1282e560a2b7
  • Upwork Job ID: 1731335924328407040
  • Last Price Increase: 2023-12-10
  • Automatic offers:
    • aimane-chnaif | Reviewer | 28037783
    • mkhutornyi | Contributor | 28037784

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 3, 2023
  2. melvin-bot commented on Dec 3, 2023

    @melvin-bot

    Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Dec 3, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 3, 2023
  5. changed the title [-]Expense report header is missing the three dots icon[/-] [+][$500] Expense report header is missing the three dots icon[/+] on Dec 3, 2023
  6. melvin-bot commented on Dec 3, 2023

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 3, 2023
  8. melvin-bot commented on Dec 3, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

  9. mkhutornyi commented on Dec 3, 2023

    @mkhutornyi
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Three dots menu is missing in expense request header

    What is the root cause of that problem?

    New feature

    What changes do you think we should make in order to solve the problem?

    In MoneyReportHeader, pass threeDotsMenuItems, shouldShowThreeDotsButton, threeDotsAnchorPosition props to HeaderWithBackButton

                    threeDotsMenuItems={threeDotMenuItems}
                    shouldShowThreeDotsButton
                    threeDotsAnchorPosition={styles.threeDotsPopoverOffsetNoCloseButton(windowWidth)}
    

    We can discuss what options to put but for now, Zoom and Google Meet is added

    demo

    Edit: (for pin / unpin option)

    shouldShow: (type, reportAction, isArchivedRoom, betas, anchor, isChronosReport, reportID, isPinnedChat) =>
    type === CONTEXT_MENU_TYPES.REPORT && !isPinnedChat && !ReportUtils.isMoneyRequestReport(reportID),

    shouldShow: (type, reportAction, isArchivedRoom, betas, anchor, isChronosReport, reportID, isPinnedChat) =>
    type === CONTEXT_MENU_TYPES.REPORT && isPinnedChat && !ReportUtils.isMoneyRequestReport(reportID),

    Here, we should remove && !ReportUtils.isMoneyRequestReport(reportID) condition

    And also add to threeDotMenuItems array. This logic can be copied from

    threeDotMenuItems.push(HeaderUtils.getPinMenuItem(props.report));
    if (isConcierge && props.guideCalendarLink) {
    threeDotMenuItems.push({
    icon: Expensicons.Phone,
    text: translate('videoChatButtonAndMenu.tooltip'),
    onSelected: Session.checkIfActionIsAllowed(() => {
    Link.openExternalLink(props.guideCalendarLink);
    }),
    });
    } else if (!isAutomatedExpensifyAccount && !isTaskReport && !isArchivedRoom) {
    threeDotMenuItems.push({
    icon: ZoomIcon,
    text: translate('videoChatButtonAndMenu.zoom'),
    onSelected: Session.checkIfActionIsAllowed(() => {
    Link.openExternalLink(CONST.NEW_ZOOM_MEETING_URL);
    }),
    });
    threeDotMenuItems.push({
    icon: GoogleMeetIcon,
    text: translate('videoChatButtonAndMenu.googleMeet'),
    onSelected: Session.checkIfActionIsAllowed(() => {
    Link.openExternalLink(CONST.NEW_GOOGLE_MEET_MEETING_URL);
    }),
    });
    }

    To hide pin when RBR shows, add && !hasBrickError to this condition:

    {!shouldShowGreenDotIndicator && optionItem.isPinned && (

  10. yh-0218 commented on Dec 3, 2023

    @yh-0218
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Three dots menu is missing in expense request header

    What is the root cause of that problem?

    We didn't handle Three dots menu on MoneyReportHeader

    What changes do you think we should make in order to solve the problem?

    <HeaderWithBackButton

    we need to add

         shouldShowThreeDotsButton
         threeDotsMenuItems={threeDotsMenuItems}
         threeDotsAnchorPosition={styles.threeDotsPopoverOffsetNoCloseButton(windowWidth)}
    

    We can add more menu items

        const threeDotsMenuItems = [HeaderUtils.getPinMenuItem(moneyRequestReport)];
        if (!ReportUtils.isArchivedRoom(chatReport)) {
            threeDotsMenuItems.push({
                icon: ZoomIcon,
                text: translate('videoChatButtonAndMenu.zoom'),
                onSelected: Session.checkIfActionIsAllowed(() => {
                    Link.openExternalLink(CONST.NEW_ZOOM_MEETING_URL);
                }),
            });
            threeDotsMenuItems.push({
                icon: GoogleMeetIcon,
                text: translate('videoChatButtonAndMenu.googleMeet'),
                onSelected: Session.checkIfActionIsAllowed(() => {
                    Link.openExternalLink(CONST.NEW_GOOGLE_MEET_MEETING_URL);
                }),
            });
        }
    

    What alternative solutions did you explore? (Optional)

    Screenshot 2023-12-03 at 5 58 57 PM
  11. DylanDylann commented on Dec 3, 2023

    @DylanDylann
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Expense report header is missing the three dots icon

    What is the root cause of that problem?

    We don't have logic to display three-dot button on the IOU/Expense Report

    What changes do you think we should make in order to solve the problem?

    In MoneyReportHeader we should add 3 props: shouldShowThreeDotsButton, threeDotsMenuItems, threeDotsAnchorPosition

    <HeaderWithBackButton

    In threeDotsMenuItems, we add pin/unpin functionality as we did here

    const threeDotsMenuItems = [HeaderUtils.getPinMenuItem(report)];

    Note that, we also add pin/unpin functionality in the context menu (when right click to IOU/Expense report in LHN) for consistency by removing !ReportUtils.isMoneyRequestReport in both places

    type === CONTEXT_MENU_TYPES.REPORT && isPinnedChat && !ReportUtils.isMoneyRequestReport(reportID),

    type === CONTEXT_MENU_TYPES.REPORT && !isPinnedChat && !ReportUtils.isMoneyRequestReport(reportID),

    In three dot, we also consider adding Zoom and Google meet options as we did here

    } else if (!isAutomatedExpensifyAccount && !isTaskReport && !isArchivedRoom) {
    threeDotMenuItems.push({
    icon: ZoomIcon,
    text: translate('videoChatButtonAndMenu.zoom'),
    onSelected: Session.checkIfActionIsAllowed(() => {
    Link.openExternalLink(CONST.NEW_ZOOM_MEETING_URL);
    }),
    });
    threeDotMenuItems.push({
    icon: GoogleMeetIcon,
    text: translate('videoChatButtonAndMenu.googleMeet'),
    onSelected: Session.checkIfActionIsAllowed(() => {
    Link.openExternalLink(CONST.NEW_GOOGLE_MEET_MEETING_URL);
    }),
    });

    In LHN Row we don't want to display 3 icons so that in here

    {!shouldShowGreenDotIndicator && optionItem.isPinned && (
    <View
    style={styles.ml2}
    accessibilityLabel={translate('sidebarScreen.chatPinned')}
    >
    <Icon src={Expensicons.Pin} />
    </View>
    )}

    We also should hide pin icon if RBR appears by updating condition like this

                                {!shouldShowGreenDotIndicator && !hasBrickError && optionItem.isPinned && (
    
    

    What alternative solutions did you explore? (Optional)

  12. kurakurasakti commented on Dec 4, 2023

    @kurakurasakti

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Three dots menu on header is missing when open expense request.

    What is the root cause of that problem?

    missing 3 dots handler on MoneyReportHeader so when the component load, header doesn't read the condition

    What changes do you think we should make in order to solve the problem?

    Send props to MoneyReportHeader and also the condition to show the 3 dots.

    What alternative solutions did you explore? (Optional)

  13. 41 remaining items

  14. aimane-chnaif commented on Dec 29, 2023

    @aimane-chnaif
    Contributor

    Regression Test Proposal

    1. Go to any IOU or expense report
    2. Verify that header has 3 dots menu icon in the top right
    3. Click on the icon
    4. Verify that Pin / Unpin, Zoom and Google Meet options show and they work properly
    5. Right click this report in LHN
    6. Verify that Pin / Unpin option shows and it works properly. If it shows GBR/RBR, verify that pin icon is hidden
  15. iwiznia commented on Dec 29, 2023

    @iwiznia
    Contributor

    Nice, is that a new test? I thought we needed to update one and if so, do you happen to know which?

  16. aimane-chnaif commented on Dec 29, 2023

    @aimane-chnaif
    Contributor

    I thought we needed to update one

    I am not sure. https://github.com/Expensify/Expensify/issues/298942 doesn't have TestRail link?

  17. aimane-chnaif commented on Dec 29, 2023

    @aimane-chnaif
    Contributor

    Let's treat as new test case. I believe QA team will update TestRail properly

  18. iwiznia commented on Dec 29, 2023

    @iwiznia
    Contributor

    Ohh there's a link here did not see it 👍

  19. iwiznia commented on Dec 29, 2023

    @iwiznia
    Contributor
  20. melvin-bot commented on Jan 2, 2024

    @melvin-bot

    @iwiznia, @kevinksullivan, @aimane-chnaif, @mkhutornyi Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  21. melvin-bot commented on Jan 4, 2024

    @melvin-bot

    @iwiznia, @kevinksullivan, @aimane-chnaif, @mkhutornyi Huh... This is 4 days overdue. Who can take care of this?

  22. iwiznia commented on Jan 5, 2024

    @iwiznia
    Contributor
  23. kevinksullivan commented on Jan 8, 2024

    @kevinksullivan
    Contributor

    payments made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions