You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-12-28] [$500] Expense report header is missing the three dots icon #32414
changed the title [-]Expense report header is missing the three dots icon[/-][+][$500] Expense report header is missing the three dots icon[/+]on Dec 3, 2023
Note that, we also add pin/unpin functionality in the context menu (when right click to IOU/Expense report in LHN) for consistency by removing !ReportUtils.isMoneyRequestReport in both places
Activity
melvin-bot commentedon Dec 3, 2023
Triggered auto assignment to @kevinksullivan (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Dec 3, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)[-]Expense report header is missing the three dots icon[/-][+][$500] Expense report header is missing the three dots icon[/+]melvin-bot commentedon Dec 3, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01896b1282e560a2b7
melvin-bot commentedon Dec 3, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (
External)mkhutornyi commentedon Dec 3, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Three dots menu is missing in expense request header
What is the root cause of that problem?
New feature
What changes do you think we should make in order to solve the problem?
In MoneyReportHeader, pass
threeDotsMenuItems,shouldShowThreeDotsButton,threeDotsAnchorPositionprops toHeaderWithBackButtonWe can discuss what options to put but for now, Zoom and Google Meet is added
Edit: (for pin / unpin option)
App/src/pages/home/report/ContextMenu/ContextMenuActions.js
Lines 420 to 421 in 3827a9c
App/src/pages/home/report/ContextMenu/ContextMenuActions.js
Lines 434 to 435 in 3827a9c
Here, we should remove
&& !ReportUtils.isMoneyRequestReport(reportID)conditionAnd also add to threeDotMenuItems array. This logic can be copied from
App/src/pages/home/HeaderView.js
Lines 155 to 180 in 3827a9c
To hide pin when RBR shows, add
&& !hasBrickErrorto this condition:App/src/components/LHNOptionsList/OptionRowLHN.js
Line 303 in 3827a9c
yh-0218 commentedon Dec 3, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Three dots menu is missing in expense request header
What is the root cause of that problem?
We didn't handle Three dots menu on
MoneyReportHeaderWhat changes do you think we should make in order to solve the problem?
App/src/components/MoneyReportHeader.js
Line 101 in 48b5a29
we need to add
We can add more menu items
What alternative solutions did you explore? (Optional)
DylanDylann commentedon Dec 3, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Expense report header is missing the three dots icon
What is the root cause of that problem?
We don't have logic to display three-dot button on the IOU/Expense Report
What changes do you think we should make in order to solve the problem?
In MoneyReportHeader we should add 3 props: shouldShowThreeDotsButton, threeDotsMenuItems, threeDotsAnchorPosition
App/src/components/MoneyReportHeader.js
Line 101 in cc4add5
In threeDotsMenuItems, we add pin/unpin functionality as we did here
App/src/components/MoneyRequestHeader.js
Line 97 in cc4add5
Note that, we also add pin/unpin functionality in the context menu (when right click to IOU/Expense report in LHN) for consistency by removing
!ReportUtils.isMoneyRequestReportin both placesApp/src/pages/home/report/ContextMenu/ContextMenuActions.js
Line 435 in cc4add5
App/src/pages/home/report/ContextMenu/ContextMenuActions.js
Line 421 in cc4add5
In three dot, we also consider adding Zoom and Google meet options as we did here
App/src/pages/home/HeaderView.js
Lines 165 to 179 in cc4add5
In LHN Row we don't want to display 3 icons so that in here
App/src/components/LHNOptionsList/OptionRowLHN.js
Lines 303 to 310 in 3827a9c
We also should hide pin icon if RBR appears by updating condition like this
What alternative solutions did you explore? (Optional)
kurakurasakti commentedon Dec 4, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Three dots menu on header is missing when open expense request.
What is the root cause of that problem?
missing 3 dots handler on
MoneyReportHeaderso when the component load, header doesn't read the conditionWhat changes do you think we should make in order to solve the problem?
Send props to
MoneyReportHeaderand also the condition to show the 3 dots.What alternative solutions did you explore? (Optional)
41 remaining items
aimane-chnaif commentedon Dec 29, 2023
Regression Test Proposal
iwiznia commentedon Dec 29, 2023
Nice, is that a new test? I thought we needed to update one and if so, do you happen to know which?
aimane-chnaif commentedon Dec 29, 2023
I am not sure. https://github.com/Expensify/Expensify/issues/298942 doesn't have TestRail link?
aimane-chnaif commentedon Dec 29, 2023
Let's treat as new test case. I believe QA team will update TestRail properly
iwiznia commentedon Dec 29, 2023
Ohh there's a link here did not see it 👍
iwiznia commentedon Dec 29, 2023
Created it here https://github.com/Expensify/Expensify/issues/355542
melvin-bot commentedon Jan 2, 2024
@iwiznia, @kevinksullivan, @aimane-chnaif, @mkhutornyi Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Jan 4, 2024
@iwiznia, @kevinksullivan, @aimane-chnaif, @mkhutornyi Huh... This is 4 days overdue. Who can take care of this?
iwiznia commentedon Jan 5, 2024
@kevinksullivan ?
kevinksullivan commentedon Jan 8, 2024
payments made