You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Delete comment - Deleted comment is still visible in receiver side #3249
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Might need some help sorting this out, I think I know what is happening, but not sure on how to fix it.
So when someone deletes the attachement they are changing '[Attachment]' to '' wich basically sets the comment as no longer being an attachement but I assume all the attachement information would still be around. I think this might need a bit more work on the Web side, but maybe not a bug on e.cash itself.
Or maybe we should no able to delete attachements for now, and the logic to shouldShow should be the same for both edit and delete.
I just merged a contributor PR which implements a separate function called canEditReportAction and uses it to determine whether or not to show these actions. It should return false for any attachment reportActions, and should temporarily resolve this to prevent it from being a deploy blocker.
ok cool, I've checked the PR, and it does one of the things I suggested, so I'm happy that this should no longer be a deploy blocker @isagoico can we check please :)
To be clear we can no longer delete attachements, the delete button should not be visible anymore for attachements.
Activity
MelvinBot commentedon May 31, 2021
Triggered auto assignment to @MariaHCD (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.OSBotify commentedon May 31, 2021
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:isagoico commentedon May 31, 2021
Added the deploy blocker label since the Delete comment feature has not hit production yet.
MariaHCD commentedon Jun 1, 2021
Tagging @sketchydroide as you worked on the original issue! 🙌🏼
sketchydroide commentedon Jun 1, 2021
Thanks @MariaHCD.
Hmm, not sure what is happening, but I'll take a look
sketchydroide commentedon Jun 1, 2021
Might need some help sorting this out, I think I know what is happening, but not sure on how to fix it.
So when someone deletes the attachement they are changing
'[Attachment]'to''wich basically sets the comment as no longer being an attachement but I assume all the attachement information would still be around. I think this might need a bit more work on the Web side, but maybe not a bug on e.cash itself.Or maybe we should no able to delete attachements for now, and the logic to
shouldShowshould be the same for both edit and delete.Any thought and inputs @rory @yuwenmemon @marcaaron?
roryabraham commentedon Jun 1, 2021
I just merged a contributor PR which implements a separate function called canEditReportAction and uses it to determine whether or not to show these actions. It should return false for any attachment
reportActions, and should temporarily resolve this to prevent it from being a deploy blocker.sketchydroide commentedon Jun 1, 2021
ok cool, I've checked the PR, and it does one of the things I suggested, so I'm happy that this should no longer be a deploy blocker @isagoico can we check please :)
To be clear we can no longer delete attachements, the delete button should not be visible anymore for attachements.
isagoico commentedon Jun 1, 2021
Checked and the option to delete is not there 🎉 Removing deploy blocker label

sketchydroide commentedon Jun 1, 2021
Ok closing this one then, as we can't reproduce it anymore, and we will probably need make a decision on how to handle attachements somewhere else.