Skip to content

[HOLD for payment 2024-03-11] [$500] Chat - Popup window appears that can't close tapping outside #32610

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.9-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: use an account you haven't logged in with yet today

  1. Go to URL https://staging.new.expensify.com/
  2. Login -> popup appears, sometimes it appears when going through the app or login via Apple/Gmail
  3. Click outside the popup

Expected Result:

The popup closes by tapping outside & focus mode is enabled based on - https://expensify.slack.com/archives/C01SKUP7QR0/p1701987845872109?thread_ts=1701982931.866569&cid=C01SKUP7QR0

About this popup: it has an nvp. it can only be triggered once. anyone with 30 or more chats is the trigger.

Actual Result:

The popup doesn't close
Focus mode activates automatically

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6303868_1701912055194!image__192_

Bug6303868_1701912055210.Record_2023-12-07-02-32-11_4f9154176b47c00da84e32064abf1c48.mp4
Bug6303868_1701912055198.bandicam_2023-12-07_02-40-10-498.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e281391727f24e86
  • Upwork Job ID: 1734278720260624384
  • Last Price Increase: 2023-12-18
  • Automatic offers:
    • neonbhai | Contributor | 28064527

Activity

  1. github-actions commented on Dec 7, 2023

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Dec 7, 2023

    @melvin-bot

    Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. marcaaron commented on Dec 7, 2023

    @marcaaron
    Contributor

    I think it can't really be a blocker really because it's a new feature in any case.

    If there is an existing modal that won't close - let's look into it, but otherwise, not a blocker IMO.

  4. marcaaron commented on Dec 7, 2023

    @marcaaron
    Contributor

    Woops sorry I meant to just remove the blocker. We could fix this, but it's a low priority thing.

  5. removed their assignment
    on Dec 7, 2023
  6. 99 remaining items

  7. changed the title [-][$500] Chat - Popup window appears that can't close tapping outside[/-] [+][HOLD for payment 2024-03-11] [$500] Chat - Popup window appears that can't close tapping outside[/+] on Mar 4, 2024
  8. melvin-bot commented on Mar 4, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Mar 4, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-11. 🎊

    For reference, here are some details about the assignees on this issue:

  10. melvin-bot commented on Mar 4, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
    • [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@rushatgabhane] Determine if we should create a regression test for this bug.
    • [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  11. rushatgabhane commented on Mar 11, 2024

    @rushatgabhane
    Member
    1. The PR that introduced the bug has been identified. Link to the PR: new feature

    2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N.A.

    3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

    4. Determine if we should create a regression test for this bug. Yes

    5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

      1. Login to an account that has more than 200 chats so that you see focus modal prompt.
      2. Verify that you see an illustration in the modal.
  12. rushatgabhane commented on Mar 11, 2024

    @rushatgabhane
    Member

    @Christinadobrzyn could you please attach payment summary. thanks 🙇

  13. rushatgabhane commented on Mar 11, 2024

    @rushatgabhane
    Member
  14. Christinadobrzyn commented on Mar 12, 2024

    @Christinadobrzyn
    Contributor

    Payouts due:

    Contributor: $500 @neonbhai (paid in Upwork - https://www.upwork.com/nx/wm/workroom/35959554/overview)
    Contributor+: $500 @rushatgabhane (in NewDot)

    Upwork job is here.

    Regression test posted - https://github.com/Expensify/Expensify/issues/377899

    Closing!

  15. JmillsExpensify commented on Mar 18, 2024

    @JmillsExpensify
    Contributor

    $500 approved for @rushatgabhane based on summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2DesignEngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions