You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-03-11] [$500] Chat - Popup window appears that can't close tapping outside #32610
Version Number: 1.4.9-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Precondition: use an account you haven't logged in with yet today
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$500] Chat - Popup window appears that can't close tapping outside[/-][+][HOLD for payment 2024-03-11] [$500] Chat - Popup window appears that can't close tapping outside[/+]on Mar 4, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
[@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@rushatgabhane] Determine if we should create a regression test for this bug.
[@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The PR that introduced the bug has been identified. Link to the PR: new feature
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N.A.
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again
Login to an account that has more than 200 chats so that you see focus modal prompt.
Activity
github-actions commentedon Dec 7, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 7, 2023
Triggered auto assignment to @marcaaron (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.marcaaron commentedon Dec 7, 2023
I think it can't really be a blocker really because it's a new feature in any case.
If there is an existing modal that won't close - let's look into it, but otherwise, not a blocker IMO.
marcaaron commentedon Dec 7, 2023
Woops sorry I meant to just remove the blocker. We could fix this, but it's a low priority thing.
99 remaining items
[-][$500] Chat - Popup window appears that can't close tapping outside[/-][+][HOLD for payment 2024-03-11] [$500] Chat - Popup window appears that can't close tapping outside[/+]melvin-bot commentedon Mar 4, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 4, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-11. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 4, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
rushatgabhane commentedon Mar 11, 2024
The PR that introduced the bug has been identified. Link to the PR: new feature
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N.A.
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again
rushatgabhane commentedon Mar 11, 2024
@Christinadobrzyn could you please attach payment summary. thanks 🙇
rushatgabhane commentedon Mar 11, 2024
money request here - https://staging.new.expensify.com/r/7597420492097120
Christinadobrzyn commentedon Mar 12, 2024
Payouts due:
Contributor: $500 @neonbhai (paid in Upwork - https://www.upwork.com/nx/wm/workroom/35959554/overview)
Contributor+: $500 @rushatgabhane (in NewDot)
Upwork job is here.
Regression test posted - https://github.com/Expensify/Expensify/issues/377899
Closing!
JmillsExpensify commentedon Mar 18, 2024
$500 approved for @rushatgabhane based on summary.