Skip to content

[HOLD for payment 2024-01-22] HIGH: (Comment linking: step 1) 'maintainVisibleContentPosition' doesn't works with the large list #32634

Closed

Description

@perunt

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

Case 1 (correct)

  1. Create a list with the 50 elements. You can use Report Actions for items
  2. Set to FlatList:
maintainVisibleContentPosition={{
            minIndexForVisible: 0,
        }}
  1. Using onStartReached add 50 items

Case 2 (wrong)

  1. Create a list with the 50 elements. You can use Report Actions for items
  2. Set to FlatList:
maintainVisibleContentPosition={{
            minIndexForVisible: 0,
        }}
  1. Using onStartReached add 100 items

Expected Result:

In the both cases, you won't see any changes after adding new items, so the reportActions don't move in the viewport

Actual Result:

  1. In the first case, you won't see any changes after adding new items, so the reportActions don't move in the viewport
  2. In the second case, you would see slides after adding new elements to FlatList.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

EXPO snack: https://snack.expo.dev/@tarasperun/add-items-onsatartreached

Untitled.1.mov

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 7, 2023
  2. melvin-bot commented on Dec 7, 2023

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Dec 7, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. perunt commented on Dec 7, 2023

    @perunt
    ContributorAuthor

    @roryabraham mentioned you to be aware of this bug, which we are currently tackling

  5. janicduplessis commented on Dec 7, 2023

    @janicduplessis
    Contributor

    Update: found the problem, opened a PR to fix upstream, will patch in Expensify app next and verify the fix. react/react-native#41846

  6. changed the title [-]'maintainVisibleContentPosition' doesn't works with the large list[/-] [+]MEDIUM: 'maintainVisibleContentPosition' doesn't works with the large list[/+] on Dec 8, 2023
  7. changed the title [-]MEDIUM: 'maintainVisibleContentPosition' doesn't works with the large list[/-] [+]MEDIUM: (Comment linking) 'maintainVisibleContentPosition' doesn't works with the large list[/+] on Dec 8, 2023
  8. moved this from MEDIUM to HIGH in [#whatsnext] #vip-vsbon Dec 8, 2023
  9. changed the title [-]MEDIUM: (Comment linking) 'maintainVisibleContentPosition' doesn't works with the large list[/-] [+]HIGH: (Comment linking) 'maintainVisibleContentPosition' doesn't works with the large list[/+] on Dec 8, 2023
  10. changed the title [-]HIGH: (Comment linking) 'maintainVisibleContentPosition' doesn't works with the large list[/-] [+]HIGH: (Comment linking: step 1) 'maintainVisibleContentPosition' doesn't works with the large list[/+] on Dec 8, 2023
  11. isabelastisser commented on Dec 8, 2023

    @isabelastisser
    Contributor

    @roryabraham @perunt is there anything urgent I need to do here?

  12. 27 remaining items

  13. melvin-bot commented on Jan 15, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@roryabraham] The PR that introduced the bug has been identified. Link to the PR:
    • [@roryabraham] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@roryabraham] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@perunt] Determine if we should create a regression test for this bug.
    • [@perunt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. melvin-bot commented on Jan 22, 2024

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  15. isabelastisser commented on Jan 23, 2024

    @isabelastisser
    Contributor

    @roryabraham and @perunt, can you please complete the checklist above so the issue can be closed? Thanks!

  16. situchan commented on Jan 23, 2024

    @situchan
    Contributor

    I may take responsible for BZ Checklist since I reviewed PR

    I think we can skip checklist here.
    No regression. The bug was in upstream. Not able to catch in E/App until comment linking is live.

  17. moved this from In Progress to Done in Comment Linkingon Jan 23, 2024
  18. isabelastisser commented on Jan 23, 2024

    @isabelastisser
    Contributor

    Thanks @situchan !

  19. situchan commented on Jan 23, 2024

    @situchan
    Contributor

    @isabelastisser I am eligible for payment though not assigned here

  20. isabelastisser commented on Jan 23, 2024

    @isabelastisser
    Contributor

    To confirm, you acted as the C+ and the payment should be $500 in Upwork? @situchan

  21. situchan commented on Jan 23, 2024

    @situchan
    Contributor

    yes

  22. isabelastisser commented on Jan 23, 2024

    @isabelastisser
    Contributor

    Payment summary:

    @situchan C+. PR review. Upwork job link here.

  23. isabelastisser commented on Jan 23, 2024

    @isabelastisser
    Contributor

    All set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions