You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-22] HIGH: (Comment linking: step 1) 'maintainVisibleContentPosition' doesn't works with the large list #32634
Version Number: Reproducible in staging?: Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Slack conversation:
Action Performed:
Case 1 (correct)
Create a list with the 50 elements. You can use Report Actions for items
changed the title [-]'maintainVisibleContentPosition' doesn't works with the large list[/-][+]MEDIUM: 'maintainVisibleContentPosition' doesn't works with the large list[/+]on Dec 8, 2023
changed the title [-]MEDIUM: 'maintainVisibleContentPosition' doesn't works with the large list[/-][+]MEDIUM: (Comment linking) 'maintainVisibleContentPosition' doesn't works with the large list[/+]on Dec 8, 2023
changed the title [-]MEDIUM: (Comment linking) 'maintainVisibleContentPosition' doesn't works with the large list[/-][+]HIGH: (Comment linking) 'maintainVisibleContentPosition' doesn't works with the large list[/+]on Dec 8, 2023
changed the title [-]HIGH: (Comment linking) 'maintainVisibleContentPosition' doesn't works with the large list[/-][+]HIGH: (Comment linking: step 1) 'maintainVisibleContentPosition' doesn't works with the large list[/+]on Dec 8, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@roryabraham] The PR that introduced the bug has been identified. Link to the PR:
[@roryabraham] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@roryabraham] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@perunt] Determine if we should create a regression test for this bug.
[@perunt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
Activity
melvin-bot commentedon Dec 7, 2023
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Dec 7, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)perunt commentedon Dec 7, 2023
@roryabraham mentioned you to be aware of this bug, which we are currently tackling
janicduplessis commentedon Dec 7, 2023
Update: found the problem, opened a PR to fix upstream, will patch in Expensify app next and verify the fix. react/react-native#41846
[-]'maintainVisibleContentPosition' doesn't works with the large list[/-][+]MEDIUM: 'maintainVisibleContentPosition' doesn't works with the large list[/+][-]MEDIUM: 'maintainVisibleContentPosition' doesn't works with the large list[/-][+]MEDIUM: (Comment linking) 'maintainVisibleContentPosition' doesn't works with the large list[/+][-]MEDIUM: (Comment linking) 'maintainVisibleContentPosition' doesn't works with the large list[/-][+]HIGH: (Comment linking) 'maintainVisibleContentPosition' doesn't works with the large list[/+][-]HIGH: (Comment linking) 'maintainVisibleContentPosition' doesn't works with the large list[/-][+]HIGH: (Comment linking: step 1) 'maintainVisibleContentPosition' doesn't works with the large list[/+]isabelastisser commentedon Dec 8, 2023
@roryabraham @perunt is there anything urgent I need to do here?
27 remaining items
melvin-bot commentedon Jan 15, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Jan 22, 2024
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
isabelastisser commentedon Jan 23, 2024
@roryabraham and @perunt, can you please complete the checklist above so the issue can be closed? Thanks!
situchan commentedon Jan 23, 2024
I may take responsible for BZ Checklist since I reviewed PR
I think we can skip checklist here.
No regression. The bug was in upstream. Not able to catch in E/App until comment linking is live.
isabelastisser commentedon Jan 23, 2024
Thanks @situchan !
situchan commentedon Jan 23, 2024
@isabelastisser I am eligible for payment though not assigned here
isabelastisser commentedon Jan 23, 2024
To confirm, you acted as the C+ and the payment should be $500 in Upwork? @situchan
situchan commentedon Jan 23, 2024
yes
isabelastisser commentedon Jan 23, 2024
Payment summary:
@situchan C+. PR review. Upwork job link here.
isabelastisser commentedon Jan 23, 2024
All set!