Skip to content

[HOLD for payment 2023-12-20] [$500] IOU - Currency edit is saved when the edit is discarded in confirmation page #32826

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.11-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com.
  2. Go to 1:1 DM > + > Request money.
  3. Enter amount > Next.
  4. On confirmation page, click Amount.
  5. Click on the currency and select a different currency.
  6. Click back button.

Expected Result:

The previous currency is preserved as the new currency is not saved.

Actual Result:

The new currency is saved when the changes are discarded.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6309205_1702309892516.20231211_230527.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018f3d94b5f2243152
  • Upwork Job ID: 1734278105112006656
  • Last Price Increase: 2023-12-11
  • Automatic offers:
    • c3024 | Reviewer | 28037137
    • s-alves10 | Contributor | 28037138
    • situchan | Contributor | 28038451

Activity

  1. github-actions commented on Dec 11, 2023

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Dec 11, 2023

    @melvin-bot

    Triggered auto assignment to @blimpich (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. dummy-1111 commented on Dec 11, 2023

    @dummy-1111
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Currency edit is saved when the edit amount page is discarded in confirmation page

    What is the root cause of that problem?

    IOU.setMoneyRequestCurrency_temporaryForRefactor(transactionID, option.currencyCode);

    As you can see above, we save the currency data when select the currency.

    This is the root cause

    What changes do you think we should make in order to solve the problem?

    We need to implement the logic used here: use of currency query parameter

    1. Update
      route: {
      params: {iouType, reportID, transactionID, backTo},
      },
      transaction,
      transaction: {currency},

      to
        route: {
            params: {iouType, reportID, transactionID, backTo, currency: selectedCurrency},
        },
        transaction,
        transaction: {currency: originalCurrency},
    

    and define currency as

        const currency = selectedCurrency ?? originalCurrency;
    
    1. Move the below code to here

      IOU.setMoneyRequestCurrency_temporaryForRefactor(transactionID, option.currencyCode);

    2. Add an optional argument currency to the navigateBack and update the function like

        const navigateBack = (currency = undefined) => {
            if (pageIndex === 'confirm') {
                const routeToAmountPageWithConfirmationAsBackTo = getUrlWithBackToParam(backTo, `/${ROUTES.MONEY_REQUEST_STEP_CONFIRMATION.getRoute(iouType, transactionID, reportID)}`);
                Navigation.navigate(`${routeToAmountPageWithConfirmationAsBackTo}${currency ? `&currency=${currency}` : ''}`);
                return;
            }
            Navigation.goBack(backTo || ROUTES.HOME);
        };
    
    1. Update
      const confirmCurrencySelection = (option) => {
      Keyboard.dismiss();
      IOU.setMoneyRequestCurrency_temporaryForRefactor(transactionID, option.currencyCode);
      navigateBack();
      };

      to
        const confirmCurrencySelection = (option) => {
            Keyboard.dismiss();
            navigateBack(option.currencyCode);
        };
    

    This works as expected

    What alternative solutions did you explore? (Optional)

  4. blimpich commented on Dec 11, 2023

    @blimpich
    Contributor

    I'm looking at this. Taking some time to understand the code before deciding on anything. @S-ALVES I've reviewed your proposal and like it, but I'm going to briefly spend some time seeing if adding the data to the url is the best way to do this. I will update this issue hourly and decide as soon as I can on how to proceed.

  5. blimpich commented on Dec 11, 2023

    @blimpich
    Contributor

    Okay after looking at the code and understanding a bit more I think your solution @s-alves10 is definitely what we want. Thank you for your patience. Assigning you.

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 11, 2023
  7. 37 remaining items

  8. Christinadobrzyn commented on Dec 12, 2023

    @Christinadobrzyn
    Contributor

    Awesome thanks @luacmartins

    Following this PR for payment - #32851

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Dec 13, 2023
  10. changed the title [-][$500] IOU - Currency edit is saved when the edit is discarded in confirmation page[/-] [+][HOLD for payment 2023-12-20] [$500] IOU - Currency edit is saved when the edit is discarded in confirmation page[/+] on Dec 13, 2023
  11. melvin-bot commented on Dec 13, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Dec 13, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-12-20. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on Dec 13, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@situchan] The PR that introduced the bug has been identified. Link to the PR:
    • [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@situchan] Determine if we should create a regression test for this bug.
    • [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. Christinadobrzyn commented on Dec 20, 2023

    @Christinadobrzyn
    Contributor

    Ready for payment. Payouts due:

    Issue Reporter: NA
    Contributor: $500 @s-alves10 (paid in Upwork)
    Contributor+: $500 @situchan (paid in Upwork)

    Eligible for 50% #urgency bonus? N

    Upwork job is here.

    @situchan can you let me know about a regression test?

  15. situchan commented on Dec 20, 2023

    @situchan
    Contributor

    We don't need another regression test as bug was caught during staging deploy test by QA team

  16. Christinadobrzyn commented on Dec 21, 2023

    @Christinadobrzyn
    Contributor

    Awesome thanks @situchan

    Payments sent through Upwork based on this payment summary - #32826 (comment)

    this can be closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions