You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-12-20] [$500] IOU - Currency edit is saved when the edit is discarded in confirmation page #32826
Version Number: v1.4.11-1 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Go to staging.new.expensify.com.
Go to 1:1 DM > + > Request money.
Enter amount > Next.
On confirmation page, click Amount.
Click on the currency and select a different currency.
Click back button.
Expected Result:
The previous currency is preserved as the new currency is not saved.
Actual Result:
The new currency is saved when the changes are discarded.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
I'm looking at this. Taking some time to understand the code before deciding on anything. @S-ALVES I've reviewed your proposal and like it, but I'm going to briefly spend some time seeing if adding the data to the url is the best way to do this. I will update this issue hourly and decide as soon as I can on how to proceed.
Okay after looking at the code and understanding a bit more I think your solution @s-alves10 is definitely what we want. Thank you for your patience. Assigning you.
changed the title [-][$500] IOU - Currency edit is saved when the edit is discarded in confirmation page[/-][+][HOLD for payment 2023-12-20] [$500] IOU - Currency edit is saved when the edit is discarded in confirmation page[/+]on Dec 13, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-20. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
github-actions commentedon Dec 11, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 11, 2023
Triggered auto assignment to @blimpich (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.dummy-1111 commentedon Dec 11, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Currency edit is saved when the edit amount page is discarded in confirmation page
What is the root cause of that problem?
App/src/pages/iou/request/step/IOURequestStepCurrency.js
Line 81 in 55903d4
As you can see above, we save the currency data when select the currency.
This is the root cause
What changes do you think we should make in order to solve the problem?
We need to implement the logic used here: use of
currencyquery parameterApp/src/pages/iou/request/step/IOURequestStepAmount.js
Lines 38 to 42 in 14ef2a2
to
and define
currencyasMove the below code to here
App/src/pages/iou/request/step/IOURequestStepCurrency.js
Line 81 in 14ef2a2
Add an optional argument
currencyto the navigateBack and update the function likeApp/src/pages/iou/request/step/IOURequestStepCurrency.js
Lines 79 to 83 in 14ef2a2
to
This works as expected
What alternative solutions did you explore? (Optional)
blimpich commentedon Dec 11, 2023
I'm looking at this. Taking some time to understand the code before deciding on anything. @S-ALVES I've reviewed your proposal and like it, but I'm going to briefly spend some time seeing if adding the data to the url is the best way to do this. I will update this issue hourly and decide as soon as I can on how to proceed.
blimpich commentedon Dec 11, 2023
Okay after looking at the code and understanding a bit more I think your solution @s-alves10 is definitely what we want. Thank you for your patience. Assigning you.
37 remaining items
Christinadobrzyn commentedon Dec 12, 2023
Awesome thanks @luacmartins
Following this PR for payment - #32851
[-][$500] IOU - Currency edit is saved when the edit is discarded in confirmation page[/-][+][HOLD for payment 2023-12-20] [$500] IOU - Currency edit is saved when the edit is discarded in confirmation page[/+]melvin-bot commentedon Dec 13, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 13, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-20. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 13, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Christinadobrzyn commentedon Dec 20, 2023
Ready for payment. Payouts due:
Issue Reporter: NA
Contributor: $500 @s-alves10 (paid in Upwork)
Contributor+: $500 @situchan (paid in Upwork)
Eligible for 50% #urgency bonus? N
Upwork job is here.
@situchan can you let me know about a regression test?
situchan commentedon Dec 20, 2023
We don't need another regression test as bug was caught during staging deploy test by QA team
Christinadobrzyn commentedon Dec 21, 2023
Awesome thanks @situchan
Payments sent through Upwork based on this payment summary - #32826 (comment)
this can be closed!