Skip to content

[HOLD for payment 2024-03-07] [LOW] [P2P] [$500] IOU-Add a contact to request money and tap back button, contact added to split. #32912

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.11
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Tap fab
  3. Tap request money
  4. Enter an amount
  5. Tap next
  6. Select a contact
  7. Tap app's back button

Expected Result:

When add a contact to request money and tap back button, contact must not be added to split.

Actual Result:

When add a contact to request money and tap back button, contact added to split.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6309952_1702352257190.add_to_split.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ce8011451da4f3dc
  • Upwork Job ID: 1734532115895476224
  • Last Price Increase: 2023-12-12
  • Automatic offers:
    • bernhardoj | Contributor | 28044286
    • akinwale | Contributor | 0

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 12, 2023
  2. changed the title [-]IOU-Add a contact to request money and tap back button, contact added to split.[/-] [+][$500] IOU-Add a contact to request money and tap back button, contact added to split.[/+] on Dec 12, 2023
  3. melvin-bot commented on Dec 12, 2023

    @melvin-bot

    Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Dec 12, 2023

    @melvin-bot
  5. melvin-bot commented on Dec 12, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 12, 2023
  7. melvin-bot commented on Dec 12, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

  8. 119 remaining items

  9. melvin-bot commented on Feb 29, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Feb 29, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-07. 🎊

    For reference, here are some details about the assignees on this issue:

  11. melvin-bot commented on Feb 29, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
    • [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@akinwale] Determine if we should create a regression test for this bug.
    • [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  12. MitchExpensify commented on Mar 2, 2024

    @MitchExpensify
    Contributor

    Reminder set to pay

  13. changed the title [-][HOLD for payment 2024-03-07] [$500] IOU-Add a contact to request money and tap back button, contact added to split.[/-] [+][HOLD for payment 2024-03-07] [LOW] [P2P] [$500] IOU-Add a contact to request money and tap back button, contact added to split.[/+] on Mar 4, 2024
  14. tgolen commented on Mar 7, 2024

    @tgolen
    Contributor

    @MitchExpensify Can you please ensure that @situchan gets paid for a C+ review of #32948

  15. MitchExpensify commented on Mar 9, 2024

    @MitchExpensify
    Contributor

    Payment summary:

    C+: $500 @bernhardoj (Upwork)
    C: $500 @akinwale (Upwork)

    Paid and contracts ended

  16. MitchExpensify commented on Mar 19, 2024

    @MitchExpensify
    Contributor

    I mistook my payment to Bernhard for a payment to Situ - Very sorry for that slip up @situchan. To correct it I have sent you an offer here https://www.upwork.com/nx/wm/offer/101471671

  17. situchan commented on Mar 19, 2024

    @situchan
    Contributor

    Accepted thanks

  18. MitchExpensify commented on Mar 19, 2024

    @MitchExpensify
    Contributor

    Paid and contract ended, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions