You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-02] [$500] IOU -Admin is unable to add receipt on Employee's expense request but the placeholder displayed #32923
Version Number: 1.4.11-1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Log in as the employee
Navigate to a expense request conversation that has a receipt
Click on the receipt thumbnail
Click on Delete Receipt from 3 dot menu on the top right
Log in as admin
Navigate to the expense from Step 2
Click on "+" button from deleted receipt ( click once and click few times)
Expected Result:
Since placeholder shows up, admin should be able to add receipt
Actual Result:
Admin is unable to add receipt on Employee's expense request but the placeholder still shows up.
Clicking on it fast enough will redirect admin to report page.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Web- IOU -Admin is unable to add receipt on Employee's expense request but the placeholder displayed[/-][+][$500] Web- IOU -Admin is unable to add receipt on Employee's expense request but the placeholder displayed[/+]on Dec 12, 2023
changed the title [-][$500] Web- IOU -Admin is unable to add receipt on Employee's expense request but the placeholder displayed[/-][+][$500] IOU -Admin is unable to add receipt on Employee's expense request but the placeholder displayed[/+]on Dec 12, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@sobitneupane] Determine if we should create a regression test for this bug.
[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
@sobitneupane $500 for C+ review / Requires payment through NewDot Manual Requests. @bernhardoj, $500 for fixing the issue. Payment processed in Upwork.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
It was missed during the testing of linked PR.
[@sobitneupane] Determine if we should create a regression test for this bug.
Yes.
[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
[-]Web- IOU -Admin is unable to add receipt on Employee's expense request but the placeholder displayed[/-][+][$500] Web- IOU -Admin is unable to add receipt on Employee's expense request but the placeholder displayed[/+]melvin-bot commentedon Dec 12, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01a1dbb186e5ac4d8c
melvin-bot commentedon Dec 12, 2023
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Dec 12, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Dec 12, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)[-][$500] Web- IOU -Admin is unable to add receipt on Employee's expense request but the placeholder displayed[/-][+][$500] IOU -Admin is unable to add receipt on Employee's expense request but the placeholder displayed[/+]bernhardoj commentedon Dec 12, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
The empty receipt placeholder is shown for admin but pressing it do nothing.
What is the root cause of that problem?
We recently (last month) updated the app to prevent the admin from being able to update the receipt in this PR.
If it's unable to edit, we will dismiss immediately the edit page.
App/src/pages/EditRequestPage.js
Lines 114 to 117 in 5632233
We already have a logic to not show the empty receipt placeholder if the user shouldn't be able to edit it.
App/src/components/ReportActionItem/MoneyRequestView.js
Lines 195 to 200 in 5632233
But
canEditrefers to the ability of the user to edit the request as a whole, not a specific field.What changes do you think we should make in order to solve the problem?
We should update the condition to not show the empty receipt placeholder if the user/admin can't edit/add the receipt.
(the above condition is taken from EditRequestPage)
App/src/pages/EditRequestPage.js
Lines 110 to 112 in 5632233
isabelastisser commentedon Dec 14, 2023
@sobitneupane can you please review the proposal above? Thanks!
isabelastisser commentedon Dec 15, 2023
Bump @sobitneupane for urgency. Thanks!
17 remaining items
melvin-bot commentedon Dec 26, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
isabelastisser commentedon Jan 2, 2024
Payment summary:
@sobitneupane $500 for C+ review / Requires payment through NewDot Manual Requests.
@bernhardoj, $500 for fixing the issue. Payment processed in Upwork.
isabelastisser commentedon Jan 2, 2024
@sobitneupane Please complete the checklist so I can close this issue. Thanks!
isabelastisser commentedon Jan 3, 2024
Bump @sobitneupane
isabelastisser commentedon Jan 5, 2024
@sobitneupane, please provide an update!
sobitneupane commentedon Jan 5, 2024
#31024
#31024 (comment)
It was missed during the testing of linked PR.
Yes.
#32923 (comment)
sobitneupane commentedon Jan 5, 2024
Regression Test Proposal:
Do we agree 👍 or 👎
isabelastisser commentedon Jan 5, 2024
https://github.com/Expensify/Expensify/issues/357292
isabelastisser commentedon Jan 5, 2024
All set!
JmillsExpensify commentedon Feb 14, 2024
$500 approved for @sobitneupane based on this comment.