You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-17] [$500] Chat - Send money text displayed in workspace chat #33003
Version Number: v1.4.12-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal team Slack conversation:
Action Performed:
Open the app
Open any workspace chat and scroll on top
Observe the text 'You can also use the + button to send money, request money, or assign a task!' has send money even though send money is not possible to workspace chat
Confirm the options by clicking on plus besides compose box and observe that it does not have 'send money' option
Expected Result:
App should not display 'Send money' text in workspace chat as send money to workspace is not possible
Actual Result:
App displays 'Send money' text in workspace chat even though send money to workspace is not possible
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Chat - Send money text displayed in workspace chat[/-][+][$500] Chat - Send money text displayed in workspace chat[/+]on Dec 13, 2023
What changes do you think we should make in order to solve the problem?
We need to add another text for workspace chats, which doesn't mention sending money. Then decide which text to render based on which money request options we have available
usePlusButton: ({options}: {options: string[]}) => {
const actions = options.map((item: string) => `${item} money`).join(', '); // We can move this logic inside ReportWelcomeText and pass only additional text instead options
const additionalText = actions ? `${actions}, or` : '';
return `\n\nYou can also use the + button to ${additionalText} assign a task!`;
},
Plus It's strange that we ignore the split option. I think we also need to enable this option for showing in translate
What alternative solutions did you explore? (Optional)
As alternative we can create translate for every case
And depending on the availability of a particular button, show the translation
I like @ZhenjaHorbach's proposal but better to go with We can move this logic inside ReportWelcomeText and pass only additional text instead options as suggested in the comment.
🎀👀🎀 C+ reviewed
changed the title [-][$500] Chat - Send money text displayed in workspace chat[/-][+][HOLD for payment 2024-01-17] [$500] Chat - Send money text displayed in workspace chat[/+]on Jan 10, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
[@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Ollyws] Determine if we should create a regression test for this bug.
[@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The PR that introduced the bug has been identified. Link to the PR:
We've been using a static message for this since it was implemented so I don't think we can really pin it on a PR, it's more of a new feature.
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
N/A
Determine if we should create a regression test for this bug.
Yes.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
1. Open the app
2. Open any workspace chat and scroll on top
3. Observe the text 'You can also use the + button to send money, request money, or assign a task!' has synchronized with available money options in + menu
Activity
[-]Chat - Send money text displayed in workspace chat[/-][+][$500] Chat - Send money text displayed in workspace chat[/+]melvin-bot commentedon Dec 13, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0184e5f006c16a747a
melvin-bot commentedon Dec 13, 2023
Triggered auto assignment to @miljakljajic (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Dec 13, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Dec 13, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)Berndy commentedon Dec 13, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
The displayed text mentions being able to send money, despite this not being the case in workspace chats.
What is the root cause of that problem?
We check if money request options contain send OR request to decide whether we display the text or not.
App/src/components/ReportWelcomeText.js
Lines 133 to 135 in 904cf56
What changes do you think we should make in order to solve the problem?
We need to add another text for workspace chats, which doesn't mention sending money. Then decide which text to render based on which money request options we have available
App/src/languages/en.ts
Line 467 in 904cf56
App/src/languages/es.ts
Line 460 in 904cf56
I suggest we add
usePlusButtonWorkspace, then display the current text only if we cansendandrequest, or the workspace text if we can onlyrequest.What alternative solutions did you explore? (Optional)
ZhenjaHorbach commentedon Dec 13, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Chat - Send money text displayed in workspace chat
What is the root cause of that problem?
We have static text for usePlusButton
What changes do you think we should make in order to solve the problem?
To fix this we can synchronize with the available buttons we have in the AttachmentPicker
App/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.js
Lines 141 to 143 in 904cf56
For this, we can use logic from AttachmentPicker and get a list of available moneyRequestOptions
App/src/components/ReportWelcomeText.js
Line 73 in 3df907c
And then update
usePlusButtontranslate to be able to pass custom properties (App/src/components/ReportWelcomeText.js
Line 134 in 904cf56
Plus It's strange that we ignore the split option. I think we also need to enable this option for showing in translate
What alternative solutions did you explore? (Optional)
As alternative we can create translate for every case
And depending on the availability of a particular button, show the translation
yh-0218 commentedon Dec 13, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Chat - Send money text displayed in workspace chat
What is the root cause of that problem?
Because we use static text here
App/src/components/ReportWelcomeText.js
Line 134 in 2782381
What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)
Screen.Recording.2023-12-13.at.10.50.02.PM.mov
Ollyws commentedon Dec 17, 2023
I like @ZhenjaHorbach's proposal but better to go with
We can move this logic inside ReportWelcomeText and pass only additional text instead optionsas suggested in the comment.🎀👀🎀 C+ reviewed
24 remaining items
[-][$500] Chat - Send money text displayed in workspace chat[/-][+][HOLD for payment 2024-01-17] [$500] Chat - Send money text displayed in workspace chat[/+]melvin-bot commentedon Jan 10, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 10, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-17. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 10, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
miljakljajic commentedon Jan 17, 2024
@Ollyws can you accept the offer? @ZhenjaHorbach , paid!
Ollyws commentedon Jan 17, 2024
BugZero Checklist:
We've been using a static message for this since it was implemented so I don't think we can really pin it on a PR, it's more of a new feature.
N/A
N/A
Yes.
Regression Test Proposal
Do we agree 👍 or 👎