You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🐛 - App is still in dark mode when device dark mode is off #33101
Version Number: 1.4.13.0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Precondition:
Device dark mode is on
App dark mode settings is set to "Use device settings"
Launch New Expensify app
Turn off dark mode
Expected Result:
App will switch to light mode
Actual Result:
The app is still in dark mode, even after relaunching the app
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
📣 @artus9033! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
It is important to note that remote debugging should be turned off, as when on it will always return "light". To turn on or off remote debugging type "d" on metro to open the menu on your device and then turn on/off remote debugging.
changed the title [-][HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🐛 - App is still in dark mode when device dark mode is off[/-][+][$500] [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🐛 - App is still in dark mode when device dark mode is off[/+]on Jan 5, 2024
Activity
github-actions commentedon Dec 14, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 14, 2023
Triggered auto assignment to @aldo-expensify (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.melvin-bot commentedon Dec 14, 2023
📣 @artus9033! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
aldo-expensify commentedon Dec 14, 2023
cc @grgia since you are the Theme expert I believe
aldo-expensify commentedon Dec 14, 2023
This worked fine for me in Macos / Web. I'll try to test in Android
aldo-expensify commentedon Dec 14, 2023
Reproduced in Android
grgia commentedon Dec 14, 2023
Yes I believe we are hard coding this, I'm looking into it right now
aldo-expensify commentedon Dec 14, 2023
Thanks, meanwhile I'm trying to install the latest version in the emulator to start debugging
grgia commentedon Dec 14, 2023
#33090 here's some more context, but the PR up is not the full picture it still defaults to one theme currently
grgia commentedon Dec 14, 2023
https://github.com/Expensify/App/pull/13874/files#diff-bc1549da6355f7f82f324af9c667b78ff60672b6b80219062629fe4184e8fa93R69-R70
Gonna test reverting these
grgia commentedon Dec 14, 2023
34 remaining items
melvin-bot commentedon Jan 1, 2024
@michaelhaxhiu, @grgia, @situchan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
grgia commentedon Jan 2, 2024
@michaelhaxhiu I think this one is just waiting on C+ review payment
michaelhaxhiu commentedon Jan 5, 2024
Looking!
[-][HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🐛 - App is still in dark mode when device dark mode is off[/-][+][$500] [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🐛 - App is still in dark mode when device dark mode is off[/+]melvin-bot commentedon Jan 5, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01325de77e255acbec
melvin-bot commentedon Jan 5, 2024
Current assignee @situchan is eligible for the External assigner, not assigning anyone new.
michaelhaxhiu commentedon Jan 5, 2024
Offer sent - waiting to pay!
michaelhaxhiu commentedon Jan 5, 2024
Done!