Skip to content

[$500] [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🐛 - App is still in dark mode when device dark mode is off #33101

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.13.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

  • Device dark mode is on
  • App dark mode settings is set to "Use device settings"
  1. Launch New Expensify app
  2. Turn off dark mode

Expected Result:

App will switch to light mode

Actual Result:

The app is still in dark mode, even after relaunching the app

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6313358_1702574205482.Screen_Recording_20231214_235326_New_Expensify__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01325de77e255acbec
  • Upwork Job ID: 1743285192238567424
  • Last Price Increase: 2024-01-05

Activity

  1. github-actions commented on Dec 14, 2023

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Dec 14, 2023

    @melvin-bot

    Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. melvin-bot commented on Dec 14, 2023

    @melvin-bot

    📣 @artus9033! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  4. aldo-expensify commented on Dec 14, 2023

    @aldo-expensify
    Contributor

    cc @grgia since you are the Theme expert I believe

  5. aldo-expensify commented on Dec 14, 2023

    @aldo-expensify
    Contributor

    This worked fine for me in Macos / Web. I'll try to test in Android

  6. aldo-expensify commented on Dec 14, 2023

    @aldo-expensify
    Contributor

    Reproduced in Android

  7. grgia commented on Dec 14, 2023

    @grgia
    Contributor

    Yes I believe we are hard coding this, I'm looking into it right now

  8. aldo-expensify commented on Dec 14, 2023

    @aldo-expensify
    Contributor

    Yes I believe we are hard coding this, I'm looking into it right now

    Thanks, meanwhile I'm trying to install the latest version in the emulator to start debugging

  9. grgia commented on Dec 14, 2023

    @grgia
    Contributor

    #33090 here's some more context, but the PR up is not the full picture it still defaults to one theme currently

  10. grgia commented on Dec 14, 2023

    @grgia
    Contributor

    It is important to note that remote debugging should be turned off, as when on it will always return "light". To turn on or off remote debugging type "d" on metro to open the menu on your device and then turn on/off remote debugging.

  11. 34 remaining items

  12. melvin-bot commented on Jan 1, 2024

    @melvin-bot

    @michaelhaxhiu, @grgia, @situchan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  13. grgia commented on Jan 2, 2024

    @grgia
    Contributor

    @michaelhaxhiu I think this one is just waiting on C+ review payment

  14. michaelhaxhiu commented on Jan 5, 2024

    @michaelhaxhiu
    Contributor

    Looking!

  15. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jan 5, 2024
  16. changed the title [-][HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🐛 - App is still in dark mode when device dark mode is off[/-] [+][$500] [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🐛 - App is still in dark mode when device dark mode is off[/+] on Jan 5, 2024
  17. melvin-bot commented on Jan 5, 2024

    @melvin-bot
  18. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 5, 2024
  19. removed
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 5, 2024
  20. melvin-bot commented on Jan 5, 2024

    @melvin-bot

    Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

  21. michaelhaxhiu commented on Jan 5, 2024

    @michaelhaxhiu
    Contributor

    Offer sent - waiting to pay!

  22. michaelhaxhiu commented on Jan 5, 2024

    @michaelhaxhiu
    Contributor

    Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringNewFeatureSomething to build that is a new item.

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions