Skip to content

[HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] Theme - "Join the discussion" is illegible and inconsistency in sign-in modal theme in public room #33159

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.13-4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: Device is in light mode.

  1. Log out.
  2. Go to a public room (eg: https://staging.new.expensify.com/r/5408450846930023).
  3. Click Sign in.

Expected Result:

  • Content will be legible.
  • The sign-in component will be displayed entirely in dark mode because sign-in interface will always be in dark mode.

Actual Result:

  • "Join the discussion" sentence is not legible because the font is white on a white background.
  • The header on sign-in modal is in light mode, while the rest is in dark mode.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image

image

Bug6314522_1702644336712.20231215_185917.mp4

View all open jobs on GitHub

Activity

  1. github-actions commented on Dec 15, 2023

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Dec 15, 2023

    @melvin-bot

    Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. amyevans commented on Dec 15, 2023

    @amyevans
    Contributor

    👋 @grgia @chrispader Got a new one for you here! 🙇‍♀️

  4. assigned and unassigned on Dec 15, 2023
  5. chrispader commented on Dec 15, 2023

    @chrispader
    Contributor

    working on it! :)

  6. abzokhattab commented on Dec 15, 2023

    @abzokhattab
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The sign in modal in public rooms is always dark

    What is the root cause of that problem?

    The theme provider in the login page is fixed to the dark mode:

    return (
    <ThemeProvider theme={CONST.THEME.DARK}>
    <ThemeStylesProvider>
    <ColorSchemeWrapper>
    <CustomStatusBarAndBackground isNested />
    <SignInPageInner
    // eslint-disable-next-line react/jsx-props-no-spreading
    {...props}
    />
    </ColorSchemeWrapper>
    </ThemeStylesProvider>
    </ThemeProvider>

    What changes do you think we should make in order to solve the problem?

    We need to add a prop useDarkTheme and the default is truein the SignInModal we should set this prop as false
    So if the value is false it will use the theme provider without the custom theme.

    <SignInPage isInModal />

  7. situchan commented on Dec 15, 2023

    @situchan
    Contributor

    @abzokhattab have you tested your proposal? After applying your solution, it looks more ugly.
    We should use fixed dark theme for signin page for now.

    Screenshot 2023-12-15

    What we should fix here is just header color:
    Screenshot 2023-12-15

  8. ishpaul777 commented on Dec 15, 2023

    @ishpaul777
    Contributor

    is this issue open for proposals ?

  9. 24 remaining items

  10. melvin-bot commented on Jan 1, 2024

    @melvin-bot

    @chrispader, @grgia Still overdue 6 days?! Let's take care of this!

  11. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 2, 2024
  12. melvin-bot commented on Jan 2, 2024

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  13. melvin-bot commented on Jan 2, 2024

    @melvin-bot
  14. grgia commented on Jan 2, 2024

    @grgia
    Contributor

    @sonialiap would you mind helping to ensure that @shubham1206agra receives $500 C+ review payment for #33181

  15. sonialiap commented on Jan 3, 2024

    @sonialiap
    Contributor
  16. shubham1206agra commented on Jan 3, 2024

    @shubham1206agra
    Contributor

    Accepted

  17. sonialiap commented on Jan 4, 2024

    @sonialiap
    Contributor

    Paid ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions