You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] Theme - "Join the discussion" is illegible and inconsistency in sign-in modal theme in public room #33159
Version Number: v1.4.13-4 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
What changes do you think we should make in order to solve the problem?
We need to add a prop useDarkTheme and the default is truein the SignInModal we should set this prop as false
So if the value is false it will use the theme provider without the custom theme.
Activity
github-actions commentedon Dec 15, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 15, 2023
Triggered auto assignment to @amyevans (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.amyevans commentedon Dec 15, 2023
👋 @grgia @chrispader Got a new one for you here! 🙇♀️
chrispader commentedon Dec 15, 2023
working on it! :)
abzokhattab commentedon Dec 15, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
The sign in modal in public rooms is always dark
What is the root cause of that problem?
The theme provider in the login page is fixed to the dark mode:
App/src/pages/signin/SignInPage.js
Lines 287 to 298 in 802095e
What changes do you think we should make in order to solve the problem?
We need to add a prop
useDarkThemeand the default istruein theSignInModalwe should set this prop as falseSo if the value is false it will use the theme provider without the custom theme.
App/src/pages/signin/SignInModal.js
Line 29 in addfa88
situchan commentedon Dec 15, 2023
@abzokhattab have you tested your proposal? After applying your solution, it looks more ugly.
We should use fixed dark theme for signin page for now.
What we should fix here is just header color:

ishpaul777 commentedon Dec 15, 2023
is this issue open for proposals ?
24 remaining items
melvin-bot commentedon Jan 1, 2024
@chrispader, @grgia Still overdue 6 days?! Let's take care of this!
melvin-bot commentedon Jan 2, 2024
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jan 2, 2024
grgia commentedon Jan 2, 2024
@sonialiap would you mind helping to ensure that @shubham1206agra receives $500 C+ review payment for #33181
sonialiap commentedon Jan 3, 2024
@shubham1206agra $500 offer sent
Upwork job post
shubham1206agra commentedon Jan 3, 2024
Accepted
sonialiap commentedon Jan 4, 2024
Paid ✔️