Skip to content

[HOLD for payment 2023-12-29] Fix require cycle from clearReportNotifications.ts #33204

Closed

Description

@arosiclair

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: N/A
Reproducible in staging?: N/A
Reproducible in production?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: N/A
Expensify/Expensify Issue URL:
Issue reported by: @arosiclair
Slack conversation: N/A

Action Performed:

Run NewDot in dev on Android/iOS

Expected Result:

No warnings about require cycles appear in logs

Actual Result:

 WARN  Require cycle: src/libs/actions/Report.ts -> src/libs/Notification/clearReportNotifications/index.native.ts -> src/libs/Notification/PushNotification/index.native.ts -> src/libs/Notification/PushNotification/ForegroundNotifications/index.ios.ts -> src/libs/Notification/PushNotification/shouldShowPushNotification.ts -> src/libs/actions/Report.ts

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Screenshot 2023-12-17 at 11 08 51 AM

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012e8796edd86cd329
  • Upwork Job ID: 1736418796306968576
  • Last Price Increase: 2023-12-17

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 17, 2023
  2. self-assigned this
    on Dec 17, 2023
  3. melvin-bot commented on Dec 17, 2023

    @melvin-bot
  4. melvin-bot commented on Dec 17, 2023

    @melvin-bot

    Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. melvin-bot commented on Dec 17, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. melvin-bot commented on Dec 17, 2023

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

  7. arosiclair commented on Dec 17, 2023

    @arosiclair
    ContributorAuthor

    @conorpendergrast no triage needed for this atm. This is a dev issue.

  8. added
    ReviewingHas a PR in review
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Dec 18, 2023
  9. changed the title [-]Fix require cycle from clearReportNotifications.ts[/-] [+][HOLD for payment 2023-12-29] Fix require cycle from clearReportNotifications.ts[/+] on Dec 22, 2023
  10. melvin-bot commented on Dec 22, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Dec 22, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.15-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-12-29. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    • @s77rt requires payment (Needs manual offer from BZ)
  12. melvin-bot commented on Dec 22, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
    • [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@s77rt] Determine if we should create a regression test for this bug.
    • [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. s77rt commented on Dec 22, 2023

    @s77rt
    Member
    • The PR that introduced the bug has been identified: Clear notifications after opening a report #31762
    • The offending PR has been commented on: Not needed since I reviewed the offending PR
    • A discussion in #expensify-bugs has been started: Not needed
    • Determine if we should create a regression test for this bug: No
  14. melvin-bot commented on Dec 29, 2023

    @melvin-bot
    ### Payment Summary
    [Upwork Job](https://www.upwork.com/jobs/~012e8796edd86cd329)
    - <Role>: @s77rt paid $(<amount>) via Upwork (<Replace with offer link>)
    
    #### BugZero Checklist (@conorpendergrast)
    - [ ] I have verified the correct assignees and roles are listed above
    - [ ] I have verified that there are no duplicate or incorrect contracts on Upwork (https://www.upwork.com/ab/applicants/1736418796306968576/hired)
    - [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
    - [ ] I have verified the payment summary above is correct
    
  15. arosiclair commented on Dec 29, 2023

    @arosiclair
    ContributorAuthor

    This was just a follow up to this PR for an issue we missed. I implemented both and the same C+ (@s77rt) reviewed so this shouldn't need any extra payment. Closing this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions