You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-12-29] Fix require cycle from clearReportNotifications.ts #33204
Version Number: N/A Reproducible in staging?: N/A Reproducible in production?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: N/A Expensify/Expensify Issue URL: Issue reported by:@arosiclair Slack conversation: N/A
changed the title [-]Fix require cycle from clearReportNotifications.ts[/-][+][HOLD for payment 2023-12-29] Fix require cycle from clearReportNotifications.ts[/+]on Dec 22, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.15-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-29. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@s77rt requires payment (Needs manual offer from BZ)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt] Determine if we should create a regression test for this bug.
[@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
### Payment Summary
[Upwork Job](https://www.upwork.com/jobs/~012e8796edd86cd329)
- <Role>: @s77rt paid $(<amount>) via Upwork (<Replace with offer link>)
#### BugZero Checklist (@conorpendergrast)
- [ ] I have verified the correct assignees and roles are listed above
- [ ] I have verified that there are no duplicate or incorrect contracts on Upwork (https://www.upwork.com/ab/applicants/1736418796306968576/hired)
- [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
- [ ] I have verified the payment summary above is correct
This was just a follow up to this PR for an issue we missed. I implemented both and the same C+ (@s77rt) reviewed so this shouldn't need any extra payment. Closing this out
Activity
melvin-bot commentedon Dec 17, 2023
Job added to Upwork: https://www.upwork.com/jobs/~012e8796edd86cd329
melvin-bot commentedon Dec 17, 2023
Triggered auto assignment to @conorpendergrast (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Dec 17, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Dec 17, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (
Internal)arosiclair commentedon Dec 17, 2023
@conorpendergrast no triage needed for this atm. This is a dev issue.
[-]Fix require cycle from clearReportNotifications.ts[/-][+][HOLD for payment 2023-12-29] Fix require cycle from clearReportNotifications.ts[/+]melvin-bot commentedon Dec 22, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 22, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.15-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-29. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 22, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
s77rt commentedon Dec 22, 2023
melvin-bot commentedon Dec 29, 2023
arosiclair commentedon Dec 29, 2023
This was just a follow up to this PR for an issue we missed. I implemented both and the same C+ (@s77rt) reviewed so this shouldn't need any extra payment. Closing this out