You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Sign In - "STG" label displayed on the right side against "Expensify" label on Sign In page #33283
Version Number: 1.4.14-0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Observe the "STG" label position against "Expensify" label
Sign In to the app
Repeat step 2
Expected Result:
The "STG" label position against "Expensify" label should be the same on Sign In and LHN pages
Actual Result:
The "STG" label displays on the right side against "Expensify" label on Sign In page and "STG" label moved to the right against "Expensify" on the LHN page (it looks like a new design/feature on LHN page)
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Hmm but that being said, I'm not a huge fan of the placement of this label. I bet we can tuck it into the negative space by the y's tail somewhere? cc @Expensify/design
Please re-state the problem that we are trying to solve in this issue.
Header badge isn't in the correct place
What is the root cause of that problem?
Badge isn't set with the title View and absolute values aren't correct.
What changes do you think we should make in order to solve the problem?
We can move badge inside the adjacent View of the title so it will take the correct width to set its absolute position and make changes to bottom and right property values.
@shawnborton I think we should wait for the full ideal nav to be implemented. and I agreee that this is not up for proposals @MaciejSWM will handle this once we decide.
Why I think its not that important is that this badge exists only in staging or dev so no real customers will ever face this so we can take our time
Activity
github-actions commentedon Dec 19, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 19, 2023
Triggered auto assignment to @Julesssss (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.paultsimura commentedon Dec 19, 2023
According to this PR, this is expected: #32221
@shawnborton @mountiny could you please confirm/reject?
aimane-chnaif commentedon Dec 19, 2023
This is new design. Let's close!
shawnborton commentedon Dec 19, 2023
Hmm but that being said, I'm not a huge fan of the placement of this label. I bet we can tuck it into the negative space by the y's tail somewhere? cc @Expensify/design
melvin-bot commentedon Dec 19, 2023
Triggered auto assignment to @shawnborton (
Design), see these Stack Overflow questions for more details.shawnborton commentedon Dec 19, 2023
Not a deploy blocker but I think we should make some updates to this one.
Pujan92 commentedon Dec 19, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Header badge isn't in the correct place
What is the root cause of that problem?
Badge isn't set with the title View and absolute values aren't correct.
What changes do you think we should make in order to solve the problem?
We can move badge inside the adjacent View of the title so it will take the correct width to set its absolute position and make changes to bottom and right property values.
App/src/components/Header.tsx
Lines 46 to 48 in aa1d87c
App/src/styles/index.ts
Lines 3598 to 3599 in aa1d87c
aimane-chnaif commentedon Dec 19, 2023
This is not open for proposals.
@MaciejSWM and me will be handling this
dannymcclain commentedon Dec 19, 2023
@shawnborton I don't really have super strong feelings about this—totally open to any ideas you have!
mountiny commentedon Dec 20, 2023
@shawnborton I think we should wait for the full ideal nav to be implemented. and I agreee that this is not up for proposals @MaciejSWM will handle this once we decide.
Why I think its not that important is that this badge exists only in staging or dev so no real customers will ever face this so we can take our time
Julesssss commentedon Dec 21, 2023
Closing based on this comment. please reopen if anyone disagrees