You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-03] [HOLD for payment 2024-01-02] The new search component is slower and animation to open it isn’t smooth #33326
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@deetergp it seems the PR you linked only adds a new Search component to the storybook, and not the actual app, so I'm doubtful as to whether that is the cause.
changed the title [-]The new search component is slower and animation to open it isn’t smooth[/-][+][HOLD for payment 2024-01-02] The new search component is slower and animation to open it isn’t smooth[/+]on Dec 26, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.16-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-02. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mountiny] The PR that introduced the bug has been identified. Link to the PR:
[@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mountiny] Determine if we should create a regression test for this bug.
[@mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2024-01-02] The new search component is slower and animation to open it isn’t smooth[/-][+][HOLD for payment 2024-01-03] [HOLD for payment 2024-01-02] The new search component is slower and animation to open it isn’t smooth[/+]on Dec 27, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.17-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-03. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mountiny] The PR that introduced the bug has been identified. Link to the PR:
[@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mountiny] Determine if we should create a regression test for this bug.
[@mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Dec 19, 2023
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Dec 19, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)github-actions commentedon Dec 19, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 19, 2023
Triggered auto assignment to @deetergp (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.deetergp commentedon Dec 20, 2023
It seems very likely that the new Search Input Component is the culprit https://github.com/Expensify/App/pull/32439/files
jasperhuangg commentedon Dec 20, 2023
@deetergp it seems the PR you linked only adds a new Search component to the storybook, and not the actual app, so I'm doubtful as to whether that is the cause.
jasperhuangg commentedon Dec 20, 2023
I suspect #33218 is related, since it has to do with the animation of opening the left hand search pane.
34 remaining items
[-]The new search component is slower and animation to open it isn’t smooth[/-][+][HOLD for payment 2024-01-02] The new search component is slower and animation to open it isn’t smooth[/+]melvin-bot commentedon Dec 26, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 26, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.16-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-02. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
melvin-bot commentedon Dec 26, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2024-01-02] The new search component is slower and animation to open it isn’t smooth[/-][+][HOLD for payment 2024-01-03] [HOLD for payment 2024-01-02] The new search component is slower and animation to open it isn’t smooth[/+]melvin-bot commentedon Dec 27, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.17-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-03. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
melvin-bot commentedon Dec 27, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mountiny commentedon Dec 27, 2023
This can be closed now I think