You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-12-29] [$500] Android - Attachment - Application crashes when trying to scroll PDF preview #33357
Version Number: 1.4.14-2 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.15-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-29. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@aimane-chnaif requires payment (Needs manual offer from BZ)
@mkhutornyi requires payment (Needs manual offer from BZ)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@aimane-chnaif] Determine if we should create a regression test for this bug.
[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
github-actions commentedon Dec 20, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 20, 2023
Triggered auto assignment to @srikarparsi (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.mkhutornyi commentedon Dec 20, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Android app crashes when scroll PDF in preview
What is the root cause of that problem?
Crash log:
ERROR ReanimatedError: Cannot read property 'shouldPagerScroll' of null, js engine: reanimatedSo it happens on this line:
attachmentCarouselPagerContext.shouldPagerScroll.value =(attachmentCarouselPagerContext is null)App/src/components/Attachments/AttachmentView/AttachmentViewPdf/index.android.js
Lines 21 to 29 in f33d674
What changes do you think we should make in order to solve the problem?
add null safety check
if (offsetX.value !== 0 && offsetY.value !== 0 && attachmentCarouselPagerContext) {srikarparsi commentedon Dec 20, 2023
Hey @mkhutornyi, are you available to work on this fix?
mkhutornyi commentedon Dec 20, 2023
yes, I am
srikarparsi commentedon Dec 20, 2023
Awesome, assigning you to the issue, can you create a PR and link it here?
mkhutornyi commentedon Dec 20, 2023
@srikarparsi PR is ready
19 remaining items
melvin-bot commentedon Dec 22, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.15-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-29. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 22, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Dec 29, 2023
Payment Summary
Upwork Job
BugZero Checklist (@muttmuure)
melvin-bot commentedon Jan 2, 2024
@muttmuure, @srikarparsi, @aimane-chnaif, @mkhutornyi Eep! 4 days overdue now. Issues have feelings too...
muttmuure commentedon Jan 2, 2024
Manual offers sent
muttmuure commentedon Jan 5, 2024
All paid up