Skip to content

[HOLD for payment 2023-12-29] [$500] Android - Attachment - Application crashes when trying to scroll PDF preview #33357

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.14-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Prerequisites:
File for example https://drive.google.com/file/d/1a_8roG0lxsaBAWAo33pLSs8pAfN2nCY9/view?usp=drive_link
Steps:

  1. Open New Expensify app
  2. Log in under any account
  3. Navigate to any conversation
  4. Click on Compose Box - Add attachment
  5. Add the PDF file from the example
  6. Scroll PDF file in preview

Expected Result:

The application should not crash when you try to scroll through the PDF preview.

Actual Result:

Application crashes when trying to scroll PDF preview

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6321235_1703078349555.Record_2023-12-20-19-01-18.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d227608e2ee7d100
  • Upwork Job ID: 1737627480242479104
  • Last Price Increase: 2023-12-21

Activity

  1. github-actions commented on Dec 20, 2023

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Dec 20, 2023

    @melvin-bot

    Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. mkhutornyi commented on Dec 20, 2023

    @mkhutornyi
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Android app crashes when scroll PDF in preview

    What is the root cause of that problem?

    Crash log:
    ERROR ReanimatedError: Cannot read property 'shouldPagerScroll' of null, js engine: reanimated

    So it happens on this line: attachmentCarouselPagerContext.shouldPagerScroll.value = (attachmentCarouselPagerContext is null)

    if (offsetX.value !== 0 && offsetY.value !== 0) {
    // if the value of X is greater than Y and the pdf is not zoomed in,
    // enable the pager scroll so that the user
    // can swipe to the next attachment otherwise disable it.
    if (Math.abs(evt.allTouches[0].absoluteX - offsetX.value) > Math.abs(evt.allTouches[0].absoluteY - offsetY.value) && scaleRef.value === 1) {
    attachmentCarouselPagerContext.shouldPagerScroll.value = true;
    } else {
    attachmentCarouselPagerContext.shouldPagerScroll.value = false;
    }

    What changes do you think we should make in order to solve the problem?

    add null safety check
    if (offsetX.value !== 0 && offsetY.value !== 0 && attachmentCarouselPagerContext) {

  4. srikarparsi commented on Dec 20, 2023

    @srikarparsi
    Contributor

    Hey @mkhutornyi, are you available to work on this fix?

  5. mkhutornyi commented on Dec 20, 2023

    @mkhutornyi
    Contributor

    yes, I am

  6. srikarparsi commented on Dec 20, 2023

    @srikarparsi
    Contributor

    Awesome, assigning you to the issue, can you create a PR and link it here?

  7. mkhutornyi commented on Dec 20, 2023

    @mkhutornyi
    Contributor

    @srikarparsi PR is ready

  8. 19 remaining items

  9. melvin-bot commented on Dec 22, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.15-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-12-29. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

  10. melvin-bot commented on Dec 22, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
    • [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@aimane-chnaif] Determine if we should create a regression test for this bug.
    • [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  11. melvin-bot commented on Dec 29, 2023

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@muttmuure)

    • I have verified the correct assignees and roles are listed above
    • I have verified that there are no duplicate or incorrect contracts on Upwork (https://www.upwork.com/ab/applicants/1737627480242479104/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. melvin-bot commented on Jan 2, 2024

    @melvin-bot

    @muttmuure, @srikarparsi, @aimane-chnaif, @mkhutornyi Eep! 4 days overdue now. Issues have feelings too...

  13. muttmuure commented on Jan 2, 2024

    @muttmuure
    Contributor

    Manual offers sent

  14. muttmuure commented on Jan 5, 2024

    @muttmuure
    Contributor

    All paid up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions