You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-12-29] [HOLD for payment 2023-12-28] Scan - "Reply in thread" is not present for IOU preview with ongoing smartscanning #33358
Version Number: v1.4.14-2 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Click FAB > Request money > Manual.
Request money from a user.
In 1:1 DM where the money is requested, right click on the IOU preview.
Click on the IOU preview to open report page and right click on the IOU preview.
Note that "Reply in thread" is present.
Repeat Step 1-4 with a Scan request.
Expected Result:
"Reply in thread" is present for IOU preview with ongoing smart scanning.
Actual Result:
"Reply in thread" is not present for IOU preview with ongoing smart scanning.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
hum.. if it is a whisper action, other users in the conversation won't see it right? I find it strange to be able to start a thread from a whisper since others won't be able to see the parent report action
Does the smartscan preview stop being a whisper once the smartscan process is finished? In such case it would make sense to me that a thread can exist from it because it will become visible for other participants
The PR that introduced the bug has been identified. Link to the PR - it was not a regression - just missing functionality
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment - N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion - N/A
Determine if we should create a regression test for this bug - N/A
Activity
github-actions commentedon Dec 20, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 20, 2023
Triggered auto assignment to @aldo-expensify (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.kbecciv commentedon Dec 20, 2023
Not reproducible on production
bandicam.2023-12-20.16-02-07-482.mp4
dukenv0307 commentedon Dec 20, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
"Reply in thread" is not present for IOU preview with ongoing smart scanning.
What is the root cause of that problem?
We are not allowing reply in thread for whisper action. So when the request is scanning, it's wishper action and then no reply in thread option
App/src/pages/home/report/ContextMenu/ContextMenuActions.js
Line 151 in 9ea6b39
What changes do you think we should make in order to solve the problem?
We should allow reply in thread for IOU action even if it's a whisper
App/src/pages/home/report/ContextMenu/ContextMenuActions.js
Line 151 in 9ea6b39
What alternative solutions did you explore? (Optional)
NA
aldo-expensify commentedon Dec 20, 2023
hum.. if it is a whisper action, other users in the conversation won't see it right? I find it strange to be able to start a thread from a whisper since others won't be able to see the parent report action
aldo-expensify commentedon Dec 20, 2023
Does the smartscan preview stop being a whisper once the smartscan process is finished? In such case it would make sense to me that a thread can exist from it because it will become visible for other participants
aldo-expensify commentedon Dec 20, 2023
From my testing, apparently not.
aldo-expensify commentedon Dec 20, 2023
hmm from the admin's perspective, the admin can see this whisper:
🤯
aldo-expensify commentedon Dec 20, 2023
The "Only visible to you" is a lie then:
dukenv0307 commentedon Dec 20, 2023
@aldo-expensify what is the next step here? Should we fix this issue or it's intendtional.
aldo-expensify commentedon Dec 20, 2023
I'm not sure yet, I'm asking in slack too
40 remaining items
aldo-expensify commentedon Jan 3, 2024
@conorpendergrast is OOO until next week
melvin-bot commentedon Jan 8, 2024
@conorpendergrast, @narefyev91, @aldo-expensify, @dukenv0307 Huh... This is 4 days overdue. Who can take care of this?
conorpendergrast commentedon Jan 8, 2024
I am back from OoO! Offer sent to @dukenv0307
melvin-bot commentedon Jan 12, 2024
@conorpendergrast, @narefyev91, @aldo-expensify, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
conorpendergrast commentedon Jan 12, 2024
@dukenv0307 Bump on accepting the offer please!
dukenv0307 commentedon Jan 15, 2024
@conorpendergrast accepted, thank you!
conorpendergrast commentedon Jan 15, 2024
Paid and contract ended! C+ checklist by @narefyev91 is the last step, please
narefyev91 commentedon Jan 15, 2024
conorpendergrast commentedon Jan 15, 2024
Sounds good, thanks! Closing out, thanks everyone