Skip to content

[HOLD for payment 2023-12-29] [HOLD for payment 2023-12-28] Scan - "Reply in thread" is not present for IOU preview with ongoing smartscanning #33358

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.14-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Click FAB > Request money > Manual.
  2. Request money from a user.
  3. In 1:1 DM where the money is requested, right click on the IOU preview.
  4. Click on the IOU preview to open report page and right click on the IOU preview.
  5. Note that "Reply in thread" is present.
  6. Repeat Step 1-4 with a Scan request.

Expected Result:

"Reply in thread" is present for IOU preview with ongoing smart scanning.

Actual Result:

"Reply in thread" is not present for IOU preview with ongoing smart scanning.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6321251_1703078730828.bandicam_2023-12-20_15-57-05-794.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @narefyev91

Activity

  1. github-actions commented on Dec 20, 2023

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Dec 20, 2023

    @melvin-bot

    Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. kbecciv commented on Dec 20, 2023

    @kbecciv
    Author

    Not reproducible on production

    bandicam.2023-12-20.16-02-07-482.mp4
  4. dukenv0307 commented on Dec 20, 2023

    @dukenv0307
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    "Reply in thread" is not present for IOU preview with ongoing smart scanning.

    What is the root cause of that problem?

    We are not allowing reply in thread for whisper action. So when the request is scanning, it's wishper action and then no reply in thread option

    What changes do you think we should make in order to solve the problem?

    We should allow reply in thread for IOU action even if it's a whisper

    (!isWhisperAction || reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.IOU)
    

    What alternative solutions did you explore? (Optional)

    NA

  5. aldo-expensify commented on Dec 20, 2023

    @aldo-expensify
    Contributor

    hum.. if it is a whisper action, other users in the conversation won't see it right? I find it strange to be able to start a thread from a whisper since others won't be able to see the parent report action

  6. aldo-expensify commented on Dec 20, 2023

    @aldo-expensify
    Contributor

    Does the smartscan preview stop being a whisper once the smartscan process is finished? In such case it would make sense to me that a thread can exist from it because it will become visible for other participants

  7. aldo-expensify commented on Dec 20, 2023

    @aldo-expensify
    Contributor

    Does the smartscan preview stop being a whisper once the smartscan process is finished?

    From my testing, apparently not.

  8. aldo-expensify commented on Dec 20, 2023

    @aldo-expensify
    Contributor

    hmm from the admin's perspective, the admin can see this whisper:

    image

    🤯

  9. aldo-expensify commented on Dec 20, 2023

    @aldo-expensify
    Contributor

    The "Only visible to you" is a lie then:

    image
  10. dukenv0307 commented on Dec 20, 2023

    @dukenv0307
    Contributor

    @aldo-expensify what is the next step here? Should we fix this issue or it's intendtional.

  11. aldo-expensify commented on Dec 20, 2023

    @aldo-expensify
    Contributor

    @aldo-expensify what is the next step here? Should we fix this issue or it's intendtional.

    I'm not sure yet, I'm asking in slack too

  12. 40 remaining items

  13. aldo-expensify commented on Jan 3, 2024

    @aldo-expensify
    Contributor

    @conorpendergrast is OOO until next week

  14. melvin-bot commented on Jan 8, 2024

    @melvin-bot

    @conorpendergrast, @narefyev91, @aldo-expensify, @dukenv0307 Huh... This is 4 days overdue. Who can take care of this?

  15. conorpendergrast commented on Jan 8, 2024

    @conorpendergrast
    Contributor

    I am back from OoO! Offer sent to @dukenv0307

  16. melvin-bot commented on Jan 12, 2024

    @melvin-bot

    @conorpendergrast, @narefyev91, @aldo-expensify, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  17. conorpendergrast commented on Jan 12, 2024

    @conorpendergrast
    Contributor

    @dukenv0307 Bump on accepting the offer please!

  18. dukenv0307 commented on Jan 15, 2024

    @dukenv0307
    Contributor

    @dukenv0307 Bump on accepting the offer please!

    @conorpendergrast accepted, thank you!

  19. conorpendergrast commented on Jan 15, 2024

    @conorpendergrast
    Contributor

    Paid and contract ended! C+ checklist by @narefyev91 is the last step, please

  20. narefyev91 commented on Jan 15, 2024

    @narefyev91
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR - it was not a regression - just missing functionality
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment - N/A
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion - N/A
    • Determine if we should create a regression test for this bug - N/A
  21. conorpendergrast commented on Jan 15, 2024

    @conorpendergrast
    Contributor

    Sounds good, thanks! Closing out, thanks everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions