You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Cancel payment - IOU preview and report title display "Canceled" when canceled payment is repaid #33508
Version Number: 1.4.16-3 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
That PR caused lots of deploy blockers. Seems like Cancel payment feature is not complete yet.
I'd suggest to revert PR or at least hide Cancel option until it is fully implemented without any critical bug.
I'm going to make the call that this does not need to be a deploy blocker since the fixes for this do not need to come in the App repo. The Web-Expensify and Auth PRs above should fix this.
This issue has not been updated in over 15 days. @joelbettner, @Gonals eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
github-actions commentedon Dec 22, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 22, 2023
Triggered auto assignment to @joelbettner (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.paultsimura commentedon Dec 22, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
When canceling the IOU payment and paying again, the "canceled" label remains on the report previews.
What is the root cause of that problem?
This is happening because when paying the IOU Request, we do not reset the
iouReport.isCancelledIOUtofalse.What changes do you think we should make in order to solve the problem?
First, we should fix this on FE: add an optimistic
isCancelledIOU: false(and corresponding failure data) here:App/src/libs/actions/IOU.js
Lines 2787 to 2797 in b0e038f
It also should be handled from the BE so that the API response will not return
isCancelledIOU: trueon thePayMoneyRequestcall.What alternative solutions did you explore? (Optional)
joelbettner commentedon Dec 22, 2023
I believe this was caused by this PR: #32674
@Gonals would you mind taking a look. I think what @paultsimura has outlined is correct.
situchan commentedon Dec 22, 2023
That PR caused lots of deploy blockers. Seems like Cancel payment feature is not complete yet.
I'd suggest to revert PR or at least hide Cancel option until it is fully implemented without any critical bug.
joelbettner commentedon Dec 23, 2023
I'm going to make the call that this does not need to be a deploy blocker since the fixes for this do not need to come in the App repo. The Web-Expensify and Auth PRs above should fix this.
paultsimura commentedon Dec 23, 2023
@joelbettner I would say we still should add the optimistic data updates on the App side after the BE changes are done: #33508 (comment)
mountiny commentedon Dec 25, 2023
THE PR got reverted assigning @Gonals just so they are aware
melvin-bot commentedon Jan 18, 2024
This issue has not been updated in over 15 days. @joelbettner, @Gonals eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
melvin-bot commentedon Mar 15, 2024
@joelbettner, @Gonals, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.