You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Cancel payment - IOU is still marked as paid when payment is canceled unless report is revisited #33509
Version Number: 1.4.16-3 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
When canceling the payment, its status is not immediately changed to "canceled".
What is the root cause of that problem?
This is a combined BE and FE issue. This is also seen on the Admin's side: the "canceled" label is not added at all.
We do not update the iouReport.isCancelledIOU: true optimistically when canceling the payment.
What changes do you think we should make in order to solve the problem?
When canceling the payment, we should optimistically set isCancelledIOU: true here. This will make the changes immediate for the Admin and ensure the Offline-first approach:
Also, we should update the BE: Pusher should update the IOU Report on the member side when it's marked as isCancelledIOU: true via the CancelPayment API call.
What alternative solutions did you explore? (Optional)
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-][HOLD for payment 2024-01-25] Cancel payment - IOU is still marked as paid when payment is canceled unless report is revisited[/-][+][HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Cancel payment - IOU is still marked as paid when payment is canceled unless report is revisited[/+]on Jan 19, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.27-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
This issue has not been updated in over 15 days. @Gonals eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
github-actions commentedon Dec 22, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 22, 2023
Triggered auto assignment to @johnmlee101 (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.paultsimura commentedon Dec 22, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
When canceling the payment, its status is not immediately changed to "canceled".
What is the root cause of that problem?
This is a combined BE and FE issue. This is also seen on the Admin's side: the "canceled" label is not added at all.
We do not update the
iouReport.isCancelledIOU: trueoptimistically when canceling the payment.What changes do you think we should make in order to solve the problem?
When canceling the payment, we should optimistically set
isCancelledIOU: truehere. This will make the changes immediate for the Admin and ensure the Offline-first approach:App/src/libs/actions/IOU.js
Lines 3114 to 3123 in b0e038f
Also, we should update the BE: Pusher should update the IOU Report on the member side when it's marked as
isCancelledIOU: truevia theCancelPaymentAPI call.What alternative solutions did you explore? (Optional)
mountiny commentedon Dec 25, 2023
Reverting the original PR because it has caused numerous deploy blockers and the author is ooo
18 remaining items
melvin-bot commentedon Jan 18, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-25. 🎊
[-][HOLD for payment 2024-01-25] Cancel payment - IOU is still marked as paid when payment is canceled unless report is revisited[/-][+][HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Cancel payment - IOU is still marked as paid when payment is canceled unless report is revisited[/+]melvin-bot commentedon Jan 19, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.27-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-26. 🎊
melvin-bot commentedon Feb 12, 2024
This issue has not been updated in over 15 days. @Gonals eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
melvin-bot commentedon Apr 25, 2024
@Gonals, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.