You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-24] [HOLD PR #33863][$500] Settings - Expensify icon of "Go to Expensify Classic" option doesn't turn to white when hover #33519
Version Number: 1.4.16-3 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Inernal Team Slack conversation:
Action Performed:
Login to ND Expensify
Navigate to account settings
Hover over each of the options
Verify if Expensify icon of "Go to Expensify Classic" option turn to white when hover
Expected Result:
Expensify icon of "Go to Expensify Classic" option should turn to white color when hover (or black color in light theme)
Actual Result:
Expensify icon of "Go to Expensify Classic" option doesn't turn to white color when hover (or black color in light theme)
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Settings - Expensify icon of "Go to Expensify Classic" option doesn't turn to white when hover[/-][+][$500] Settings - Expensify icon of "Go to Expensify Classic" option doesn't turn to white when hover[/+]on Dec 22, 2023
What changes do you think we should make in order to solve the problem?
We need to remove this fill attribute from the svg file and allow the IconComponent to fill dynamic value.
Not related to fixing this issue but we can also add the same class prop .st1{fill-rule:evenodd;clip-rule:evenodd} which we have for other svgs file.
Description of Logic:
The addition of fill-rule: evenodd; and clip-rule: evenodd; in the SVG styling simplifies and unifies the color change behavior.
fill-rule: evenodd;:
This makes sure that when coloring the shape, a point is considered inside if it crosses the boundary an odd number of times and outside if it's even.
clip-rule: evenodd;:
Similarly, when clipping the element, areas crossed an odd number of times remain visible, while those crossed an even number of times are hidden.
Why It Matters:
By using the same even-odd logic for both filling and clipping, we ensure a consistent and visually pleasing hover effect on the SVG icon.
📣 @NoumanHunzai! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
changed the title [-][HOLD PR #33863][$500] Settings - Expensify icon of "Go to Expensify Classic" option doesn't turn to white when hover[/-][+][HOLD for payment 2024-01-24] [HOLD PR #33863][$500] Settings - Expensify icon of "Go to Expensify Classic" option doesn't turn to white when hover[/+]on Jan 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[] The PR that introduced the bug has been identified. Link to the PR:
[] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[] Determine if we should create a regression test for this bug.
[] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
[-]Settings - Expensify icon of "Go to Expensify Classic" option doesn't turn to white when hover[/-][+][$500] Settings - Expensify icon of "Go to Expensify Classic" option doesn't turn to white when hover[/+]melvin-bot commentedon Dec 22, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01b5dbb083b2a8f016
melvin-bot commentedon Dec 22, 2023
Triggered auto assignment to @miljakljajic (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Dec 22, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Dec 22, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)Pujan92 commentedon Dec 22, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
For 'Go to expensify classic' menu item, Icon color is not changing on hover
What is the root cause of that problem?
Currently, static color has been set for fill prop in the svg file.
https://github.com/Expensify/App/blob/main/assets/images/new-expensify.svg?short_path=38276ec#L1C161-L1C161
It is added in this PR.
What changes do you think we should make in order to solve the problem?
We need to remove this fill attribute from the svg file and allow the IconComponent to fill dynamic value.
Not related to fixing this issue but we can also add the same class prop
.st1{fill-rule:evenodd;clip-rule:evenodd}which we have for other svgs file.paultsimura commentedon Dec 22, 2023
The original issue #32875 is still on the regression period, so this issue should be handled as a follow-up.
cc: @barttom @thesahindia
NoumanHunzai commentedon Dec 23, 2023
**Proposal to Resolve SVG Icon Color Change Issue:
Proposed Solution:**
Update the SVG style rule from:
.st1 { fill: #03d47c; }to
.st1 { fill-rule: evenodd; clip-rule: evenodd; }Verification:
A video demonstrating the successful implementation is available
https://www.loom.com/share/a807263b9c4444b58c7d0e69286dffff?sid=15696b45-109b-43e0-9040-8e6ba8a01866
Description of Logic:
The addition of fill-rule: evenodd; and clip-rule: evenodd; in the SVG styling simplifies and unifies the color change behavior.
fill-rule: evenodd;:
This makes sure that when coloring the shape, a point is considered inside if it crosses the boundary an odd number of times and outside if it's even.
clip-rule: evenodd;:
Similarly, when clipping the element, areas crossed an odd number of times remain visible, while those crossed an even number of times are hidden.
Why It Matters:
By using the same even-odd logic for both filling and clipping, we ensure a consistent and visually pleasing hover effect on the SVG icon.
Thank You
melvin-bot commentedon Dec 23, 2023
📣 @NoumanHunzai! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
16 remaining items
[-][HOLD PR #33863][$500] Settings - Expensify icon of "Go to Expensify Classic" option doesn't turn to white when hover[/-][+][HOLD for payment 2024-01-24] [HOLD PR #33863][$500] Settings - Expensify icon of "Go to Expensify Classic" option doesn't turn to white when hover[/+]melvin-bot commentedon Jan 17, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-24. 🎊
melvin-bot commentedon Jan 17, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
miljakljajic commentedon Jan 22, 2024
Not reproducible any more - closing as per Rocio's comment above.