You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-24] [$500] The pay button is not shown again after removing the error, When there’s an error at the moment to pay a request #33524
Execute the following JS snippet in the OldDot policy to enable workspace chats creation:
if (Url.getCurrentPageName()!="policy" ){ alert('Only run this snippet from a policy editor!'); } else { var p = Policy.getCurrent(); p.policy.isPolicyExpenseChatEnabled = "true"; p.save().done(function(){$.jGrowl('Workspace chat creation enabled!')}); }
Add a member and an approver (it can be the same as the policy owner)
Add the same bank account for the member and the policy owner
Login in one session as a member and in another session as the approver
As member, create and submit a money request in the workspace chat
As admin/approver click/tap on the request and approve
Then select Pay elsewhere
An error will appear at the bottom of the expense chat, click on the x to remove it
Expected result:
The Pay button should appear again
Actual result:
The Pay button doesn’t appear and the user should come back to the workspace chat and open the expense request to refresh the request
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-] The pay button is not shown again after removing the error, When there’s an error at the moment to pay a request [/-][+][$500] The pay button is not shown again after removing the error, When there’s an error at the moment to pay a request [/+]on Dec 29, 2023
changed the title [-][$500] The pay button is not shown again after removing the error, When there’s an error at the moment to pay a request [/-][+][HOLD for payment 2024-01-24] [$500] The pay button is not shown again after removing the error, When there’s an error at the moment to pay a request [/+]on Jan 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
[@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@thesahindia] Determine if we should create a regression test for this bug.
[@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
This case was missed since it wasn't a common flow.
If we want we can add a test case -
Create a collect policy in OldDot
Execute the following JS snippet in the OldDot policy to enable workspace chats creation: if (Url.getCurrentPageName()!="policy" ){ alert('Only run this snippet from a policy editor!'); } else { var p = Policy.getCurrent(); p.policy.isPolicyExpenseChatEnabled = "true"; p.save().done(function(){$.jGrowl('Workspace chat creation enabled!')}); }
Add a member and an approver (it can be the same as the policy owner)
Add the same bank account for the member and the policy owner
Login in one session as a member and in another session as the approver
As member, create and submit a money request in the workspace chat
As admin/approver click/tap on the request and approve
Then select Pay elsewhere
An error will appear at the bottom of the expense chat
Activity
melvin-bot commentedon Dec 22, 2023
Current assignee @Christinadobrzyn is eligible for the Bug assigner, not assigning anyone new.
melvin-bot commentedon Dec 22, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Dec 26, 2023
@Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Dec 28, 2023
@Christinadobrzyn Huh... This is 4 days overdue. Who can take care of this?
marcochavezf commentedon Dec 29, 2023
Assigning myself to track it. Also, I will make external I think this can be fixed on the frontend
[-] The pay button is not shown again after removing the error, When there’s an error at the moment to pay a request [/-][+][$500] The pay button is not shown again after removing the error, When there’s an error at the moment to pay a request [/+]melvin-bot commentedon Dec 29, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01f3679b87a3fd246a
44 remaining items
[-][$500] The pay button is not shown again after removing the error, When there’s an error at the moment to pay a request [/-][+][HOLD for payment 2024-01-24] [$500] The pay button is not shown again after removing the error, When there’s an error at the moment to pay a request [/+]melvin-bot commentedon Jan 17, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-24. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 17, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Christinadobrzyn commentedon Jan 23, 2024
prepping for payment @thesahindia should we have a regression test?
Payouts due:
Issue Reporter: NA
Contributor: $500 @bernhardoj (Paid in Upwork)
Contributor+: $500 @thesahindia (in NewExpensify)
Eligible for 50% #urgency bonus? NA
Upwork job is here.
conorpendergrast commentedon Jan 24, 2024
Ah, you're back Christina! I'll unassign myself as you have this all handled
Christinadobrzyn commentedon Jan 26, 2024
paying this out based on this payment summary #33524 (comment)
@thesahindia let me know about a regression test
thesahindia commentedon Jan 29, 2024
This case was missed since it wasn't a common flow.
If we want we can add a test case -
if (Url.getCurrentPageName()!="policy" ){ alert('Only run this snippet from a policy editor!'); } else { var p = Policy.getCurrent(); p.policy.isPolicyExpenseChatEnabled = "true"; p.save().done(function(){$.jGrowl('Workspace chat creation enabled!')}); }Christinadobrzyn commentedon Jan 29, 2024
Awesome! thanks @thesahindia - created the regression test https://github.com/Expensify/Expensify/issues/364696
closing this out! Feel free to reach out if I've missed anything.
JmillsExpensify commentedon Apr 10, 2024
$500 approved for @thesahindia