Skip to content

[HOLD for payment 2024-01-24] [$500] The pay button is not shown again after removing the error, When there’s an error at the moment to pay a request  #33524

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.16-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @marcochavezf
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1703202408554429

Action Performed:

  1. Create a collect policy in OldDot
  2. Execute the following JS snippet in the OldDot policy to enable workspace chats creation:
    if (Url.getCurrentPageName()!="policy" ){ alert('Only run this snippet from a policy editor!'); } else { var p = Policy.getCurrent(); p.policy.isPolicyExpenseChatEnabled = "true"; p.save().done(function(){$.jGrowl('Workspace chat creation enabled!')}); }
  3. Add a member and an approver (it can be the same as the policy owner)
  4. Add the same bank account for the member and the policy owner
  5. Login in one session as a member and in another session as the approver
  6. As member, create and submit a money request in the workspace chat
  7. As admin/approver click/tap on the request and approve
  8. Then select Pay elsewhere
  9. An error will appear at the bottom of the expense chat, click on the x to remove it

Expected result:

The Pay button should appear again

Actual result:

The Pay button doesn’t appear and the user should come back to the workspace chat and open the expense request to refresh the request

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2023-12-21.at.5.30.44.p.m.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f3679b87a3fd246a
  • Upwork Job ID: 1740835161555730432
  • Last Price Increase: 2024-01-05
  • Automatic offers:
    • bernhardoj | Contributor | 28089862
Issue OwnerCurrent Issue Owner: @thesahindia

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 22, 2023
  2. melvin-bot commented on Dec 22, 2023

    @melvin-bot

    Current assignee @Christinadobrzyn is eligible for the Bug assigner, not assigning anyone new.

  3. melvin-bot commented on Dec 22, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. melvin-bot commented on Dec 26, 2023

    @melvin-bot

    @Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  5. melvin-bot commented on Dec 28, 2023

    @melvin-bot

    @Christinadobrzyn Huh... This is 4 days overdue. Who can take care of this?

  6. marcochavezf commented on Dec 29, 2023

    @marcochavezf
    Contributor

    Assigning myself to track it. Also, I will make external I think this can be fixed on the frontend

  7. self-assigned this
    on Dec 29, 2023
  8. changed the title [-] The pay button is not shown again after removing the error, When there’s an error at the moment to pay a request [/-] [+][$500] The pay button is not shown again after removing the error, When there’s an error at the moment to pay a request [/+] on Dec 29, 2023
  9. melvin-bot commented on Dec 29, 2023

    @melvin-bot
  10. 44 remaining items

  11. changed the title [-][$500] The pay button is not shown again after removing the error, When there’s an error at the moment to pay a request [/-] [+][HOLD for payment 2024-01-24] [$500] The pay button is not shown again after removing the error, When there’s an error at the moment to pay a request [/+] on Jan 17, 2024
  12. melvin-bot commented on Jan 17, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jan 17, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-01-24. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Jan 17, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
    • [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@thesahindia] Determine if we should create a regression test for this bug.
    • [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@conorpendergrast / @Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/364696
  15. Christinadobrzyn commented on Jan 23, 2024

    @Christinadobrzyn
    Contributor

    prepping for payment @thesahindia should we have a regression test?

    Payouts due:

    Issue Reporter: NA
    Contributor: $500 @bernhardoj (Paid in Upwork)
    Contributor+: $500 @thesahindia (in NewExpensify)

    Eligible for 50% #urgency bonus? NA

    Upwork job is here.

  16. conorpendergrast commented on Jan 24, 2024

    @conorpendergrast
    Contributor

    Ah, you're back Christina! I'll unassign myself as you have this all handled

  17. removed their assignment
    on Jan 24, 2024
  18. Christinadobrzyn commented on Jan 26, 2024

    @Christinadobrzyn
    Contributor

    paying this out based on this payment summary #33524 (comment)

    @thesahindia let me know about a regression test

  19. thesahindia commented on Jan 29, 2024

    @thesahindia
    Member

    This case was missed since it wasn't a common flow.

    If we want we can add a test case -

    1. Create a collect policy in OldDot
    2. Execute the following JS snippet in the OldDot policy to enable workspace chats creation: if (Url.getCurrentPageName()!="policy" ){ alert('Only run this snippet from a policy editor!'); } else { var p = Policy.getCurrent(); p.policy.isPolicyExpenseChatEnabled = "true"; p.save().done(function(){$.jGrowl('Workspace chat creation enabled!')}); }
    3. Add a member and an approver (it can be the same as the policy owner)
    4. Add the same bank account for the member and the policy owner
    5. Login in one session as a member and in another session as the approver
    6. As member, create and submit a money request in the workspace chat
    7. As admin/approver click/tap on the request and approve
    8. Then select Pay elsewhere
    9. An error will appear at the bottom of the expense chat
    10. Verify the Pay elsewhere button shows again
  20. Christinadobrzyn commented on Jan 29, 2024

    @Christinadobrzyn
    Contributor

    Awesome! thanks @thesahindia - created the regression test https://github.com/Expensify/Expensify/issues/364696

    closing this out! Feel free to reach out if I've missed anything.

  21. JmillsExpensify commented on Apr 10, 2024

    @JmillsExpensify
    Contributor

    $500 approved for @thesahindia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions