Skip to content

[HOLD for payment 2024-03-11] [HOLD for payment 2024-02-19] [$500] mWeb - Workspace - "Next" button's placement has a delay after the keypad disappears #33546

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.16.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. Log in with an expensifail account
  3. Create a workspace
  4. Invite a new member
  5. Type in the full email address and make sure that the keypad is visible
  6. Tap on the checkbox next to the email

Expected Result:

There shouldn't be a delay.

Actual Result:

"Next" button's placement has a delay after the keypad disappears.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6324864_1703334991241.QBAP2569.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01241daac204a80575
  • Upwork Job ID: 1738559249320325120
  • Last Price Increase: 2023-12-30
  • Automatic offers:
    • shubham1206agra | Reviewer | 28088091
    • suneox | Contributor | 28088092
Issue OwnerCurrent Issue Owner: @shubham1206agra

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 23, 2023
  2. changed the title [-]mWeb - Workspace - "Next" button's placement has a delay after the keypad disappears[/-] [+][$500] mWeb - Workspace - "Next" button's placement has a delay after the keypad disappears[/+] on Dec 23, 2023
  3. melvin-bot commented on Dec 23, 2023

    @melvin-bot
  4. melvin-bot commented on Dec 23, 2023

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 23, 2023
  6. melvin-bot commented on Dec 23, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot commented on Dec 23, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

  8. maazakn commented on Dec 23, 2023

    @maazakn

    When adding a new member, the button lags whenever the keypad is opened or closed, regardless of whether a checkbox is selected.

  9. melvin-bot commented on Dec 23, 2023

    @melvin-bot

    📣 @maazakn! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  10. samuelralak commented on Dec 24, 2023

    @samuelralak

    Contributor details
    Your Expensify account email: thesamuelralak@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~011e010bd867c901e3

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    • A delay in the repositioning of the "Next" button when keyboard is dismissed.

    What is the root cause of that problem?

    Mismatch in timing of the keyboard's retraction animation and button's position update

    A similar behaviour can be observed in the following routes:

    What changes do you think we should make in order to solve the problem?

    Quick

    Set shouldEnableMaxHeight prop of ScreenWrapper to false or just don't include it. This makes the button position static, gracefully hiding it behind the keyboard when input is in focus thus maintaining a consistent user experience with the following routes:

    Long Term

    Incorporate the KeyboardAvoidingView component, along with appropriate padding and animation configurations, to automatically adjust the layout when the keyboard is visible. Disclaimer - this is a trial and error approach, mostly due to my limited familiarity with the codebase now.

    What alternative solutions did you explore? (Optional)

    • None
  11. melvin-bot commented on Dec 24, 2023

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  12. 82 remaining items

  13. shubham1206agra commented on Mar 27, 2024

    @shubham1206agra
    Contributor

    @bfitzexpensify I have discussed this internally. You may close this issue as I am keeping track of payment internally and will ask to pay once the issue is resolved. Just write in the payment summary that I have not been paid yet.

  14. bfitzexpensify commented on Mar 27, 2024

    @bfitzexpensify
    Contributor

    Sure thing.

    Payment summary:

    @suneox due $500 for contributor work (paid via Upwork ✅)
    @shubham1206agra due $500 for C+ work (payment outstanding)

  15. shubham1206agra commented on Apr 17, 2024

    @shubham1206agra
    Contributor

    @bfitzexpensify Can you process payment here now?

  16. bfitzexpensify commented on Apr 18, 2024

    @bfitzexpensify
    Contributor

    I think the old offer might have expired - just sent a new one to you @shubham1206agra

  17. shubham1206agra commented on Apr 18, 2024

    @shubham1206agra
    Contributor

    Accepted

  18. bfitzexpensify commented on Apr 18, 2024

    @bfitzexpensify
    Contributor

    Thanks! Paid out, closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions