You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-02-15] [$500] Request - Merchant and category rows disappear in the confirmation page after adding receipt #33588
Version Number: v1.4.17-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause-Internal Team Slack conversation: @
Action Performed:
Go to workspace chat > + > Request money .
Go to Manual > Enter amount > Next.
Click 3-dot menu > Add receipt.
Add a receipt.
Expected Result:
Merchant and category rows will not disappear in the confirmation page,
Actual Result:
Merchant and category rows disappear in the confirmation page,
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Request - Merchant and category rows disappear in the confirmation page after adding receipt[/-][+][$500] Request - Merchant and category rows disappear in the confirmation page after adding receipt[/+]on Dec 26, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@getusha] The PR that introduced the bug has been identified. Link to the PR:
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@getusha] Determine if we should create a regression test for this bug.
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@getusha] The PR that introduced the bug has been identified. Link to the PR: #30721
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30721/files#r1491344743
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a this is a special case that was missed by the PR author.
[@getusha] Determine if we should create a regression test for this bug. Yes
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Open any workspace chat > + > Request money
Select Manual > Enter any amount > Next
Click top right menu icon > Add receipt
Upload a receipt
Verify that fields such as date and merchant are present and remain unchanged from their state prior to uploading the receipt.
Add a value to merchant field > Request money
Verify the created request doesn't start the SmartScan process
Activity
melvin-bot commentedon Dec 26, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0179ee4404d0db5b5f
[-]Request - Merchant and category rows disappear in the confirmation page after adding receipt[/-][+][$500] Request - Merchant and category rows disappear in the confirmation page after adding receipt[/+]melvin-bot commentedon Dec 26, 2023
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Dec 26, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Dec 26, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (
External)83 remaining items
melvin-bot commentedon Feb 8, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-02-15. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 8, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Feb 15, 2024
Payment Summary
Upwork Job
BugZero Checklist (@JmillsExpensify)
JmillsExpensify commentedon Feb 15, 2024
Updated the payment summary above. There are no auto-contracts for this issue, so I'm creating those now.
getusha commentedon Feb 15, 2024
[@getusha] The PR that introduced the bug has been identified. Link to the PR: #30721
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30721/files#r1491344743
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a this is a special case that was missed by the PR author.
[@getusha] Determine if we should create a regression test for this bug. Yes
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
dateandmerchantare present and remain unchanged from their state prior to uploading the receipt.Do we agree 👍 or 👎
JmillsExpensify commentedon Feb 15, 2024
Everyone paid out and the regression test has been added. Closing this one!