You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-04] [HOLD for payment 2024-01-03] [$125] Profile - Zoom icon is black in dark and light mode, it is hardly visible in dark mode #33590
Version Number: v1.4.17-1 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
The Zoom icon is black in dark and light modes, it is hardly visible in dark mode
What is the root cause of that problem?
The root cause of the problem is we are theme.icons to fill the icon color. This prohibits the color of the zoom icon from adapting to the device's theme.
changed the title [-]Profile - Zoom icon is black in dark and light mode, it is hardly visible in dark mode[/-][+][$125] Profile - Zoom icon is black in dark and light mode, it is hardly visible in dark mode[/+]on Dec 26, 2023
@Pujan92 are you available to raise a PR right now? If not, I can assign @Tony-MK if they're available. Otherwise I'll create the PR myself as this is a blocker.
Activity
github-actions commentedon Dec 26, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 26, 2023
Triggered auto assignment to @youssef-lr (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.Pujan92 commentedon Dec 26, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
Zoom icon isn't visible for the upload image view
What changes do you think we should make in order to solve the problem?
Seems it comes from this PR where there is a typo for setting the color for fill prop.
https://github.com/Expensify/App/pull/31034/files#diff-f265a5ae9cea30af21ecbd34b52aa47636dd70e948f45c95246a41fc62398580L405
App/src/components/AvatarCropModal/AvatarCropModal.js
Line 409 in de5a943
It gets noticed after this PR where fallback color for fill has been removed.
https://github.com/Expensify/App/pull/30905/files#diff-a5a68b4de9f3cac867a3129751702510d00054f7714008af2fbf19dca2937d10L67
What alternative solutions did you explore? (Optional)
It should be
theme.iconinsteadtheme.icons.Tony-MK commentedon Dec 26, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
The Zoom icon is black in dark and light modes, it is hardly visible in dark mode
What is the root cause of that problem?
The root cause of the problem is we are
theme.iconsto fill the icon color. This prohibits the color of the zoom icon from adapting to the device's theme.App/src/components/AvatarCropModal/AvatarCropModal.js
Lines 407 to 410 in 92501dc
What changes do you think we should make in order to solve the problem?
Instead of
theme.icons, usetheme.inverseto fill the Icon's color as the inverse of the device's theme.Just like how the rotate button adapts to the device's theme.
Therefore, I think we should replicate its theme.
App/src/components/AvatarCropModal/AvatarCropModal.js
Line 432 in 92501dc
Result
Light Theme
Dark Theme
[-]Profile - Zoom icon is black in dark and light mode, it is hardly visible in dark mode[/-][+][$125] Profile - Zoom icon is black in dark and light mode, it is hardly visible in dark mode[/+]melvin-bot commentedon Dec 26, 2023
youssef-lr commentedon Dec 26, 2023
@Pujan92 are you available to raise a PR right now? If not, I can assign @Tony-MK if they're available. Otherwise I'll create the PR myself as this is a blocker.
melvin-bot commentedon Dec 26, 2023
Job added to Upwork: https://www.upwork.com/jobs/~011bcc7fd01bf144d6
29 remaining items
Pujan92 commentedon Jan 10, 2024
Also tagging @mountiny to confirm.
mountiny commentedon Jan 10, 2024
@youssef-lr if the solution from @Pujan92 has been reused, we should pay them out partial reward as it was a deploy blocker
melvin-bot commentedon Jan 15, 2024
@youssef-lr, @Pujan92 Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Jan 17, 2024
Triggered auto assignment to @sophiepintoraetz (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.youssef-lr commentedon Jan 17, 2024
@sophiepintoraetz can we issue a $125 payment to @Pujan92 please.
sophiepintoraetz commentedon Jan 17, 2024
hired - offer sent
Pujan92 commentedon Jan 18, 2024
Accepted.