Skip to content

[HOLD for payment 2024-01-04] [HOLD for payment 2024-01-03] [$125] Profile - Zoom icon is black in dark and light mode, it is hardly visible in dark mode #33590

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.17-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Go to Settings -> Profile -> Click on Avatar -> Upload photo -> Choose an image -> Open
  3. Notice that the zoom icon is black in dark and light mode

Expected Result:

The Zoom icon is well visible in dark mode

Actual Result:

Zoom icon is black in dark and light mode, it is hardly visible in dark mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image

Bug6326167_1703596463724.bandicam_2023-12-26_13-23-31-571.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011bcc7fd01bf144d6
  • Upwork Job ID: 1739772024796622848
  • Last Price Increase: 2023-12-26

Activity

  1. github-actions commented on Dec 26, 2023

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Dec 26, 2023

    @melvin-bot

    Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. Pujan92 commented on Dec 26, 2023

    @Pujan92
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    What is the root cause of that problem?

    Zoom icon isn't visible for the upload image view

    What changes do you think we should make in order to solve the problem?

    Seems it comes from this PR where there is a typo for setting the color for fill prop.
    https://github.com/Expensify/App/pull/31034/files#diff-f265a5ae9cea30af21ecbd34b52aa47636dd70e948f45c95246a41fc62398580L405

    It gets noticed after this PR where fallback color for fill has been removed.
    https://github.com/Expensify/App/pull/30905/files#diff-a5a68b4de9f3cac867a3129751702510d00054f7714008af2fbf19dca2937d10L67

    What alternative solutions did you explore? (Optional)

    It should be theme.icon instead theme.icons.

  4. Tony-MK commented on Dec 26, 2023

    @Tony-MK
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The Zoom icon is black in dark and light modes, it is hardly visible in dark mode

    What is the root cause of that problem?

    The root cause of the problem is we are theme.icons to fill the icon color. This prohibits the color of the zoom icon from adapting to the device's theme.

    <Icon
    src={Expensicons.Zoom}
    fill={theme.icons}
    />

    What changes do you think we should make in order to solve the problem?

    Instead of theme.icons, use theme.inverse to fill the Icon's color as the inverse of the device's theme.

    Just like how the rotate button adapts to the device's theme.

    Therefore, I think we should replicate its theme.

    iconFill={theme.inverse}

    Result

    Light Theme

    Dark Theme

    Dark Theme

    Light Theme

  5. changed the title [-]Profile - Zoom icon is black in dark and light mode, it is hardly visible in dark mode[/-] [+][$125] Profile - Zoom icon is black in dark and light mode, it is hardly visible in dark mode[/+] on Dec 26, 2023
  6. melvin-bot commented on Dec 26, 2023

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  7. youssef-lr commented on Dec 26, 2023

    @youssef-lr
    Contributor

    @Pujan92 are you available to raise a PR right now? If not, I can assign @Tony-MK if they're available. Otherwise I'll create the PR myself as this is a blocker.

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 26, 2023
  9. melvin-bot commented on Dec 26, 2023

    @melvin-bot
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 26, 2023
  11. 29 remaining items

  12. Pujan92 commented on Jan 10, 2024

    @Pujan92
    Contributor

    not sure if I am eligible for any compensation, @youssef-lr can you plz confirm

    Also tagging @mountiny to confirm.

  13. mountiny commented on Jan 10, 2024

    @mountiny
    Contributor

    @youssef-lr if the solution from @Pujan92 has been reused, we should pay them out partial reward as it was a deploy blocker

  14. melvin-bot commented on Jan 15, 2024

    @melvin-bot

    @youssef-lr, @Pujan92 Huh... This is 4 days overdue. Who can take care of this?

  15. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 17, 2024
  16. melvin-bot commented on Jan 17, 2024

    @melvin-bot

    Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  17. removed
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 17, 2024
  18. youssef-lr commented on Jan 17, 2024

    @youssef-lr
    Contributor

    @sophiepintoraetz can we issue a $125 payment to @Pujan92 please.

  19. sophiepintoraetz commented on Jan 17, 2024

    @sophiepintoraetz
    Contributor

    hired - offer sent

  20. Pujan92 commented on Jan 18, 2024

    @Pujan92
    Contributor

    hired - offer sent

    Accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions