You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-04] [HOLD for payment 2024-01-03] [$500] Android - Modal thumbnail is not displayed for workspace manual request #33591
Version Number: 1.4.17-1 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@c3024] The PR that introduced the bug has been identified. Link to the PR: Expo image #30905
[@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA. This was caused due to a new library expo-image used for images. So such discussion has no benefit.
[@c3024] Determine if we should create a regression test for this bug. No, the bug was identified in staging testing
[@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. NA
Activity
github-actions commentedon Dec 26, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 26, 2023
Triggered auto assignment to @marcochavezf (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.mkhutornyi commentedon Dec 26, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
[Android, iOS] receipt empty thumbnail is not displayed for workspace manual request
What is the root cause of that problem?
App/src/components/ReceiptEmptyState.js
Lines 31 to 36 in 92501dc
fillis transparent here(this didn't happen before expo image PR)
What changes do you think we should make in order to solve the problem?
remove
fillpropmarcochavezf commentedon Dec 26, 2023
Thanks for the proposal @mkhutornyi, can you create a PR with the solution in the next few hours?
mkhutornyi commentedon Dec 26, 2023
yes, I can
marcochavezf commentedon Dec 26, 2023
Ok great, assigning you
melvin-bot commentedon Dec 26, 2023
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Dec 26, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)34 remaining items
marcochavezf commentedon Jan 4, 2024
Hi @c3024, could you complete the bz checklist?
c3024 commentedon Jan 5, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Jan 8, 2024
@JmillsExpensify, @marcochavezf, @mkhutornyi, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!
marcochavezf commentedon Jan 9, 2024
Checklist completed, only payment is pending
melvin-bot commentedon Jan 10, 2024
@JmillsExpensify, @marcochavezf, @mkhutornyi, @c3024 Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Jan 12, 2024
@JmillsExpensify, @marcochavezf, @mkhutornyi, @c3024 Still overdue 6 days?! Let's take care of this!
melvin-bot commentedon Jan 16, 2024
@JmillsExpensify, @marcochavezf, @mkhutornyi, @c3024 10 days overdue. I'm getting more depressed than Marvin.
marcochavezf commentedon Jan 17, 2024
Hi @JmillsExpensify, could you handle the payment for @mkhutornyi as contributor and @c3024 as C+ reviewer?
melvin-bot commentedon Jan 18, 2024
@JmillsExpensify, @marcochavezf, @mkhutornyi, @c3024 12 days overdue. Walking. Toward. The. Light...
JmillsExpensify commentedon Jan 24, 2024
Sure thing! Payment summary:
JmillsExpensify commentedon Jan 24, 2024
Everyone is paid out. Closing the issue.