Skip to content

[HOLD for payment 2024-01-04] [HOLD for payment 2024-01-03] [$500] Android - Modal thumbnail is not displayed for workspace manual request #33591

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.17-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #33347

Action Performed:

  1. Launch app
  2. Tap on a Workspace chat
  3. Tap plus icon ---- Request money ----- Manual
  4. Enter an amount
  5. Tap next
  6. Tap show more
  7. Select a category
  8. Tap request
  9. Tap on the new request created to open detail page

Expected Result:

Modal thumbnail must be displayed for workspace manual request.

Actual Result:

Modal thumbnail is not displayed for workspace manual request.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6326161_1703595748152.modal.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0160d858d1b98fe7ed
  • Upwork Job ID: 1739767395487518720
  • Last Price Increase: 2023-12-26
  • Automatic offers:
    • c3024 | Reviewer | 28070428
    • mkhutornyi | Contributor | 28070429
Issue OwnerCurrent Issue Owner: @JmillsExpensify

Activity

  1. github-actions commented on Dec 26, 2023

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Dec 26, 2023

    @melvin-bot

    Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. mkhutornyi commented on Dec 26, 2023

    @mkhutornyi
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    [Android, iOS] receipt empty thumbnail is not displayed for workspace manual request

    What is the root cause of that problem?

    <Icon
    src={Expensicons.EmptyStateAttachReceipt}
    width={variables.eReceiptIconWidth}
    height={variables.eReceiptIconHeight}
    fill="transparent"
    />

    fill is transparent here
    (this didn't happen before expo image PR)

    What changes do you think we should make in order to solve the problem?

    remove fill prop

  4. marcochavezf commented on Dec 26, 2023

    @marcochavezf
    Contributor

    Thanks for the proposal @mkhutornyi, can you create a PR with the solution in the next few hours?

  5. mkhutornyi commented on Dec 26, 2023

    @mkhutornyi
    Contributor

    yes, I can

  6. marcochavezf commented on Dec 26, 2023

    @marcochavezf
    Contributor

    Ok great, assigning you

  7. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 26, 2023
  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 26, 2023
  9. melvin-bot commented on Dec 26, 2023

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  10. melvin-bot commented on Dec 26, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  11. 34 remaining items

  12. marcochavezf commented on Jan 4, 2024

    @marcochavezf
    Contributor

    Hi @c3024, could you complete the bz checklist?

  13. c3024 commented on Jan 5, 2024

    @c3024
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@c3024] The PR that introduced the bug has been identified. Link to the PR: Expo image #30905
    • [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30905/files#r1443009438
    • [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA. This was caused due to a new library expo-image used for images. So such discussion has no benefit.
    • [@c3024] Determine if we should create a regression test for this bug. No, the bug was identified in staging testing
    • [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. NA
  14. melvin-bot commented on Jan 8, 2024

    @melvin-bot

    @JmillsExpensify, @marcochavezf, @mkhutornyi, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  15. marcochavezf commented on Jan 9, 2024

    @marcochavezf
    Contributor

    Checklist completed, only payment is pending

  16. melvin-bot commented on Jan 10, 2024

    @melvin-bot

    @JmillsExpensify, @marcochavezf, @mkhutornyi, @c3024 Huh... This is 4 days overdue. Who can take care of this?

  17. melvin-bot commented on Jan 12, 2024

    @melvin-bot

    @JmillsExpensify, @marcochavezf, @mkhutornyi, @c3024 Still overdue 6 days?! Let's take care of this!

  18. melvin-bot commented on Jan 16, 2024

    @melvin-bot

    @JmillsExpensify, @marcochavezf, @mkhutornyi, @c3024 10 days overdue. I'm getting more depressed than Marvin.

  19. marcochavezf commented on Jan 17, 2024

    @marcochavezf
    Contributor

    Hi @JmillsExpensify, could you handle the payment for @mkhutornyi as contributor and @c3024 as C+ reviewer?

  20. melvin-bot commented on Jan 18, 2024

    @melvin-bot

    @JmillsExpensify, @marcochavezf, @mkhutornyi, @c3024 12 days overdue. Walking. Toward. The. Light...

  21. JmillsExpensify commented on Jan 24, 2024

    @JmillsExpensify
    Contributor

    Sure thing! Payment summary:

  22. JmillsExpensify commented on Jan 24, 2024

    @JmillsExpensify
    Contributor

    Everyone is paid out. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions