Skip to content

[HOLD for payment 2024-01-04] [HOLD for payment 2024-01-03] [$500] Bank Account - Green square in place of BA icon #33602

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.17-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Pre-requisite: user must have connected a bank account to workspace.

  1. Open New Expensify app.
  2. Go to Settings > Workspaces > Workspace > Bank account.

Expected Result:

The bank account icon should be displayed on the added account, like the one displayed on the Wallet page.

Actual Result:

There is a green square in the place of the bank account icon.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e1b5b4f91e738c9a
  • Upwork Job ID: 1739684100655161344
  • Last Price Increase: 2023-12-26
  • Automatic offers:
    • shubham1206agra | Reviewer | 28070497
Issue OwnerCurrent Issue Owner: @rushatgabhane

Activity

  1. github-actions commented on Dec 26, 2023

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Dec 26, 2023

    @melvin-bot

    Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. shubham1206agra commented on Dec 26, 2023

    @shubham1206agra
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue

    Bank Account - Green square in place of BA icon

    What is the root cause of that problem?

    This is happening from 3dc4373, cause they missed the EnableStep component while refactoring.

    What changes do you think we should make in order to solve the problem?

    Add displayInDefaultIconColor in MenuItem in EnableStep

    What alternative solutions did you explore? (Optional)

  4. shubham1206agra commented on Dec 26, 2023

    @shubham1206agra
    Contributor
    Screenshot 2023-12-26 at 9 51 49 PM

    Fixed

  5. shubham1206agra commented on Dec 26, 2023

    @shubham1206agra
    Contributor

    @mountiny Can you confirm the icon?

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 26, 2023
  7. changed the title [-]Bank Account - Green square in place of BA icon[/-] [+][$500] Bank Account - Green square in place of BA icon[/+] on Dec 26, 2023
  8. melvin-bot commented on Dec 26, 2023

    @melvin-bot
  9. 33 remaining items

  10. melvin-bot commented on Dec 28, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@rushatgabhane / @shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
    • [@rushatgabhane / @shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@rushatgabhane / @shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@rushatgabhane / @shubham1206agra] Determine if we should create a regression test for this bug.
    • [@rushatgabhane / @shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  11. rushatgabhane commented on Jan 2, 2024

    @rushatgabhane
    Member
    1. The PR that introduced the bug has been identified. Link to the PR: Expo image #30905

    2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Expo image #30905 (comment)

    3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No because it was a giant refacto.

    4. Determine if we should create a regression test for this bug. No.

    5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - No

  12. JmillsExpensify commented on Jan 2, 2024

    @JmillsExpensify
    Contributor

    Still two days to go, though I'm going to handle payment in Expensify anyway. $500 payment approved for @rushatgabhane based on this comment.

  13. NicMendonca commented on Jan 4, 2024

    @NicMendonca
    Contributor

    @shubham1206agra you've been paid via Upwork!

  14. NicMendonca commented on Jan 5, 2024

    @NicMendonca
    Contributor

    @rushatgabhane just a bump on the BZ checklist!

  15. melvin-bot commented on Jan 9, 2024

    @melvin-bot

    @NicMendonca, @rushatgabhane, @mountiny, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  16. rushatgabhane commented on Jan 10, 2024

    @rushatgabhane
    Member

    Checklist here #33602 (comment)
    This issue can be closed

  17. mountiny commented on Jan 10, 2024

    @mountiny
    Contributor

    @NicMendonca we need to pay to @shubham1206agra before closing

  18. NicMendonca commented on Jan 10, 2024

    @NicMendonca
    Contributor
  19. NicMendonca commented on Jan 10, 2024

    @NicMendonca
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions