You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-04] [HOLD for payment 2024-01-03] [$500] Bank Account - Green square in place of BA icon #33602
Version Number: 1.4.17-1 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Pre-requisite: user must have connected a bank account to workspace.
Open New Expensify app.
Go to Settings > Workspaces > Workspace > Bank account.
Expected Result:
The bank account icon should be displayed on the added account, like the one displayed on the Wallet page.
Actual Result:
There is a green square in the place of the bank account icon.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@rushatgabhane / @shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@rushatgabhane / @shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@rushatgabhane / @shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The PR that introduced the bug has been identified. Link to the PR: Expo image #30905
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Expo image #30905 (comment)
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No because it was a giant refacto.
Determine if we should create a regression test for this bug. No.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - No
Activity
github-actions commentedon Dec 26, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 26, 2023
Triggered auto assignment to @neil-marcellini (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.shubham1206agra commentedon Dec 26, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue
Bank Account - Green square in place of BA icon
What is the root cause of that problem?
This is happening from 3dc4373, cause they missed the EnableStep component while refactoring.
What changes do you think we should make in order to solve the problem?
Add displayInDefaultIconColor in MenuItem in EnableStep
What alternative solutions did you explore? (Optional)
shubham1206agra commentedon Dec 26, 2023
Fixed
shubham1206agra commentedon Dec 26, 2023
@mountiny Can you confirm the icon?
[-]Bank Account - Green square in place of BA icon[/-][+][$500] Bank Account - Green square in place of BA icon[/+]melvin-bot commentedon Dec 26, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01e1b5b4f91e738c9a
33 remaining items
melvin-bot commentedon Dec 28, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
rushatgabhane commentedon Jan 2, 2024
The PR that introduced the bug has been identified. Link to the PR: Expo image #30905
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Expo image #30905 (comment)
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No because it was a giant refacto.
Determine if we should create a regression test for this bug. No.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - No
JmillsExpensify commentedon Jan 2, 2024
Still two days to go, though I'm going to handle payment in Expensify anyway. $500 payment approved for @rushatgabhane based on this comment.
NicMendonca commentedon Jan 4, 2024
@shubham1206agra you've been paid via Upwork!
NicMendonca commentedon Jan 5, 2024
@rushatgabhane just a bump on the BZ checklist!
melvin-bot commentedon Jan 9, 2024
@NicMendonca, @rushatgabhane, @mountiny, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
rushatgabhane commentedon Jan 10, 2024
Checklist here #33602 (comment)
This issue can be closed
mountiny commentedon Jan 10, 2024
@NicMendonca we need to pay to @shubham1206agra before closing
NicMendonca commentedon Jan 10, 2024
@mountiny yep I did - #33602 (comment)
NicMendonca commentedon Jan 10, 2024
@rushatgabhane thanks!