You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Distance - App redirects to expense report when returning online after editing distance offline #33622
Version Number: 1.4.17-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@neil-marcellini@allroundexperts@dukenv0307 This is linked to PR you have been involved in, it does seem though that this is already in production if I am not mistaken and given its edge case I would vote this is not a blocker. @tgolen let me know what you think?
I reverted the changes from #33266 locally, and I had trouble reproducing the issue because there is a bug that the PR fixes where you can't save the request in offline mode (clicking the save button does nothing). So, I'm not so sure that PR caused the redirect issue.
I do agree with @mountiny that the redirect issue reported here is not bad enough to be a deploy blocker. Everything works, it's just you end up in a slightly different place and it's easy to go back to the details.
I'm removing the deploy blocker label and I think we should consider opening this bug up to contributors to find the cause of it.
changed the title [-][HOLD #31411 ] Distance - App redirects to expense report when returning online after editing distance offline[/-][+][HOLD #33114] Distance - App redirects to expense report when returning online after editing distance offline[/+]on Mar 5, 2024
changed the title [-][HOLD #33114] Distance - App redirects to expense report when returning online after editing distance offline[/-][+]Distance - App redirects to expense report when returning online after editing distance offline[/+]on Mar 15, 2024
Activity
github-actions commentedon Dec 26, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 26, 2023
Triggered auto assignment to @tgolen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.tgolen commentedon Dec 26, 2023
I'll start investigating. It's possible it was caused by #33266 but I want to verify that.
mountiny commentedon Dec 26, 2023
@neil-marcellini @allroundexperts @dukenv0307 This is linked to PR you have been involved in, it does seem though that this is already in production if I am not mistaken and given its edge case I would vote this is not a blocker. @tgolen let me know what you think?
tgolen commentedon Dec 26, 2023
I reverted the changes from #33266 locally, and I had trouble reproducing the issue because there is a bug that the PR fixes where you can't save the request in offline mode (clicking the save button does nothing). So, I'm not so sure that PR caused the redirect issue.
I do agree with @mountiny that the redirect issue reported here is not bad enough to be a deploy blocker. Everything works, it's just you end up in a slightly different place and it's easy to go back to the details.
I'm removing the deploy blocker label and I think we should consider opening this bug up to contributors to find the cause of it.
melvin-bot commentedon Dec 26, 2023
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.23 remaining items
paultsimura commentedon Mar 5, 2024
@bfitzexpensify we might want to hold for #33114 as well — it fills the gaps the first PR missed
[-][HOLD #31411 ] Distance - App redirects to expense report when returning online after editing distance offline[/-][+][HOLD #33114] Distance - App redirects to expense report when returning online after editing distance offline[/+]bfitzexpensify commentedon Mar 5, 2024
Thanks for the heads-up @paultsimura, I'll get QA to pause on the retesting for the moment then.
[-][HOLD #33114] Distance - App redirects to expense report when returning online after editing distance offline[/-][+]Distance - App redirects to expense report when returning online after editing distance offline[/+]bfitzexpensify commentedon Mar 15, 2024
#33114 is live - getting QA to retest this.
kavimuru commentedon Mar 15, 2024
@bfitzexpensify Issue is not reproducible by the tester.
20240315_221608.mp4
bfitzexpensify commentedon Mar 15, 2024
Great! Let's close this one out then.