Skip to content

[$500] mWeb - Settings - Transitions not smooth in settings navigation #33628

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.17.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal team
Slack conversation:

Issue found when executing PR #32267

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Go to Settings
  3. Navigate to some pages

Expected Result:

Transaction should be smooth

Actual Result:

Transitions not smooth in settings navigation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

32267.Desktop.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015d4616de7bef61fc
  • Upwork Job ID: 1739766508742758400
  • Last Price Increase: 2024-01-16

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 26, 2023
  2. changed the title [-]Settings - Transitions not smooth in settings navigation[/-] [+][$500] Settings - Transitions not smooth in settings navigation[/+] on Dec 26, 2023
  3. melvin-bot commented on Dec 26, 2023

    @melvin-bot
  4. melvin-bot commented on Dec 26, 2023

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 26, 2023
  6. melvin-bot commented on Dec 26, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot commented on Dec 26, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

  8. ishpaul777 commented on Dec 26, 2023

    @ishpaul777
    Contributor

    Proposal

    When workspace, Preferences, Security are clicked in settings, there is no stacking over animation from left side

    Root Cause

    Due to heavy lottie Illustrations, the transition animation is inturupted and there is noticable stuck of transition sometimes

    Changes

    1. We need to remove autoplay from Lottie component and play after all interactions, we can either use InteractionManager.runAfterInteractions or onEntryTransitionEnd prop in ScrenWrapper by passing it in HeaderPageLayout in IllustratedHeaderPageLayout
    useEffect(() => {
            InteractionManager.runAfterInteractions(() => {
                animationRef.current.play();
            });
        }, []);

    or

      onEntryTransitionEnd={() =>  animationRef.current.play(); } 
  9. tienifr commented on Dec 27, 2023

    @tienifr
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Transitions not smooth in settings navigation

    What is the root cause of that problem?

    Because the Lottie component is so heavy, and it's rendered while RHP is moving -> transition is not smooth

    What changes do you think we should make in order to solve the problem?

    We should wait for transition end then render the Lottie component

    1. In Lottie, add new props showShowPlaceHolder, and if it's true, we will show the placeholder
        if (isError || showShowPlaceHolder) {
            return <View style={aspectRatioStyle} />;
        }
    
    1. In IllustratedHeaderPageLayout, we change the headerContent to function
    headerContent={
                    (didScreenTransitionEnd)=>{
                        return <>
                        <Lottie
                            showShowPlaceHolder={!didScreenTransitionEnd}
    ...
    
    1. In HeaderPageLayout, we will call headerContent if it's function
                {({safeAreaPaddingBottomStyle, didScreenTransitionEnd}) => (
    ...
                {_.isFunction(headerContent)? headerContent(didScreenTransitionEnd):headerContent}
    

    What alternative solutions did you explore? (Optional)

    Instead of showing the empty placeholder we can create the thumbnail and just show it when didScreenTransitionEnd is false

    Result

    Screen.Recording.2023-12-27.at.17.51.27.mov
  10. bfitzexpensify commented on Dec 29, 2023

    @bfitzexpensify
    Contributor

    Couple of proposals ready for review @thesahindia

  11. 19 remaining items

  12. melvin-bot commented on Jan 17, 2024

    @melvin-bot

    @bfitzexpensify, @thesahindia Huh... This is 4 days overdue. Who can take care of this?

  13. bfitzexpensify commented on Jan 17, 2024

    @bfitzexpensify
    Contributor

    Hm, looks like my label adding didn't work last week. Re-adding a second BZ team member from my comment in #33628 (comment).

  14. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 17, 2024
  15. melvin-bot commented on Jan 17, 2024

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  16. bfitzexpensify commented on Jan 18, 2024

    @bfitzexpensify
    Contributor

    @CortneyOfstad and @thesahindia - are either of you able to reproduce this?

  17. CortneyOfstad commented on Jan 22, 2024

    @CortneyOfstad
    Contributor

    Sorry for the delay here – no, I am unable to reproduce. @thesahindia are you able to?

  18. thesahindia commented on Jan 22, 2024

    @thesahindia
    Member

    Same here. Not reproducible for me.

  19. CortneyOfstad commented on Jan 22, 2024

    @CortneyOfstad
    Contributor

    Okay, let's close this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions