You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] mWeb - Settings - Transitions not smooth in settings navigation #33628
Version Number: 1.4.17.1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal team Slack conversation:
changed the title [-]Settings - Transitions not smooth in settings navigation[/-][+][$500] Settings - Transitions not smooth in settings navigation[/+]on Dec 26, 2023
When workspace, Preferences, Security are clicked in settings, there is no stacking over animation from left side
Root Cause
Due to heavy lottie Illustrations, the transition animation is inturupted and there is noticable stuck of transition sometimes
Changes
We need to remove autoplay from Lottie component and play after all interactions, we can either use InteractionManager.runAfterInteractions or onEntryTransitionEnd prop in ScrenWrapper by passing it in HeaderPageLayout in IllustratedHeaderPageLayout
Activity
[-]Settings - Transitions not smooth in settings navigation[/-][+][$500] Settings - Transitions not smooth in settings navigation[/+]melvin-bot commentedon Dec 26, 2023
Job added to Upwork: https://www.upwork.com/jobs/~015d4616de7bef61fc
melvin-bot commentedon Dec 26, 2023
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Dec 26, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Dec 26, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (
External)ishpaul777 commentedon Dec 26, 2023
Proposal
When workspace, Preferences, Security are clicked in settings, there is no stacking over animation from left side
Root Cause
Due to heavy lottie Illustrations, the transition animation is inturupted and there is noticable stuck of transition sometimes
Changes
or
tienifr commentedon Dec 27, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Transitions not smooth in settings navigation
What is the root cause of that problem?
Because the Lottie component is so heavy, and it's rendered while RHP is moving -> transition is not smooth
What changes do you think we should make in order to solve the problem?
We should wait for transition end then render the Lottie component
showShowPlaceHolder, and if it's true, we will show the placeholderWhat alternative solutions did you explore? (Optional)
Instead of showing the empty placeholder we can create the thumbnail and just show it when
didScreenTransitionEndis falseResult
Screen.Recording.2023-12-27.at.17.51.27.mov
bfitzexpensify commentedon Dec 29, 2023
Couple of proposals ready for review @thesahindia
19 remaining items
melvin-bot commentedon Jan 17, 2024
@bfitzexpensify, @thesahindia Huh... This is 4 days overdue. Who can take care of this?
bfitzexpensify commentedon Jan 17, 2024
Hm, looks like my label adding didn't work last week. Re-adding a second BZ team member from my comment in #33628 (comment).
melvin-bot commentedon Jan 17, 2024
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.bfitzexpensify commentedon Jan 18, 2024
@CortneyOfstad and @thesahindia - are either of you able to reproduce this?
CortneyOfstad commentedon Jan 22, 2024
Sorry for the delay here – no, I am unable to reproduce. @thesahindia are you able to?
thesahindia commentedon Jan 22, 2024
Same here. Not reproducible for me.
CortneyOfstad commentedon Jan 22, 2024
Okay, let's close this 👍