You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Task – Reply remains under the task after deleting the subtask #33734
Version Number: 1.4.19-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
changed the title [-]Task – Reply remains under the task after deleting the subtask[/-][+][$500] Task – Reply remains under the task after deleting the subtask[/+]on Dec 29, 2023
Please re-state the problem that we are trying to solve in this issue.
Reply remains under the task after deleting the subtask
What is the root cause of that problem?
We're not reducing the childVisibleActionCount of the parentReportAction of the parent task when deleting a subtask.
So the reply will still show.
What changes do you think we should make in order to solve the problem?
If the subtask has no child visible report action (by checking its childVisibleActionCount), reduce the childVisibleActionCount of the parentReportAction of the parent task when deleting a subtask, this needs to be done both optimistically (so it works in offline mode), and also in the back-end.
We're already doing the same when deleting comment here (works well for deleting comment in the task thread), so can just apply similar logic for deleting sub task.
What alternative solutions did you explore? (Optional)
Optionally reduce the childCommenterCount as well
I don't think so, but if this is the correct expectation, then we should not reduce the subtask childVisibleActionCount and childCommenterCount to 0 after it's deleted (likely the system message should be considered a visible report action), then the sub task will not be hidden after it's deleted.
Activity
melvin-bot commentedon Dec 29, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01f66de9449a2f9b75
[-]Task – Reply remains under the task after deleting the subtask[/-][+][$500] Task – Reply remains under the task after deleting the subtask[/+]melvin-bot commentedon Dec 29, 2023
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Dec 29, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Dec 29, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (
External)jliexpensify commentedon Dec 29, 2023
Tagged DB in #vip-vsb here
rushatgabhane commentedon Dec 29, 2023
bumped it on slack. the fix should be simple
https://expensify.slack.com/archives/C01GTK53T8Q/p1703814046408069
dukenv0307 commentedon Dec 29, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Reply remains under the task after deleting the subtask
What is the root cause of that problem?
We're not reducing the
childVisibleActionCountof theparentReportActionof the parent task when deleting a subtask.So the reply will still show.
What changes do you think we should make in order to solve the problem?
If the subtask has no child visible report action (by checking its
childVisibleActionCount), reduce thechildVisibleActionCountof theparentReportActionof the parent task when deleting a subtask, this needs to be done both optimistically (so it works in offline mode), and also in the back-end.We're already doing the same when deleting comment here (works well for deleting comment in the task thread), so can just apply similar logic for deleting sub task.
What alternative solutions did you explore? (Optional)
Optionally reduce the
childCommenterCountas wellI don't think so, but if this is the correct expectation, then we should not reduce the subtask
childVisibleActionCountandchildCommenterCountto 0 after it's deleted (likely the system message should be considered a visible report action), then the sub task will not be hidden after it's deleted.73 remaining items
jliexpensify commentedon Apr 22, 2024
Moreso we're not pinged every week lol
neil-marcellini commentedon May 28, 2024
I've hadn't had time or thought about this for a while, but maybe I'll take a shot at it when I have some spare time.
jliexpensify commentedon Jul 1, 2024
Not overdue.
neil-marcellini commentedon Jul 1, 2024
Too much on my plate still, pushing this off again.
jliexpensify commentedon Aug 2, 2024
Not overdue
neil-marcellini commentedon Aug 2, 2024
I'm going to close this because it's #vip-vsb related and that's on pause.