You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[WAITING ON CHECKLIST][$500] IOU-Order of display of date and distance is different in distance confirmation & details page #33751
Version Number: 1.4.19-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause-Internal Team Slack conversation: @
Note in distance request confirmation page, first date and then distance section is displayed.
Tap distance
Tap on distance request created to open distance request details page
Note in distance request details page, first distance and then date section is displayed.
Expected Result:
The order of display of date and distance must be same in distance confirmation & details page.
Actual Result:
The order of display of date and distance is different in distance confirmation & details page.
In distance request confirmation page, first date and then distance section is displayed. In distance request details page, first distance and then date section is displayed.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]IOU-Order of display of date and distance is different in distance confirmation & details page[/-][+][$500] IOU-Order of display of date and distance is different in distance confirmation & details page[/+]on Dec 29, 2023
Please re-state the problem that we are trying to solve in this issue.
The order of display of date and distance is different in distance confirmation & details page.
What is the root cause of that problem?
The MenuItemWithTopDescription for date and distance are just in different order between the 2 pages here and here.
What changes do you think we should make in order to solve the problem?
Make the MenuItemWithTopDescription for date and distance are the same between the 2 pages. I think the user is interested in Distance first so it should go first, but the other way is fine.
Also the Merchant and Date order for non-distance are also inconsistent due to the same reason, we should make them consistent too (Merchant should likely be first)
We can apply the ordering to MoneyRequestConfirmationList as well besides the MoneyTemporaryForRefactorRequestConfirmationList.
What alternative solutions did you explore? (Optional)
Proposal updated to add permalinks to pages, also to clarify the following additional issue
Also the Merchant and Date order for non-distance are also inconsistent due to the same reason, we should make them consistent too (Merchant should likely be first)
changed the title [-][$500] IOU-Order of display of date and distance is different in distance confirmation & details page[/-][+][HOLD for payment 2024-01-22] [$500] IOU-Order of display of date and distance is different in distance confirmation & details page[/+]on Jan 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2024-01-22] [$500] IOU-Order of display of date and distance is different in distance confirmation & details page[/-][+][WAITING ON CHECKLIST][$500] IOU-Order of display of date and distance is different in distance confirmation & details page[/+]on Jan 22, 2024
Determine if we should create a regression test for this bug: Yes
1. Open App
2. Create a distance request
3. In the confirm page, verify that the distance field is above the date field
4. Confirm the request and go to the transaction thread report
5. Verify that the distance field is above the date field
Activity
[-]IOU-Order of display of date and distance is different in distance confirmation & details page[/-][+][$500] IOU-Order of display of date and distance is different in distance confirmation & details page[/+]melvin-bot commentedon Dec 29, 2023
Job added to Upwork: https://www.upwork.com/jobs/~014b42dbccdf1e5222
melvin-bot commentedon Dec 29, 2023
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Dec 29, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Dec 29, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (
External)dukenv0307 commentedon Dec 29, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
The order of display of date and distance is different in distance confirmation & details page.
What is the root cause of that problem?
The
MenuItemWithTopDescriptionfor date and distance are just in different order between the 2 pages here and here.What changes do you think we should make in order to solve the problem?
Make the
MenuItemWithTopDescriptionfor date and distance are the same between the 2 pages. I think the user is interested in Distance first so it should go first, but the other way is fine.Also the
MerchantandDateorder for non-distance are also inconsistent due to the same reason, we should make them consistent too (Merchantshould likely be first)We can apply the ordering to
MoneyRequestConfirmationListas well besides theMoneyTemporaryForRefactorRequestConfirmationList.What alternative solutions did you explore? (Optional)
NA
FitseTLT commentedon Dec 29, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
IOU-Order of display of date and distance is different in distance confirmation & details page
What is the root cause of that problem?
in confirmation date comes before distance
App/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js
Lines 649 to 673 in 7d1b0f8
while it is oposite for request view
App/src/components/ReportActionItem/MoneyRequestView.js
Lines 228 to 263 in 7d1b0f8
What changes do you think we should make in order to solve the problem?
We should choose one oreder and make it consistent for both
What alternative solutions did you explore? (Optional)
dukenv0307 commentedon Dec 29, 2023
Proposal updated to add permalinks to pages, also to clarify the following additional issue
26 remaining items
[-][$500] IOU-Order of display of date and distance is different in distance confirmation & details page[/-][+][HOLD for payment 2024-01-22] [$500] IOU-Order of display of date and distance is different in distance confirmation & details page[/+]melvin-bot commentedon Jan 15, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-22. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 15, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
jliexpensify commentedon Jan 22, 2024
@fedirjh bump to complete the checklist please!
jliexpensify commentedon Jan 22, 2024
Payment Summary
Upwork job
jliexpensify commentedon Jan 22, 2024
Paid and posting removed. Waiting on checklist from @fedirjh
[-][HOLD for payment 2024-01-22] [$500] IOU-Order of display of date and distance is different in distance confirmation & details page[/-][+][WAITING ON CHECKLIST][$500] IOU-Order of display of date and distance is different in distance confirmation & details page[/+]fedirjh commentedon Jan 23, 2024
BugZero Checklist: