You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-25] [$500] mWeb - Request – "Only visible to you" does not disappear when edit an amount field of scan IOU #33940
Version Number: 1.4.21.1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
changed the title [-]mWeb - Request – "Only visible to you" does not disappear when edit an amount field of scan IOU[/-][+][$500] mWeb - Request – "Only visible to you" does not disappear when edit an amount field of scan IOU[/+]on Jan 4, 2024
Please re-state the problem that we are trying to solve in this issue.
The “Scan in progress” message is displayed
What is the root cause of that problem?
We're not optimistically update the whisperedToAccountIDs list of the parent report actions to empty when editing amount/currency of a scanning request.
, but recently we migrate to more granular update endpoint for amount/currency/... (see here) which does not have the logic so it no longer works.
What changes do you think we should make in order to solve the problem?
Optimistically update the whisperedToAccountIDs list of the parent report actions to empty when editing amount/currency of a scanning request and after that the request is no longer scanning. We can use similar logic to here.
We need to check other types of edits as well.
What alternative solutions did you explore? (Optional)
Double check smartscan-related features like updating the transaction receipt state to make sure it still works correctly after the granular edit amount/currency endpoint change.
changed the title [-][$500] mWeb - Request – "Only visible to you" does not disappear when edit an amount field of scan IOU[/-][+][HOLD for payment 2024-01-25] [$500] mWeb - Request – "Only visible to you" does not disappear when edit an amount field of scan IOU[/+]on Jan 18, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
I don't find the offending PR. We might forget to update the data optimistically while working on the feature.
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Suitable for the regression step.
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Start the request money flow > "Scan" receipt as the employee.
Upload a blurry receipt/make a photo.
Complete the money request flow.
While the receipt is scanning - navigate to the request conversation
Manually edit the amount field
Navigate back to the workspace chat
Verify that the “Scan in progress” message is no longer displayed
👍 or 👎
@anmurali Could you give the payment summary? I'll do manual request in NewDot afterward, thank you!
Activity
[-]mWeb - Request – "Only visible to you" does not disappear when edit an amount field of scan IOU[/-][+][$500] mWeb - Request – "Only visible to you" does not disappear when edit an amount field of scan IOU[/+]melvin-bot commentedon Jan 4, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01474415f07a92aeb4
melvin-bot commentedon Jan 4, 2024
Triggered auto assignment to @anmurali (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jan 4, 2024
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Jan 4, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (
External)tienifr commentedon Jan 4, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The “Scan in progress” message is displayed
What is the root cause of that problem?
We're not optimistically update the
whisperedToAccountIDslist of the parent report actions to empty when editing amount/currency of a scanning request.The logic works before as can be seen in
App/src/libs/actions/IOU.js
Line 2147 in dc3e19b
What changes do you think we should make in order to solve the problem?
Optimistically update the
whisperedToAccountIDslist of the parent report actions to empty when editing amount/currency of a scanning request and after that the request is no longer scanning. We can use similar logic to here.We need to check other types of edits as well.
What alternative solutions did you explore? (Optional)
Double check smartscan-related features like updating the transaction receipt state to make sure it still works correctly after the granular edit amount/currency endpoint change.
mollfpr commentedon Jan 8, 2024
The issue is more noticeable when editing the scan money request offline.
I agree with the @tienifr proposal, and the proposal looks good to me!
🎀 👀 🎀 C+ reviewed!
9 remaining items
[-][$500] mWeb - Request – "Only visible to you" does not disappear when edit an amount field of scan IOU[/-][+][HOLD for payment 2024-01-25] [$500] mWeb - Request – "Only visible to you" does not disappear when edit an amount field of scan IOU[/+]melvin-bot commentedon Jan 18, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 18, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-25. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 18, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mollfpr commentedon Jan 24, 2024
I don't find the offending PR. We might forget to update the data optimistically while working on the feature.
Suitable for the regression step.
@anmurali Could you give the payment summary? I'll do manual request in NewDot afterward, thank you!
mollfpr commentedon Jan 30, 2024
Friendly bump @anmurali
mallenexpensify commentedon Feb 6, 2024
Contributor: @tienifr paid $500 via Upwork
Contributor+: @mollfpr owed $500 via NewDot
Testrail GH is here https://github.com/Expensify/Expensify/issues/367234
Think we're good to close, comment/reopen if needed.
JmillsExpensify commentedon Feb 6, 2024
$500 approved for @mollfpr based on summary above.