Skip to content

[HOLD for payment 2024-01-25] [$500] mWeb - Request – "Only visible to you" does not disappear when edit an amount field of scan IOU #33940

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.21.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in
  3. Start the request money flow > "Scan" receipt as the employee.
  4. Upload a blurry receipt/make a photo.
  5. Complete the money request flow.
  6. While the receipt is scanning - navigate to the request conversation
  7. Manually edit the amount field
  8. Navigate back to the workspace chat

Expected Result:

The “Scan in progress” message is no longer displayed

Actual Result:

The “Scan in progress” message is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6332006_1704363015268.Only_visible_to_you.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01474415f07a92aeb4
  • Upwork Job ID: 1742851749087182848
  • Last Price Increase: 2024-01-04
  • Automatic offers:
    • mollfpr | Reviewer | 28093519
    • tienifr | Contributor | 28093520

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 4, 2024
  2. changed the title [-]mWeb - Request – "Only visible to you" does not disappear when edit an amount field of scan IOU[/-] [+][$500] mWeb - Request – "Only visible to you" does not disappear when edit an amount field of scan IOU[/+] on Jan 4, 2024
  3. melvin-bot commented on Jan 4, 2024

    @melvin-bot
  4. melvin-bot commented on Jan 4, 2024

    @melvin-bot

    Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 4, 2024
  6. melvin-bot commented on Jan 4, 2024

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot commented on Jan 4, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

  8. tienifr commented on Jan 4, 2024

    @tienifr
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The “Scan in progress” message is displayed

    What is the root cause of that problem?

    We're not optimistically update the whisperedToAccountIDs list of the parent report actions to empty when editing amount/currency of a scanning request.

    The logic works before as can be seen in

    ...(!isScanning
    , but recently we migrate to more granular update endpoint for amount/currency/... (see here) which does not have the logic so it no longer works.

    What changes do you think we should make in order to solve the problem?

    Optimistically update the whisperedToAccountIDs list of the parent report actions to empty when editing amount/currency of a scanning request and after that the request is no longer scanning. We can use similar logic to here.

    We need to check other types of edits as well.

    What alternative solutions did you explore? (Optional)

    Double check smartscan-related features like updating the transaction receipt state to make sure it still works correctly after the granular edit amount/currency endpoint change.

  9. mollfpr commented on Jan 8, 2024

    @mollfpr
    Contributor

    The issue is more noticeable when editing the scan money request offline.

    I agree with the @tienifr proposal, and the proposal looks good to me!

    🎀 👀 🎀 C+ reviewed!

  10. 9 remaining items

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 11, 2024
  12. changed the title [-][$500] mWeb - Request – "Only visible to you" does not disappear when edit an amount field of scan IOU[/-] [+][HOLD for payment 2024-01-25] [$500] mWeb - Request – "Only visible to you" does not disappear when edit an amount field of scan IOU[/+] on Jan 18, 2024
  13. melvin-bot commented on Jan 18, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Jan 18, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-01-25. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Jan 18, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
    • [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@mollfpr] Determine if we should create a regression test for this bug.
    • [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. mollfpr commented on Jan 24, 2024

    @mollfpr
    Contributor

    [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
    [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    I don't find the offending PR. We might forget to update the data optimistically while working on the feature.

    [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    Suitable for the regression step.

    [@mollfpr] Determine if we should create a regression test for this bug.
    [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    1. Start the request money flow > "Scan" receipt as the employee.
    2. Upload a blurry receipt/make a photo.
    3. Complete the money request flow.
    4. While the receipt is scanning - navigate to the request conversation
    5. Manually edit the amount field
    6. Navigate back to the workspace chat
    7. Verify that the “Scan in progress” message is no longer displayed
    8. 👍 or 👎

    @anmurali Could you give the payment summary? I'll do manual request in NewDot afterward, thank you!

  17. mollfpr commented on Jan 30, 2024

    @mollfpr
    Contributor

    Friendly bump @anmurali

  18. mallenexpensify commented on Feb 6, 2024

    @mallenexpensify
    Contributor

    Contributor: @tienifr paid $500 via Upwork
    Contributor+: @mollfpr owed $500 via NewDot

    Testrail GH is here https://github.com/Expensify/Expensify/issues/367234

    Think we're good to close, comment/reopen if needed.

  19. JmillsExpensify commented on Feb 6, 2024

    @JmillsExpensify
    Contributor

    $500 approved for @mollfpr based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions