You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-18] [HOLD for payment 2024-01-17] Scan - No red dot for Amount and Merchant when viewing failed scan request as Admin #34179
Version Number: 1.4.23-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
[Member] Go to workspace chat.
[Member] Create scan request with receipt that will fail the scanning.
[Admin] When the scanning fails, navigate to the workspace chat with member.
[Admin] Open the request details view.
Expected Result:
Admin sees red dot for empty Amount and Merchant row
Actual Result:
There is no red dot for Amount and Merchant when viewing as Admin
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@s-alves10 that would allow the admin to edit a receipt, we decided in the past that there are no use cases for an admin or manager to update the receipt of the request.
changed the title [-]Scan - No red dot for Amount and Merchant when viewing failed scan request as Admin[/-][+][HOLD for payment 2024-01-17] Scan - No red dot for Amount and Merchant when viewing failed scan request as Admin[/+]on Jan 10, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-][HOLD for payment 2024-01-17] Scan - No red dot for Amount and Merchant when viewing failed scan request as Admin[/-][+][HOLD for payment 2024-01-18] [HOLD for payment 2024-01-17] Scan - No red dot for Amount and Merchant when viewing failed scan request as Admin[/+]on Jan 11, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
github-actions commentedon Jan 9, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Jan 9, 2024
Triggered auto assignment to @arosiclair (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.dummy-1111 commentedon Jan 9, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
No red dot for amount and merchant appear when admin viewing failed scan request
What is the root cause of that problem?
This looks like a regression of this PR #33633
We check the editability of the receipt here
App/src/libs/ReportUtils.ts
Lines 1950 to 1953 in 5df6055
As you can see, only requestor can edit the request. So the admin can't edit the request and
canEditReceiptwill befalseApp/src/components/ReportActionItem/MoneyRequestView.js
Line 161 in 5df6055
So
hasErrorswill befalseas well.App/src/components/ReportActionItem/MoneyRequestView.js
Line 225 in 5df6055
This is the root cause
What changes do you think we should make in order to solve the problem?
I think the admin or manager should be able to edit the scan request as well
Update the code
App/src/libs/ReportUtils.ts
Lines 1950 to 1953 in 5df6055
to
isAdminandisManagerare defined asApp/src/libs/ReportUtils.ts
Lines 1942 to 1944 in 5df6055
Result
What alternative solutions did you explore? (Optional)
youssef-lr commentedon Jan 9, 2024
@s-alves10 that would allow the admin to edit a receipt, we decided in the past that there are no use cases for an admin or manager to update the receipt of the request.
melvin-bot commentedon Jan 9, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0131c5620c048a6293
melvin-bot commentedon Jan 9, 2024
Triggered auto assignment to Contributor Plus for review of internal employee PR - @akinwale (
Internal)dummy-1111 commentedon Jan 9, 2024
If so, I think this isn't a bug and we can close this out
10 remaining items
thienlnam commentedon Jan 10, 2024
Looks like a fix was merged but I'll ask to get it CPed so we can get rid of the blocker
[-]Scan - No red dot for Amount and Merchant when viewing failed scan request as Admin[/-][+][HOLD for payment 2024-01-17] Scan - No red dot for Amount and Merchant when viewing failed scan request as Admin[/+]melvin-bot commentedon Jan 10, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 10, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-17. 🎊
For reference, here are some details about the assignees on this issue:
[-][HOLD for payment 2024-01-17] Scan - No red dot for Amount and Merchant when viewing failed scan request as Admin[/-][+][HOLD for payment 2024-01-18] [HOLD for payment 2024-01-17] Scan - No red dot for Amount and Merchant when viewing failed scan request as Admin[/+]melvin-bot commentedon Jan 11, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-18. 🎊
For reference, here are some details about the assignees on this issue:
youssef-lr commentedon Jan 12, 2024
No payment needed here.