Skip to content

[$500] [HOLD for payment 2024-01-26] Request Money - User is redirected to chat then IOU report after deleting request offline #34263

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.24-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go offline.
  2. Go to 1:1 DM.
  3. Create a money request.
  4. Go to request details page.
  5. Tap 3-dot menu > Delete request.
  6. Delete the request.

Expected Result:

User is redirected to the main chat after deleting the request.

Actual Result:

User is redirected to the main chat first, then back to IOU report.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6337882_1704903684423.Screen_Recording_20240110_222315_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01abb6552e1259c745
  • Upwork Job ID: 1749405409534021632
  • Last Price Increase: 2024-01-22

Activity

  1. github-actions commented on Jan 10, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Jan 10, 2024

    @melvin-bot

    Triggered auto assignment to @blimpich (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. blimpich commented on Jan 10, 2024

    @blimpich
    Contributor

    Looking at this now.

  4. blimpich commented on Jan 10, 2024

    @blimpich
    Contributor

    Borked my VM, taking awhile to fix it in order to test this out locally.

  5. situchan commented on Jan 10, 2024

    @situchan
    Contributor

    #34244 was deployed to staging. This can be easily tested without manually scrolling.
    Maybe ask QA team to re-test?

    Edit: sorry commented in wrong issue 🙏

  6. blimpich commented on Jan 10, 2024

    @blimpich
    Contributor

    Hmmm I don't see how that PR would fix this bug but if you think its worthwhile @situchan then I see no harm in trying. @kbecciv would you mind testing again?

  7. kbecciv commented on Jan 10, 2024

    @kbecciv
    Author

    Issue is reproduced on build 1.4.24.0

    Screen_Recording_20240110_162525_New.Expensify.mp4
  8. blimpich commented on Jan 10, 2024

    @blimpich
    Contributor

    Alright taking a look at this again.

  9. blimpich commented on Jan 10, 2024

    @blimpich
    Contributor

    I believe #32698 is causing this. I reproduced the error locally, reverted that PR, and then couldn't reproduce it locally again. @rojiphil @fedirjh can you confirm / any idea why this error would be happening, and how we could fix it?

  10. rojiphil commented on Jan 11, 2024

    @rojiphil
    Contributor

    Looking into this now

  11. 31 remaining items

  12. melvin-bot commented on Jan 22, 2024

    @melvin-bot

    Current assignee @fedirjh is eligible for the External assigner, not assigning anyone new.

  13. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 22, 2024
  14. laurenreidexpensify commented on Jan 22, 2024

    @laurenreidexpensify
    Contributor
  15. blimpich commented on Jan 22, 2024

    @blimpich
    Contributor

    @laurenreidexpensify sorry I forgot to comment here but payment for this issue was handled by this issue already #26511. I should have commented.

  16. blimpich commented on Jan 22, 2024

    @blimpich
    Contributor

    See this comment: #26511 (comment)

  17. laurenreidexpensify commented on Jan 23, 2024

    @laurenreidexpensify
    Contributor

    Ah cool - if that's the case then @fedirjh please complete checklist and we can close. Thanks

  18. fedirjh commented on Jan 23, 2024

    @fedirjh
    Contributor

    @laurenreidexpensify This regression with a recent PR and the author already fixed it. It was marked as deploy blocker so I believe we have the necessary regression test in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions