You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] [HOLD for payment 2024-01-26] Request Money - User is redirected to chat then IOU report after deleting request offline #34263
Version Number: 1.4.24-0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Go offline.
Go to 1:1 DM.
Create a money request.
Go to request details page.
Tap 3-dot menu > Delete request.
Delete the request.
Expected Result:
User is redirected to the main chat after deleting the request.
Actual Result:
User is redirected to the main chat first, then back to IOU report.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Hmmm I don't see how that PR would fix this bug but if you think its worthwhile @situchan then I see no harm in trying. @kbecciv would you mind testing again?
I believe #32698 is causing this. I reproduced the error locally, reverted that PR, and then couldn't reproduce it locally again. @rojiphil@fedirjh can you confirm / any idea why this error would be happening, and how we could fix it?
@laurenreidexpensify This regression with a recent PR and the author already fixed it. It was marked as deploy blocker so I believe we have the necessary regression test in place.
Activity
github-actions commentedon Jan 10, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Jan 10, 2024
Triggered auto assignment to @blimpich (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.blimpich commentedon Jan 10, 2024
Looking at this now.
blimpich commentedon Jan 10, 2024
Borked my VM, taking awhile to fix it in order to test this out locally.
situchan commentedon Jan 10, 2024
#34244 was deployed to staging. This can be easily tested without manually scrolling.Maybe ask QA team to re-test?
Edit: sorry commented in wrong issue 🙏
blimpich commentedon Jan 10, 2024
Hmmm I don't see how that PR would fix this bug but if you think its worthwhile @situchan then I see no harm in trying. @kbecciv would you mind testing again?
kbecciv commentedon Jan 10, 2024
Issue is reproduced on build 1.4.24.0
Screen_Recording_20240110_162525_New.Expensify.mp4
blimpich commentedon Jan 10, 2024
Alright taking a look at this again.
blimpich commentedon Jan 10, 2024
I believe #32698 is causing this. I reproduced the error locally, reverted that PR, and then couldn't reproduce it locally again. @rojiphil @fedirjh can you confirm / any idea why this error would be happening, and how we could fix it?
rojiphil commentedon Jan 11, 2024
Looking into this now
31 remaining items
melvin-bot commentedon Jan 22, 2024
Current assignee @fedirjh is eligible for the External assigner, not assigning anyone new.
laurenreidexpensify commentedon Jan 22, 2024
@fedirjh @rojiphil pls apply to upwork job https://www.upwork.com/jobs/~01abb6552e1259c745
blimpich commentedon Jan 22, 2024
@laurenreidexpensify sorry I forgot to comment here but payment for this issue was handled by this issue already #26511. I should have commented.
blimpich commentedon Jan 22, 2024
See this comment: #26511 (comment)
laurenreidexpensify commentedon Jan 23, 2024
Ah cool - if that's the case then @fedirjh please complete checklist and we can close. Thanks
fedirjh commentedon Jan 23, 2024
@laurenreidexpensify This regression with a recent PR and the author already fixed it. It was marked as deploy blocker so I believe we have the necessary regression test in place.