Skip to content

Login - Magic code is sent to wrong email after editing when using ENTER key #34381

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.24-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to www.staging.new.expensify.com
  2. Enter any email and use Enter button to continue to next page
  3. On magic code page select "go back"
  4. Edit email and use "Enter" to continue

Expected Result:

Magic code is sent to new email entered

Actual Result:

Magic code is sent to initial email

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6339097_1704990681691.Video_2024_01_11-1.mp4

View all open jobs on GitHub

Activity

  1. github-actions commented on Jan 11, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Jan 11, 2024

    @melvin-bot

    Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. situchan commented on Jan 11, 2024

    @situchan
    Contributor

    Not reproducible on main

  4. dummy-1111 commented on Jan 11, 2024

    @dummy-1111
    Contributor

    This PR #34313 solved the issue
    The root cause is in here
    https://github.com/Expensify/App/pull/34313/files#diff-2a0d77decd98a62a279ac9fb139cad79d6d7a20f4c724de3dc811911bc5dd9b1L142-L151

    onPress wasn't added to the dependency. We can CP this PR

  5. amyevans commented on Jan 11, 2024

    @amyevans
    Contributor

    Yep thanks, confirmed not reproducible on main:

    main-34381.mov

    But reproducible on staging branch locally:

    staging-branch-local.mov

    I'll check in about the cherry pick, I'm surprised it hasn't been already

  6. situchan commented on Jan 11, 2024

    @situchan
    Contributor

    I think @Julesssss is requesting CP #34313

  7. amyevans commented on Jan 11, 2024

    @amyevans
    Contributor

    I think he's off for the night, I'm requesting it now

  8. amyevans commented on Jan 11, 2024

    @amyevans
    Contributor

    The CP is complete. I retested on staging to verify it's fixed:

    staging-fixed.mov
  9. Julesssss commented on Jan 12, 2024

    @Julesssss
    Contributor

    Oh thanks @amyevans I forgot to CP this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions