You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Login - Magic code is sent to wrong email after editing when using ENTER key #34381
Version Number: 1.4.24-4 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Activity
github-actions commentedon Jan 11, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Jan 11, 2024
Triggered auto assignment to @amyevans (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.situchan commentedon Jan 11, 2024
Not reproducible on main
dummy-1111 commentedon Jan 11, 2024
This PR #34313 solved the issue
The root cause is in here
https://github.com/Expensify/App/pull/34313/files#diff-2a0d77decd98a62a279ac9fb139cad79d6d7a20f4c724de3dc811911bc5dd9b1L142-L151
onPresswasn't added to the dependency. We can CP this PRamyevans commentedon Jan 11, 2024
Yep thanks, confirmed not reproducible on
main:main-34381.mov
But reproducible on
stagingbranch locally:staging-branch-local.mov
I'll check in about the cherry pick, I'm surprised it hasn't been already
situchan commentedon Jan 11, 2024
I think @Julesssss is requesting CP #34313
amyevans commentedon Jan 11, 2024
I think he's off for the night, I'm requesting it now
amyevans commentedon Jan 11, 2024
The CP is complete. I retested on staging to verify it's fixed:
staging-fixed.mov
Julesssss commentedon Jan 12, 2024
Oh thanks @amyevans I forgot to CP this